RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

Michael Haupt michael.haupt at oracle.com
Thu Mar 10 09:14:27 UTC 2016


Hi Sundar,

lower-case thumbs up, with one remark about the test. It seems the lower part of the test method is independent of the upper part; separate aspects should IMHO be tested separetely, i.e., in two different methods.

Best,

Michael

> Am 10.03.2016 um 10:06 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
> 
> Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8150731
> 
> Thanks,
> -Sundar

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the nashorn-dev mailing list