RFR 8158131: Nashorn should not use jdk.internal.module.Modules API
Hannes Wallnoefer
hannes.wallnoefer at oracle.com
Tue May 31 07:29:23 UTC 2016
Sorry for the slow review, I needed some explanation from Sundar about
the difficulties of dynamic module creation, cross-layer read edges etc.
With that knowledge +1 for this change.
Hannes
Am 2016-05-30 um 19:55 schrieb Alan Bateman:
> On 30/05/2016 11:43, Sundararajan Athijegannathan wrote:
>> Updated nashorn webrev:
>> http://cr.openjdk.java.net/~sundar/8158131/nashorn/webrev.01/
>>
>> * Added @link in ModuleGraphManipulator.java's javadoc
>>
>> * Using Context.class.getModule() in all places where nashorn module is
>> needed
>>
>> * Using all caps names for static final variables - nashornModule,
>> javaBaseModule, myModule in generated
>>
>>
> I looked over the changes and good to see it using the API to create
> dynamic modules. I assume folks familiar with the Nashorn code will do
> the detailed review.
>
> -Alan
More information about the nashorn-dev
mailing list