Review request for JDK-8167037: Remove CALL_METHOD support from internal Nashorn linkers
Sundararajan Athijegannathan
sundararajan.athijegannathan at oracle.com
Tue Oct 4 07:51:13 UTC 2016
+1
-Sundar
On 10/3/2016 10:47 PM, Attila Szegedi wrote:
> Please review JDK-8167037 "Remove CALL_METHOD support from internal Nashorn linkers" at <http://cr.openjdk.java.net/~attila/8167037/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8167037>
>
> Nashorn never emits CALL_METHOD Dynalink operation; therefore code for supporting it in internal linkers (those that only service call sites in Nashorn-generated bytecode) is unnecessary.
>
> I originally stumbled upon this inspecting ScriptObject.findCallMethodMethod() and noticed that the code was even somewhat incorrect by weakening the lookup of the call to public lookup. Thinking of fixing it, I realized it's actually never used.
>
> Thanks,
> Attila.
More information about the nashorn-dev
mailing list