Review request for JDK-8168005: Introduce namespaces for GET, SET Dynalink operations

Hannes Wallnöfer hannes.wallnoefer at oracle.com
Fri Oct 28 16:18:09 UTC 2016


> Am 28.10.2016 um 17:44 schrieb Attila Szegedi <szegedia at gmail.com>:
> 
> Thank you; can I consider this an approval on your part?

Yes. Sorry for omitting the +1. :)

Hannes

> 
>> On 27 Oct 2016, at 15:05, Hannes Wallnöfer <hannes.wallnoefer at oracle.com> wrote:
>> 
>> Hi Attila,
>> 
>> this looks good. Very nice work, the new API is indeed much nicer!
>> 
>> Hannes
>> 
>>> Am 26.10.2016 um 12:48 schrieb Attila Szegedi <szegedia at gmail.com>:
>>> 
>>> Please review JDK-8168005 "Introduce namespaces for GET, SET Dynalink operations" at <http://cr.openjdk.java.net/~attila/8168005/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8168005>
>>> 
>>> The JIRA issue has detailed rationale for the change. The diff is moderately large, but the Dynalink API changes are only a part of it, the rest is adjusting Nashorn, code examples, and tests to the changed API.
>>> 
>>> Thanks,
>>> Attila.
>>> 
>> 
> 



More information about the nashorn-dev mailing list