Review request for JDK-8193296: Parser should not eagerly transform delete expressions
Attila Szegedi
szegedia at gmail.com
Mon Dec 11 11:25:34 UTC 2017
Thanks!
I admittedly cribbed the various @tags from the neighboring JDK_8188098_Test class :-). I take it “@run testng …” is meaningful and understood by jtreg then, so I can leave that as it is? I tried to find other examples and stumbled upon e.g. JDK_8184723_Test which specifies “@run main/othervm” and also declares “@modules” - is that something I should be doing as well, and can you advice what would be the correct values?
Attila.
> On Dec 11, 2017, at 8:18 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> * Test misses copyright comment
> * you may want to add @bug <bug_id> and @summary line in jtreg comment section
>
> Other than that, +1
>
> -Sundar
>
> On 10/12/17, 9:52 PM, Attila Szegedi wrote:
>> Please review JDK-8193296 "Parser should not eagerly transform delete expressions" at<http://cr.openjdk.java.net/~attila/8193296/webrev.jdk<http://cr.openjdk.java.net/~attila/8193296/webrev.jdk>> for<https://bugs.openjdk.java.net/browse/JDK-8193296<https://bugs.openjdk.java.net/browse/JDK-8193296>>
>>
>> Thanks,
>> Attila.
>>
More information about the nashorn-dev
mailing list