Review request for JDK-8193295: Remove no longer used COMMALEFT
Attila Szegedi
szegedia at gmail.com
Thu Dec 21 18:20:25 UTC 2017
Please review JDK-8193295 "Remove no longer used COMMALEFT" at <http://cr.openjdk.java.net/~attila/8193295/webrev.jdk> for <https://bugs.openjdk.java.net/browse/JDK-8193295>
I love deleting code :-)
COMMALEFT was an odd duck, as there’s not really anything in the ES specification that’d require it, and we really don’t even use it for anything. I had a memory that we used to use it for some behavior around object literals, but I can’t find any traces of that… I run:
hg log --template "{ifcontains('COMMALEFT', diff(), '{node} {desc}\n', '')}”
and trawled through the diffs for all changesets it brought up, but I haven’t found a single use of COMMALEFT ever.
Thanks,
Attila.
More information about the nashorn-dev
mailing list