From priya.lakshmi.muthuswamy at oracle.com Fri Nov 3 06:06:28 2017 From: priya.lakshmi.muthuswamy at oracle.com (Priya Lakshmi Muthuswamy) Date: Fri, 3 Nov 2017 11:36:28 +0530 Subject: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected Message-ID: <6c39fee3-4847-98fb-f6d6-7c5d299c7f4d@oracle.com> Hi, Please review JDK-8186807: JSObject gets ScriptFunction when ScriptObjectMirror is expected JBS: https://bugs.openjdk.java.net/browse/JDK-8186807 webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/ Thanks, Priya From sundararajan.athijegannathan at oracle.com Fri Nov 3 09:10:49 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Fri, 03 Nov 2017 14:40:49 +0530 Subject: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop Message-ID: <59FC3299.9080907@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 Thanks, -Sundar From sundararajan.athijegannathan at oracle.com Fri Nov 3 09:41:48 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Fri, 03 Nov 2017 15:11:48 +0530 Subject: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected In-Reply-To: <6c39fee3-4847-98fb-f6d6-7c5d299c7f4d@oracle.com> References: <6c39fee3-4847-98fb-f6d6-7c5d299c7f4d@oracle.com> Message-ID: <59FC39DC.2060601@oracle.com> Two suggestions: * You may want to add a check to make sure that the control reached func.call method - there is an assert there but the test does not assert the control reached there * class name "func" be changed to "Func" or some such (capitalization of class names) -Sundar On 03/11/17, 11:36 AM, Priya Lakshmi Muthuswamy wrote: > Hi, > > Please review JDK-8186807: JSObject gets ScriptFunction when > ScriptObjectMirror is expected > > JBS: https://bugs.openjdk.java.net/browse/JDK-8186807 > webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/ > > Thanks, > Priya From priya.lakshmi.muthuswamy at oracle.com Fri Nov 3 11:45:50 2017 From: priya.lakshmi.muthuswamy at oracle.com (Priya Lakshmi Muthuswamy) Date: Fri, 3 Nov 2017 17:15:50 +0530 Subject: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected In-Reply-To: <59FC39DC.2060601@oracle.com> References: <6c39fee3-4847-98fb-f6d6-7c5d299c7f4d@oracle.com> <59FC39DC.2060601@oracle.com> Message-ID: Updated the webrev with modified testcase. webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/ Thanks, Priya On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote: > Two suggestions: > > * You may want to add a check to make sure that the control reached > func.call method > - there is an assert there but the test does not assert the control > reached there > > * class name "func" be changed to "Func" or some such (capitalization > of class names) > > -Sundar > > On 03/11/17, 11:36 AM, Priya Lakshmi Muthuswamy wrote: >> Hi, >> >> Please review JDK-8186807: JSObject gets ScriptFunction when >> ScriptObjectMirror is expected >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8186807 >> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/ >> >> Thanks, >> Priya From sundararajan.athijegannathan at oracle.com Fri Nov 3 12:27:34 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Fri, 03 Nov 2017 17:57:34 +0530 Subject: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected In-Reply-To: References: <6c39fee3-4847-98fb-f6d6-7c5d299c7f4d@oracle.com> <59FC39DC.2060601@oracle.com> Message-ID: <59FC60B6.8020903@oracle.com> +1 -Sundar On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote: > Updated the webrev with modified testcase. > > webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/ > > Thanks, > Priya > On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote: >> Two suggestions: >> >> * You may want to add a check to make sure that the control reached >> func.call method >> - there is an assert there but the test does not assert the control >> reached there >> >> * class name "func" be changed to "Func" or some such (capitalization >> of class names) >> >> -Sundar >> >> On 03/11/17, 11:36 AM, Priya Lakshmi Muthuswamy wrote: >>> Hi, >>> >>> Please review JDK-8186807: JSObject gets ScriptFunction when >>> ScriptObjectMirror is expected >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8186807 >>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/ >>> >>> Thanks, >>> Priya > From james.laskey at oracle.com Fri Nov 3 12:57:27 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 3 Nov 2017 09:57:27 -0300 Subject: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop In-Reply-To: <59FC3299.9080907@oracle.com> References: <59FC3299.9080907@oracle.com> Message-ID: <14D6F374-2651-4E50-BCE0-10ACAE2B1419@oracle.com> +1 Does jshell have similar dependencies? > On Nov 3, 2017, at 6:10 AM, Sundararajan Athijegannathan wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 > Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Fri Nov 3 13:10:46 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Fri, 03 Nov 2017 18:40:46 +0530 Subject: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop In-Reply-To: <14D6F374-2651-4E50-BCE0-10ACAE2B1419@oracle.com> References: <59FC3299.9080907@oracle.com> <14D6F374-2651-4E50-BCE0-10ACAE2B1419@oracle.com> Message-ID: <59FC6AD6.4060201@oracle.com> Thanks. Yes, jshell has similar dependencies for the UI part. i.e., no direct dependency on java.desktop from jdk.jshell module. -Sundar On 03/11/17, 6:27 PM, Jim Laskey (Oracle) wrote: > +1 > > Does jshell have similar dependencies? > >> On Nov 3, 2017, at 6:10 AM, Sundararajan Athijegannathan wrote: >> >> Please review. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 >> Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 >> >> Thanks, >> -Sundar From hannes.wallnoefer at oracle.com Fri Nov 3 13:58:21 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Fri, 3 Nov 2017 14:58:21 +0100 Subject: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected In-Reply-To: <59FC60B6.8020903@oracle.com> References: <6c39fee3-4847-98fb-f6d6-7c5d299c7f4d@oracle.com> <59FC39DC.2060601@oracle.com> <59FC60B6.8020903@oracle.com> Message-ID: <544BAC81-A260-4C9E-8287-4DD27CC76B32@oracle.com> +1 Hannes > Am 03.11.2017 um 13:27 schrieb Sundararajan Athijegannathan : > > +1 > > -Sundar > > On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote: >> Updated the webrev with modified testcase. >> >> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/ >> >> Thanks, >> Priya >> On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote: >>> Two suggestions: >>> >>> * You may want to add a check to make sure that the control reached func.call method >>> - there is an assert there but the test does not assert the control reached there >>> >>> * class name "func" be changed to "Func" or some such (capitalization of class names) >>> >>> -Sundar >>> >>> On 03/11/17, 11:36 AM, Priya Lakshmi Muthuswamy wrote: >>>> Hi, >>>> >>>> Please review JDK-8186807: JSObject gets ScriptFunction when ScriptObjectMirror is expected >>>> >>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8186807 >>>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/ >>>> >>>> Thanks, >>>> Priya >> From hannes.wallnoefer at oracle.com Fri Nov 3 14:14:36 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Fri, 3 Nov 2017 15:14:36 +0100 Subject: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop In-Reply-To: <59FC3299.9080907@oracle.com> References: <59FC3299.9080907@oracle.com> Message-ID: <52326214-0051-4E21-8501-EACE258B276B@oracle.com> +1 Hannes > Am 03.11.2017 um 10:10 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 > Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Mon Nov 6 14:37:27 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Mon, 06 Nov 2017 20:07:27 +0530 Subject: RFR 8190795: jjs should show javadoc for java methods on shift-tab Message-ID: <5A0073A7.3080907@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8190795 Webrev: http://cr.openjdk.java.net/~sundar/8190795/webrev.00/ Piggybacking refactoring of other functions implemented in script (browse, load etc.) so that we can avoid multi-line hard coded string in java sources. -Sundar From hannes.wallnoefer at oracle.com Mon Nov 6 15:36:18 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 6 Nov 2017 16:36:18 +0100 Subject: RFR 8190795: jjs should show javadoc for java methods on shift-tab In-Reply-To: <5A0073A7.3080907@oracle.com> References: <5A0073A7.3080907@oracle.com> Message-ID: Looks good! Hannes > Am 06.11.2017 um 15:37 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190795 > Webrev: http://cr.openjdk.java.net/~sundar/8190795/webrev.00/ > > Piggybacking refactoring of other functions implemented in script (browse, load etc.) so that we can avoid multi-line hard coded string in java sources. > > -Sundar From james.laskey at oracle.com Mon Nov 6 16:37:57 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 6 Nov 2017 12:37:57 -0400 Subject: RFR 8190795: jjs should show javadoc for java methods on shift-tab In-Reply-To: <5A0073A7.3080907@oracle.com> References: <5A0073A7.3080907@oracle.com> Message-ID: +1 > On Nov 6, 2017, at 10:37 AM, Sundararajan Athijegannathan wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190795 > Webrev: http://cr.openjdk.java.net/~sundar/8190795/webrev.00/ > > Piggybacking refactoring of other functions implemented in script (browse, load etc.) so that we can avoid multi-line hard coded string in java sources. > > -Sundar From hannes.wallnoefer at oracle.com Tue Nov 7 12:45:13 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 7 Nov 2017 13:45:13 +0100 Subject: RFR: 8190427 : Test for JDK-8165198 fails intermittently because of GC Message-ID: <2DC380CF-8FA9-4E88-86EA-99461C657B14@oracle.com> Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8190427 Webrev: http://cr.openjdk.java.net/~hannesw/8190427/webrev.02/ This started as simple bug fix but turned into a full refactoring of the code that manages property switch points. However, I do think it is actually the only reasonable way too fix this bug, with the side benefit that the code becomes simpler. The gist of this change is that PropertyMap no longer acts as property change listener of parent maps. Instead, the switch points are managed and invalidated directly in the PropertySwitchPoints class (renamed from PropertyListeners). Thus, we no longer depend on PropertyMaps being kept around, which was the root of the bug, and there?s one less level of indirection. I also replaced the property change callback methods in PropertyMap with a single propertyChanged method because it?s now the same code for all types of property change. I spent quite some time testing behaviour of the new code, and it?s actually as good or slightly better than the old one in terms of switch points created and invalidated. I?m a bit embarrassed I made this more complex than it had to be the first time around. Hannes From james.laskey at oracle.com Tue Nov 7 13:06:10 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 7 Nov 2017 09:06:10 -0400 Subject: RFR: 8190427 : Test for JDK-8165198 fails intermittently because of GC In-Reply-To: <2DC380CF-8FA9-4E88-86EA-99461C657B14@oracle.com> References: <2DC380CF-8FA9-4E88-86EA-99461C657B14@oracle.com> Message-ID: <7D6367BF-A056-4A14-89E3-411E39849922@oracle.com> +1 > On Nov 7, 2017, at 8:45 AM, Hannes Walln?fer wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190427 > Webrev: http://cr.openjdk.java.net/~hannesw/8190427/webrev.02/ > > This started as simple bug fix but turned into a full refactoring of the code that manages property switch points. However, I do think it is actually the only reasonable way too fix this bug, with the side benefit that the code becomes simpler. > > The gist of this change is that PropertyMap no longer acts as property change listener of parent maps. Instead, the switch points are managed and invalidated directly in the PropertySwitchPoints class (renamed from PropertyListeners). Thus, we no longer depend on PropertyMaps being kept around, which was the root of the bug, and there?s one less level of indirection. > > I also replaced the property change callback methods in PropertyMap with a single propertyChanged method because it?s now the same code for all types of property change. > > I spent quite some time testing behaviour of the new code, and it?s actually as good or slightly better than the old one in terms of switch points created and invalidated. I?m a bit embarrassed I made this more complex than it had to be the first time around. > > Hannes From sundararajan.athijegannathan at oracle.com Wed Nov 8 11:14:45 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Wed, 08 Nov 2017 16:44:45 +0530 Subject: RFR: 8190427 : Test for JDK-8165198 fails intermittently because of GC In-Reply-To: <2DC380CF-8FA9-4E88-86EA-99461C657B14@oracle.com> References: <2DC380CF-8FA9-4E88-86EA-99461C657B14@oracle.com> Message-ID: <5A02E725.7020906@oracle.com> +1 -Sundar On 07/11/17, 6:15 PM, Hannes Walln?fer wrote: > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190427 > Webrev: http://cr.openjdk.java.net/~hannesw/8190427/webrev.02/ > > This started as simple bug fix but turned into a full refactoring of the code that manages property switch points. However, I do think it is actually the only reasonable way too fix this bug, with the side benefit that the code becomes simpler. > > The gist of this change is that PropertyMap no longer acts as property change listener of parent maps. Instead, the switch points are managed and invalidated directly in the PropertySwitchPoints class (renamed from PropertyListeners). Thus, we no longer depend on PropertyMaps being kept around, which was the root of the bug, and there?s one less level of indirection. > > I also replaced the property change callback methods in PropertyMap with a single propertyChanged method because it?s now the same code for all types of property change. > > I spent quite some time testing behaviour of the new code, and it?s actually as good or slightly better than the old one in terms of switch points created and invalidated. I?m a bit embarrassed I made this more complex than it had to be the first time around. > > Hannes From priya.lakshmi.muthuswamy at oracle.com Mon Nov 13 06:21:45 2017 From: priya.lakshmi.muthuswamy at oracle.com (Priya Lakshmi Muthuswamy) Date: Mon, 13 Nov 2017 11:51:45 +0530 Subject: RFR:JDK-8190391:nashorn: "!!" of nonzero even integer var becomes false when returned Message-ID: <96995230-ba20-d281-9637-cff436df4313@oracle.com> Hi, Please review JDK-8190391 : nashorn: "!!" of nonzero even integer var becomes false when returned JBS : https://bugs.openjdk.java.net/browse/JDK-8190391 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8190391/webrev.00/ Thanks, Priya From szegedia at gmail.com Mon Nov 13 07:57:37 2017 From: szegedia at gmail.com (Attila Szegedi) Date: Mon, 13 Nov 2017 08:57:37 +0100 Subject: RFR:JDK-8190391:nashorn: "!!" of nonzero even integer var becomes false when returned In-Reply-To: <96995230-ba20-d281-9637-cff436df4313@oracle.com> References: <96995230-ba20-d281-9637-cff436df4313@oracle.com> Message-ID: +1. Nice catch. Feels like an implementation detail, but the JVM specification is indeed unclear on the behavior in case there's a bytecode method doing this: public static func(I)Z 0 iload 0 1 ireturn I went spelunking in the JVM spec, and the closest I could find is in section 2.3.4 says "The Java Virtual Machine encodes boolean array components using 1 to represent true and 0 to represent false. Where Java programming language boolean values are mapped by compilers to values of Java Virtual Machine type int, the compilers must use the same encoding." So I guess we better stick to that. Attila. On Mon, Nov 13, 2017 at 7:21 AM, Priya Lakshmi Muthuswamy < priya.lakshmi.muthuswamy at oracle.com> wrote: > Hi, > > Please review JDK-8190391 : nashorn: "!!" of nonzero even integer var > becomes false when returned > > JBS : https://bugs.openjdk.java.net/browse/JDK-8190391 > webrev : http://cr.openjdk.java.net/~pmuthuswamy/8190391/webrev.00/ > > Thanks, > Priya > From sundararajan.athijegannathan at oracle.com Mon Nov 13 08:12:21 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Mon, 13 Nov 2017 13:42:21 +0530 Subject: RFR:JDK-8190391:nashorn: "!!" of nonzero even integer var becomes false when returned In-Reply-To: References: <96995230-ba20-d281-9637-cff436df4313@oracle.com> Message-ID: <5A0953E5.6040905@oracle.com> +1 Yep. 0 and 1 are only allowed. -Sundar On 13/11/17, 1:27 PM, Attila Szegedi wrote: > +1. Nice catch. Feels like an implementation detail, but the JVM > specification is indeed unclear on the behavior in case there's a bytecode > method doing this: > > public static func(I)Z > 0 iload 0 > 1 ireturn > > > I went spelunking in the JVM spec, and the closest I could find is in > section 2.3.4 says "The Java Virtual Machine encodes boolean array > components using 1 to represent true and 0 to represent false. Where Java > programming language boolean values are mapped by compilers to values of > Java Virtual Machine type int, the compilers must use the same encoding." > So I guess we better stick to that. > > Attila. > > > On Mon, Nov 13, 2017 at 7:21 AM, Priya Lakshmi Muthuswamy< > priya.lakshmi.muthuswamy at oracle.com> wrote: > >> Hi, >> >> Please review JDK-8190391 : nashorn: "!!" of nonzero even integer var >> becomes false when returned >> >> JBS : https://bugs.openjdk.java.net/browse/JDK-8190391 >> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8190391/webrev.00/ >> >> Thanks, >> Priya >> From sundararajan.athijegannathan at oracle.com Mon Nov 13 08:27:51 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Mon, 13 Nov 2017 13:57:51 +0530 Subject: RFR:JDK-8190391:nashorn: "!!" of nonzero even integer var becomes false when returned In-Reply-To: <5A0953E5.6040905@oracle.com> References: <96995230-ba20-d281-9637-cff436df4313@oracle.com> <5A0953E5.6040905@oracle.com> Message-ID: <5A095787.9080805@oracle.com> Experimented with jasm (https://wiki.openjdk.java.net/display/CodeTools/asmtools): super public class HelloWorld version 50:0 { public Method "":"()V" stack 1 locals 1 { aload_0; invokespecial Method java/lang/Object."":"()V"; return; } public static Method func:"(I)Z" stack 1 locals 1 { iload 0; ireturn; } public static Method main:"([Ljava/lang/String;)V" stack 2 locals 1 { getstatic Field java/lang/System.out:"Ljava/io/PrintStream;"; bipush 0; invokestatic Method HelloWorld.func:"(I)Z"; invokevirtual Method java/io/PrintStream.println:"(Z)V"; getstatic Field java/lang/System.out:"Ljava/io/PrintStream;"; bipush 13; invokestatic Method HelloWorld.func:"(I)Z"; invokevirtual Method java/io/PrintStream.println:"(Z)V"; getstatic Field java/lang/System.out:"Ljava/io/PrintStream;"; bipush 22; invokestatic Method HelloWorld.func:"(I)Z"; invokevirtual Method java/io/PrintStream.println:"(Z)V"; return; } } // end Class HelloWorld prints false, true, false. -Sundar On 13/11/17, 1:42 PM, Sundararajan Athijegannathan wrote: > +1 > > Yep. 0 and 1 are only allowed. > > -Sundar > > On 13/11/17, 1:27 PM, Attila Szegedi wrote: >> +1. Nice catch. Feels like an implementation detail, but the JVM >> specification is indeed unclear on the behavior in case there's a >> bytecode >> method doing this: >> >> public static func(I)Z >> 0 iload 0 >> 1 ireturn >> >> >> I went spelunking in the JVM spec, and the closest I could find is in >> section 2.3.4 says "The Java Virtual Machine encodes boolean array >> components using 1 to represent true and 0 to represent false. Where >> Java >> programming language boolean values are mapped by compilers to values of >> Java Virtual Machine type int, the compilers must use the same >> encoding." >> So I guess we better stick to that. >> >> Attila. >> >> >> On Mon, Nov 13, 2017 at 7:21 AM, Priya Lakshmi Muthuswamy< >> priya.lakshmi.muthuswamy at oracle.com> wrote: >> >>> Hi, >>> >>> Please review JDK-8190391 : nashorn: "!!" of nonzero even integer var >>> becomes false when returned >>> >>> JBS : https://bugs.openjdk.java.net/browse/JDK-8190391 >>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8190391/webrev.00/ >>> >>> Thanks, >>> Priya >>> From hannes.wallnoefer at oracle.com Mon Nov 13 16:49:42 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 13 Nov 2017 17:49:42 +0100 Subject: RFR: 8191131: Nashorn test comparator breaks comparator contract Message-ID: <722C5A32-621E-4DDA-B7C5-4AB928B383E3@oracle.com> Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191131 Webrev: http://cr.openjdk.java.net/~hannesw/8191131/webrev/ Thanks, Hannes From sundararajan.athijegannathan at oracle.com Mon Nov 13 17:01:10 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Mon, 13 Nov 2017 22:31:10 +0530 Subject: RFR: 8191131: Nashorn test comparator breaks comparator contract In-Reply-To: <722C5A32-621E-4DDA-B7C5-4AB928B383E3@oracle.com> References: <722C5A32-621E-4DDA-B7C5-4AB928B383E3@oracle.com> Message-ID: <5A09CFD6.4000008@oracle.com> +1 PS. Wonder why this was not caught earlier... -Sundar On 13/11/17, 10:19 PM, Hannes Walln?fer wrote: > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191131 > Webrev: http://cr.openjdk.java.net/~hannesw/8191131/webrev/ > > Thanks, > Hannes From james.laskey at oracle.com Mon Nov 13 16:54:21 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 13 Nov 2017 12:54:21 -0400 Subject: RFR: 8191131: Nashorn test comparator breaks comparator contract In-Reply-To: <722C5A32-621E-4DDA-B7C5-4AB928B383E3@oracle.com> References: <722C5A32-621E-4DDA-B7C5-4AB928B383E3@oracle.com> Message-ID: <2C099EC2-5774-45FA-98B1-A56245E9DA57@oracle.com> +1 > On Nov 13, 2017, at 12:49 PM, Hannes Walln?fer wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191131 > Webrev: http://cr.openjdk.java.net/~hannesw/8191131/webrev/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Mon Nov 13 17:25:01 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 13 Nov 2017 18:25:01 +0100 Subject: RFR: 8185119: Uninitialized const when using multiple threads Message-ID: <15135181-051E-4382-9068-A4E99F3E0B82@oracle.com> Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8185119 Webrev: http://cr.openjdk.java.net/~hannesw/8185119/webrev/ Thanks, Hannes From james.laskey at oracle.com Mon Nov 13 17:32:32 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Mon, 13 Nov 2017 13:32:32 -0400 Subject: RFR: 8185119: Uninitialized const when using multiple threads In-Reply-To: <15135181-051E-4382-9068-A4E99F3E0B82@oracle.com> References: <15135181-051E-4382-9068-A4E99F3E0B82@oracle.com> Message-ID: +1 > On Nov 13, 2017, at 1:25 PM, Hannes Walln?fer wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8185119 > Webrev: http://cr.openjdk.java.net/~hannesw/8185119/webrev/ > > Thanks, > Hannes From sundararajan.athijegannathan at oracle.com Tue Nov 14 02:52:12 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Tue, 14 Nov 2017 08:22:12 +0530 Subject: RFR: 8185119: Uninitialized const when using multiple threads In-Reply-To: <15135181-051E-4382-9068-A4E99F3E0B82@oracle.com> References: <15135181-051E-4382-9068-A4E99F3E0B82@oracle.com> Message-ID: <5A0A5A5C.7050706@oracle.com> +1 -Sundar On 13/11/17, 10:55 PM, Hannes Walln?fer wrote: > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8185119 > Webrev: http://cr.openjdk.java.net/~hannesw/8185119/webrev/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Tue Nov 14 09:28:10 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 14 Nov 2017 10:28:10 +0100 Subject: RFR: 8191133: Ant task to fetch underscore.js requires gzip decoding option Message-ID: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191133 Webrev: http://cr.openjdk.java.net/~hannesw/8191133/webrev/ Thanks, Hannes From sundararajan.athijegannathan at oracle.com Tue Nov 14 09:39:20 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Tue, 14 Nov 2017 15:09:20 +0530 Subject: RFR: 8191133: Ant task to fetch underscore.js requires gzip decoding option In-Reply-To: References: Message-ID: <5A0AB9C8.4050308@oracle.com> +1 -Sundar On 14/11/17, 2:58 PM, Hannes Walln?fer wrote: > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191133 > Webrev: http://cr.openjdk.java.net/~hannesw/8191133/webrev/ > > Thanks, > Hannes From james.laskey at oracle.com Tue Nov 14 13:00:31 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 14 Nov 2017 09:00:31 -0400 Subject: RFR: 8191133: Ant task to fetch underscore.js requires gzip decoding option In-Reply-To: References: Message-ID: <5044A29E-0FDA-4FE1-8AB2-9D08772EC620@oracle.com> +1 > On Nov 14, 2017, at 5:28 AM, Hannes Walln?fer wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191133 > Webrev: http://cr.openjdk.java.net/~hannesw/8191133/webrev/ > > Thanks, > Hannes From sundararajan.athijegannathan at oracle.com Wed Nov 15 13:22:10 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Wed, 15 Nov 2017 18:52:10 +0530 Subject: RFR 8191306: Math.abs corner case with optimistic typing Message-ID: <5A0C3F82.8060004@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191306 Webrev: http://cr.openjdk.java.net/~sundar/8191306/webrev.00/index.html Thanks -Sundar From james.laskey at oracle.com Wed Nov 15 14:10:21 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 15 Nov 2017 10:10:21 -0400 Subject: RFR 8191306: Math.abs corner case with optimistic typing In-Reply-To: <5A0C3F82.8060004@oracle.com> References: <5A0C3F82.8060004@oracle.com> Message-ID: <825844E1-1FF4-4DFF-8B12-E19CA26D29F8@oracle.com> +1 > On Nov 15, 2017, at 9:22 AM, Sundararajan Athijegannathan wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191306 > Webrev: http://cr.openjdk.java.net/~sundar/8191306/webrev.00/index.html > > Thanks > -Sundar From hannes.wallnoefer at oracle.com Wed Nov 15 14:12:31 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Wed, 15 Nov 2017 15:12:31 +0100 Subject: RFR 8191306: Math.abs corner case with optimistic typing In-Reply-To: <5A0C3F82.8060004@oracle.com> References: <5A0C3F82.8060004@oracle.com> Message-ID: <9B5705E9-996F-496C-9F6C-6556AF1FC0C2@oracle.com> +1 Hannes > Am 15.11.2017 um 14:22 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191306 > Webrev: http://cr.openjdk.java.net/~sundar/8191306/webrev.00/index.html > > Thanks > -Sundar From sundararajan.athijegannathan at oracle.com Wed Nov 15 17:05:33 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Wed, 15 Nov 2017 22:35:33 +0530 Subject: RFR 8068741: javax.script.ScriptEngineFactory.getMethodCallSyntax() spec allows null passed as an object Message-ID: <5A0C73DD.3060608@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8068741 Webrev: http://cr.openjdk.java.net/~sundar/8068741/webrev.00/index.html Thanks, -Sundar From hannes.wallnoefer at oracle.com Wed Nov 15 17:11:28 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Wed, 15 Nov 2017 18:11:28 +0100 Subject: RFR 8068741: javax.script.ScriptEngineFactory.getMethodCallSyntax() spec allows null passed as an object In-Reply-To: <5A0C73DD.3060608@oracle.com> References: <5A0C73DD.3060608@oracle.com> Message-ID: +1 Hannes > Am 15.11.2017 um 18:05 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8068741 > Webrev: http://cr.openjdk.java.net/~sundar/8068741/webrev.00/index.html > > Thanks, > -Sundar From james.laskey at oracle.com Wed Nov 15 20:20:58 2017 From: james.laskey at oracle.com (James Laskey) Date: Wed, 15 Nov 2017 16:20:58 -0400 Subject: RFR 8068741: javax.script.ScriptEngineFactory.getMethodCallSyntax() spec allows null passed as an object In-Reply-To: <5A0C73DD.3060608@oracle.com> References: <5A0C73DD.3060608@oracle.com> Message-ID: <7CD9275E-08F0-4E56-9E12-A8B5BF2E2063@oracle.com> +1 Sent from my iPhone > On Nov 15, 2017, at 1:05 PM, Sundararajan Athijegannathan wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8068741 > Webrev: http://cr.openjdk.java.net/~sundar/8068741/webrev.00/index.html > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Fri Nov 17 06:30:53 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Fri, 17 Nov 2017 12:00:53 +0530 Subject: RFR 8191468: jdk.scripting.nashorn.shell (jjs) module should use optional dependency for java.compiler module Message-ID: <5A0E821D.6080805@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191468 Webrev: http://cr.openjdk.java.net/~sundar/8191468/webrev.00/index.html Thanks, -Sundar From hannes.wallnoefer at oracle.com Fri Nov 17 09:16:16 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Fri, 17 Nov 2017 10:16:16 +0100 Subject: RFR 8191468: jdk.scripting.nashorn.shell (jjs) module should use optional dependency for java.compiler module In-Reply-To: <5A0E821D.6080805@oracle.com> References: <5A0E821D.6080805@oracle.com> Message-ID: <91BE8DC0-13DA-4A8B-A3B0-7373607B266A@oracle.com> Looks good! Hannes > Am 17.11.2017 um 07:30 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191468 > Webrev: http://cr.openjdk.java.net/~sundar/8191468/webrev.00/index.html > > Thanks, > -Sundar From james.laskey at oracle.com Fri Nov 17 13:02:47 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Fri, 17 Nov 2017 09:02:47 -0400 Subject: RFR 8191468: jdk.scripting.nashorn.shell (jjs) module should use optional dependency for java.compiler module In-Reply-To: <91BE8DC0-13DA-4A8B-A3B0-7373607B266A@oracle.com> References: <5A0E821D.6080805@oracle.com> <91BE8DC0-13DA-4A8B-A3B0-7373607B266A@oracle.com> Message-ID: <6CFEDF99-433B-466E-8DF5-F146CD0D959E@oracle.com> +1 > On Nov 17, 2017, at 5:16 AM, Hannes Walln?fer wrote: > > Looks good! > > Hannes > >> Am 17.11.2017 um 07:30 schrieb Sundararajan Athijegannathan : >> >> Please review. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8191468 >> Webrev: http://cr.openjdk.java.net/~sundar/8191468/webrev.00/index.html >> >> Thanks, >> -Sundar > From sundararajan.athijegannathan at oracle.com Wed Nov 22 16:43:57 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Wed, 22 Nov 2017 22:13:57 +0530 Subject: RFR 8191771: nashorn ant makefile uses javadoc -link which may fail Message-ID: <5A15A94D.8010303@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191771 Webrev: http://cr.openjdk.java.net/~sundar/8191771/webrev.00/ Thanks, -Sundar From james.laskey at oracle.com Wed Nov 22 16:45:12 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 22 Nov 2017 12:45:12 -0400 Subject: RFR 8191771: nashorn ant makefile uses javadoc -link which may fail In-Reply-To: <5A15A94D.8010303@oracle.com> References: <5A15A94D.8010303@oracle.com> Message-ID: <93473F07-B147-45D8-A5C9-B24B2A3BB913@oracle.com> +1 > On Nov 22, 2017, at 12:43 PM, Sundararajan Athijegannathan wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191771 > Webrev: http://cr.openjdk.java.net/~sundar/8191771/webrev.00/ > > Thanks, > -Sundar From hannes.wallnoefer at oracle.com Wed Nov 22 17:40:19 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Wed, 22 Nov 2017 18:40:19 +0100 Subject: RFR 8191771: nashorn ant makefile uses javadoc -link which may fail In-Reply-To: <5A15A94D.8010303@oracle.com> References: <5A15A94D.8010303@oracle.com> Message-ID: +1 Hannes > Am 22.11.2017 um 17:43 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191771 > Webrev: http://cr.openjdk.java.net/~sundar/8191771/webrev.00/ > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Thu Nov 23 08:52:30 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Thu, 23 Nov 2017 14:22:30 +0530 Subject: RFR 8191810: jjs should avoid hard coded javadoc base url for shift-tab documentation feature Message-ID: <5A168C4E.9040307@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8191810 Webrev: http://cr.openjdk.java.net/~sundar/8191810/webrev.00/ Thanks, -Sundar From hannes.wallnoefer at oracle.com Thu Nov 23 09:10:58 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Thu, 23 Nov 2017 10:10:58 +0100 Subject: RFR 8191810: jjs should avoid hard coded javadoc base url for shift-tab documentation feature In-Reply-To: <5A168C4E.9040307@oracle.com> References: <5A168C4E.9040307@oracle.com> Message-ID: <69EE2088-92B8-4C63-8530-4E34FA6B0A80@oracle.com> +1 Hannes > Am 23.11.2017 um 09:52 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191810 > Webrev: http://cr.openjdk.java.net/~sundar/8191810/webrev.00/ > > Thanks, > -Sundar From hannes.wallnoefer at oracle.com Thu Nov 23 13:18:55 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Thu, 23 Nov 2017 14:18:55 +0100 Subject: RFR: 8191819: String.prototype.match should follow ES6 specification Message-ID: Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191819 Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/ Thanks, Hannes From hannes.wallnoefer at oracle.com Thu Nov 23 14:42:21 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Thu, 23 Nov 2017 15:42:21 +0100 Subject: RFR: 8191819: String.prototype.match should follow ES6 specification In-Reply-To: References: Message-ID: <08D03650-2B39-49C7-A563-971187FC6BAC@oracle.com> Sorry, the test in the first webrev uses replace() instead of match(), which already works as expected. New webrev with correct test is here: http://cr.openjdk.java.net/~hannesw/8191819/webrev.01/ Hannes > Am 23.11.2017 um 14:18 schrieb Hannes Walln?fer : > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191819 > Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/ > > Thanks, > Hannes From sundararajan.athijegannathan at oracle.com Thu Nov 23 15:07:25 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Thu, 23 Nov 2017 20:37:25 +0530 Subject: RFR: 8191819: String.prototype.match should follow ES6 specification In-Reply-To: <08D03650-2B39-49C7-A563-971187FC6BAC@oracle.com> References: <08D03650-2B39-49C7-A563-971187FC6BAC@oracle.com> Message-ID: <5A16E42D.5080406@oracle.com> +1 -Sundar On 23/11/17, 8:12 PM, Hannes Walln?fer wrote: > Sorry, the test in the first webrev uses replace() instead of match(), which already works as expected. > > New webrev with correct test is here: http://cr.openjdk.java.net/~hannesw/8191819/webrev.01/ > > Hannes > > >> Am 23.11.2017 um 14:18 schrieb Hannes Walln?fer: >> >> Please review: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8191819 >> Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/ >> >> Thanks, >> Hannes From szegedia at gmail.com Sun Nov 26 18:51:49 2017 From: szegedia at gmail.com (Attila Szegedi) Date: Sun, 26 Nov 2017 19:51:49 +0100 Subject: Review request for JDK-8191878: Reduce code duplication in BeanLinker Message-ID: Hey folks, I?m able to spend some free time again on OpenJDK development, and one thing I have on my plate is adding a REMOVE operation to Dynalink. This CR however, is not yet it: that will require a CCC sponsorship etc. as I?ll be adding a new enum value to StandardOperations, and I will follow up separately once I?m done with it. What this is a refactoring of BeanLinker code to eliminate most of the code duplication between getElementGetter and getElementSetter methods. This would be justified on its own, but once I need to add the getElementRemover method, it will really pay off as then we won?t have triplication of similar code. With that in mind, please review JDK-8191878 "Reduce code duplication in BeanLinker" at for Thanks, Attila. From sundararajan.athijegannathan at oracle.com Mon Nov 27 10:24:44 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Mon, 27 Nov 2017 15:54:44 +0530 Subject: RFR 8135178: importPackage not working even with load "Mozilla compatibility script" Message-ID: <5A1BE7EC.6090905@oracle.com> Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8135178 Webrev: http://cr.openjdk.java.net/~sundar/8135178/webrev.00/ Thanks, -Sundar From hannes.wallnoefer at oracle.com Mon Nov 27 11:22:49 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 27 Nov 2017 12:22:49 +0100 Subject: RFR 8135178: importPackage not working even with load "Mozilla compatibility script" In-Reply-To: <5A1BE7EC.6090905@oracle.com> References: <5A1BE7EC.6090905@oracle.com> Message-ID: <75B8B5CC-EBC7-4424-BA09-C944AE90B1B4@oracle.com> +1 Hannes > Am 27.11.2017 um 11:24 schrieb Sundararajan Athijegannathan : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8135178 > Webrev: http://cr.openjdk.java.net/~sundar/8135178/webrev.00/ > > Thanks, > -Sundar From hannes.wallnoefer at oracle.com Mon Nov 27 14:42:12 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 27 Nov 2017 15:42:12 +0100 Subject: Review request for JDK-8191878: Reduce code duplication in BeanLinker In-Reply-To: References: Message-ID: <19EE9F8C-4B70-4257-B7AF-1417B2F0CB23@oracle.com> Hi Attila, > Am 26.11.2017 um 19:51 schrieb Attila Szegedi : > > I?m able to spend some free time again on OpenJDK development, and one thing I have on my plate is adding a REMOVE operation to Dynalink. > great! > This CR however, is not yet it: that will require a CCC sponsorship etc. as I?ll be adding a new enum value to StandardOperations, and I will follow up separately once I?m done with it. I was going to point you to the new CSR issue type, but I see you found your way already. > What this is a refactoring of BeanLinker code to eliminate most of the code duplication between getElementGetter and getElementSetter methods. This would be justified on its own, but once I need to add the getElementRemover method, it will really pay off as then we won?t have triplication of similar code. > > With that in mind, please review JDK-8191878 "Reduce code duplication in BeanLinker" at for > +1 Hannes > Thanks, > Attila. > From sundararajan.athijegannathan at oracle.com Mon Nov 27 15:20:08 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Mon, 27 Nov 2017 20:50:08 +0530 Subject: Review request for JDK-8191878: Reduce code duplication in BeanLinker In-Reply-To: References: Message-ID: <5A1C2D28.3040108@oracle.com> Looks good -Sundar On 27/11/17, 12:21 AM, Attila Szegedi wrote: > Hey folks, > > I?m able to spend some free time again on OpenJDK development, and one thing I have on my plate is adding a REMOVE operation to Dynalink. > > This CR however, is not yet it: that will require a CCC sponsorship etc. as I?ll be adding a new enum value to StandardOperations, and I will follow up separately once I?m done with it. > > What this is a refactoring of BeanLinker code to eliminate most of the code duplication between getElementGetter and getElementSetter methods. This would be justified on its own, but once I need to add the getElementRemover method, it will really pay off as then we won?t have triplication of similar code. > > With that in mind, please review JDK-8191878 "Reduce code duplication in BeanLinker" at for > > Thanks, > Attila. > From hannes.wallnoefer at oracle.com Tue Nov 28 14:03:58 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 28 Nov 2017 15:03:58 +0100 Subject: RFR: 8059835: Optimistic splitting doesn't work with let and const Message-ID: <0A7CE1E4-3C0D-434B-82CA-DB004E88641B@oracle.com> Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8059835 Webrev: http://cr.openjdk.java.net/~hannesw/8059835/webrev.00/ Thanks, Hannes From james.laskey at oracle.com Tue Nov 28 14:20:57 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 28 Nov 2017 10:20:57 -0400 Subject: RFR: 8059835: Optimistic splitting doesn't work with let and const In-Reply-To: <0A7CE1E4-3C0D-434B-82CA-DB004E88641B@oracle.com> References: <0A7CE1E4-3C0D-434B-82CA-DB004E88641B@oracle.com> Message-ID: <1D13E5A6-6EA0-4771-AC8C-53BF14BD03E0@oracle.com> +1 > On Nov 28, 2017, at 10:03 AM, Hannes Walln?fer wrote: > From hannes.wallnoefer at oracle.com Tue Nov 28 14:26:51 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 28 Nov 2017 15:26:51 +0100 Subject: RFR: 8191891: Update minumum Ant version in Nashorn build.xml Message-ID: <98A7799C-124A-47A6-9CE8-1D708C9EF9B0@oracle.com> Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ Thanks, Hannes From szegedia at gmail.com Tue Nov 28 14:29:14 2017 From: szegedia at gmail.com (Attila Szegedi) Date: Tue, 28 Nov 2017 15:29:14 +0100 Subject: RFR: 8059835: Optimistic splitting doesn't work with let and const In-Reply-To: <0A7CE1E4-3C0D-434B-82CA-DB004E88641B@oracle.com> References: <0A7CE1E4-3C0D-434B-82CA-DB004E88641B@oracle.com> Message-ID: <6BA1B856-4367-47F1-ACBE-EF0A25D1356A@gmail.com> +1 > On Nov 28, 2017, at 3:03 PM, Hannes Walln?fer wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059835 > Webrev: http://cr.openjdk.java.net/~hannesw/8059835/webrev.00/ > > Thanks, > Hannes From james.laskey at oracle.com Tue Nov 28 14:29:51 2017 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 28 Nov 2017 10:29:51 -0400 Subject: RFR: 8191891: Update minumum Ant version in Nashorn build.xml In-Reply-To: <98A7799C-124A-47A6-9CE8-1D708C9EF9B0@oracle.com> References: <98A7799C-124A-47A6-9CE8-1D708C9EF9B0@oracle.com> Message-ID: <926DF662-5645-4226-87AA-25E7B5CF3144@oracle.com> +1 > On Nov 28, 2017, at 10:26 AM, Hannes Walln?fer wrote: > > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 > Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ > > Thanks, > Hannes From sundararajan.athijegannathan at oracle.com Tue Nov 28 14:59:53 2017 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Tue, 28 Nov 2017 20:29:53 +0530 Subject: RFR: 8191891: Update minumum Ant version in Nashorn build.xml In-Reply-To: <98A7799C-124A-47A6-9CE8-1D708C9EF9B0@oracle.com> References: <98A7799C-124A-47A6-9CE8-1D708C9EF9B0@oracle.com> Message-ID: <5A1D79E9.500@oracle.com> +1 PS. Is there a doc where we documented this? -Sundar On 28/11/17, 7:56 PM, Hannes Walln?fer wrote: > Please review: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 > Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Tue Nov 28 14:54:06 2017 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 28 Nov 2017 15:54:06 +0100 Subject: RFR: 8191891: Update minumum Ant version in Nashorn build.xml In-Reply-To: <5A1D79E9.500@oracle.com> References: <98A7799C-124A-47A6-9CE8-1D708C9EF9B0@oracle.com> <5A1D79E9.500@oracle.com> Message-ID: <5E17B69B-BD86-45C6-9AF7-440279E7C440@oracle.com> Thanks. > Am 28.11.2017 um 15:59 schrieb Sundararajan Athijegannathan : > > PS. Is there a doc where we documented this? I don?t think there is. I have grepped for ?Ant? and the version number in docs/nashorn and didn?t find anything. Hannes > > -Sundar > > On 28/11/17, 7:56 PM, Hannes Walln?fer wrote: >> Please review: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 >> Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ >> >> Thanks, >> Hannes