RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected
Hannes Wallnöfer
hannes.wallnoefer at oracle.com
Fri Nov 3 13:58:21 UTC 2017
+1
Hannes
> Am 03.11.2017 um 13:27 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
>
> +1
>
> -Sundar
>
> On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote:
>> Updated the webrev with modified testcase.
>>
>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.01/
>>
>> Thanks,
>> Priya
>> On 11/3/2017 3:11 PM, Sundararajan Athijegannathan wrote:
>>> Two suggestions:
>>>
>>> * You may want to add a check to make sure that the control reached func.call method
>>> - there is an assert there but the test does not assert the control reached there
>>>
>>> * class name "func" be changed to "Func" or some such (capitalization of class names)
>>>
>>> -Sundar
>>>
>>> On 03/11/17, 11:36 AM, Priya Lakshmi Muthuswamy wrote:
>>>> Hi,
>>>>
>>>> Please review JDK-8186807: JSObject gets ScriptFunction when ScriptObjectMirror is expected
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8186807
>>>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8186807/webrev.00/
>>>>
>>>> Thanks,
>>>> Priya
>>
More information about the nashorn-dev
mailing list