RFR: JDK-8203827: Upgrade JLine to 2.14.6
Alan Bateman
Alan.Bateman at oracle.com
Tue May 29 12:51:31 UTC 2018
On 25/05/2018 21:20, Jan Lahoda wrote:
> Hi,
>
> I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to
> 2.14.6.
>
> The complete webrev is here:
> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
>
> To simplify reviewing, there is:
> -an antipatch that removes the JDK-specific changes and restores the
> vanilla 2.12.1 content:
> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/undo-jdk-extras/
> -a patch that replaces the 2.12.1 content with 2.14.6:
> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/upgrade-jline/
> -a patch that re-applies the JDK-specific changes (like including
> adjusting packages, and removal/commenting out of usage of features
> that would require undesirable dependencies, and any changes that had
> to be done to other modules):
> http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/adding-jdk-extras/
>
> JBS entry: https://bugs.openjdk.java.net/browse/JDK-8203827
>
> How does this look?
The refresh looks okay and I see the package name has been adjusted for
the new files.
Is there an update to src/jdk.internal.le/share/legal/jlink.md?
Minimally I would assume the version at the top of the file needs to be
updated.
-Alan
More information about the nashorn-dev
mailing list