Nashorn on the module-path

[Christian Stein]

Hi Hannes,

what you see is the expected output. Those assumptions are meant
to fail ... perhaps a not so intuitive form of printing the test module
name to console.

The interesting lines are printed prior to the test run tree:

Running the tests on the `--module-path` yields:

>>
org.junit.jupiter.engine.script.ScriptAccessor$SystemPropertyAccessor at 4716be8b
undefined
<<


Compare to what is printed when running on  the `--class-path`:

>>
org.junit.jupiter.engine.script.ScriptAccessor$SystemPropertyAccessor at 275bf9b3
[jdk.dynalink.beans.SimpleDynamicMethod String
org.junit.jupiter.engine.script.ScriptAccessor.SystemPropertyAccessor.get(String)]
<<

The "undefined" type is what makes/breaks the script.

That said, I'll try to destill it down two or three files... later this
week.

Cheers,
Christian



On Mon, May 27, 2019 at 3:30 PM Hannes Wallnöfer <
hannes.wallnoefer at oracle.com> wrote:

> Hi Christian,
>
> I cloned and tried your example project. When I run the project, I get one
> successful and one aborted tests in both cases:
>
> Module path output:
>
> └─ JUnit Jupiter ✔
>    └─ CheckTests ✔
>       ├─ test() ✔
>       └─ emitStringRepresentationOfTestModule() ■ Assumption failed:
> module check
>
> Class path output:
>
> └─ JUnit Jupiter ✔
>    └─ CheckTests ✔
>       ├─ test() ✔
>       └─ emitStringRepresentationOfTestModule() ■ Assumption failed:
> unnamed module @306f16f3
>
>
> Unfortunately it’s quite hard for me to understand what’s going on from
> there. Your Main class is quite complex with over 800 lines of code, and it
> seems like the interesting code is in junit-jupiter, which is included in
> binary form only.
>
> Do you think it’s possible to reduce the problem further, ideally to a
> plain java class?
>
>
> Hannes
>
>
> > Am 27.05.2019 um 11:40 schrieb Christian Stein <sormuras at gmail.com>:
> >
> > On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan <
> > sundararajan.athijegannathan at oracle.com> wrote:
> >
> >> How can this be reproduced at out end?
> >
> >
> > I compiled a small example project at [1] that describes and
> > demonstrates the issue. Please view the README.md file for
> > details.
> >
> > You may reproduce the issue by launching `jshell build.jsh`
> > within the root directory of the project -- having JDK 11+ installed.
> >
> > [1] https://github.com/sormuras/junit5-class-vs-module-path
>
>