From hannes.wallnoefer at oracle.com Mon Sep 9 14:38:50 2019 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 9 Sep 2019 16:38:50 +0200 Subject: RFR: 8230709: Array index out of bounds in ES6 mode Message-ID: Please review this off-by-one array index fix that was recently reported on this list: JBS: https://bugs.openjdk.java.net/browse/JDK-8230709 Webrev: http://cr.openjdk.java.net/~hannesw/8230709/webrev.00/ Thanks, Hannes From hannes.wallnoefer at oracle.com Mon Sep 9 14:41:25 2019 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Mon, 9 Sep 2019 16:41:25 +0200 Subject: RFR: 8230766: Changed message in IllegalMonitorStateException Message-ID: <054D6FFB-2F01-4777-98F4-CFDC9488AB2E@oracle.com> Please review this fix for a test failing because of a changed exception message in java.lang.Object.wait(): JBS: https://bugs.openjdk.java.net/browse/JDK-8230766 Webrev: http://cr.openjdk.java.net/~hannesw/8230766/webrev.00/ Thanks, Hannes From szegedia at gmail.com Mon Sep 9 14:46:59 2019 From: szegedia at gmail.com (Attila Szegedi) Date: Mon, 9 Sep 2019 16:46:59 +0200 Subject: RFR: 8230766: Changed message in IllegalMonitorStateException In-Reply-To: <054D6FFB-2F01-4777-98F4-CFDC9488AB2E@oracle.com> References: <054D6FFB-2F01-4777-98F4-CFDC9488AB2E@oracle.com> Message-ID: +1 > On 2019. Sep 9., at 16:41, Hannes Walln?fer wrote: > > Please review this fix for a test failing because of a changed exception message in java.lang.Object.wait(): > > JBS: https://bugs.openjdk.java.net/browse/JDK-8230766 > Webrev: http://cr.openjdk.java.net/~hannesw/8230766/webrev.00/ > > Thanks, > Hannes From szegedia at gmail.com Mon Sep 9 14:50:56 2019 From: szegedia at gmail.com (Attila Szegedi) Date: Mon, 9 Sep 2019 16:50:56 +0200 Subject: RFR: 8230709: Array index out of bounds in ES6 mode In-Reply-To: References: Message-ID: <36FA1882-F829-4D31-9989-BC98B1058657@gmail.com> +1. Ugh. I guess our default lexical context stack is 16 deep. > On 2019. Sep 9., at 16:38, Hannes Walln?fer wrote: > > Please review this off-by-one array index fix that was recently reported on this list: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8230709 > Webrev: http://cr.openjdk.java.net/~hannesw/8230709/webrev.00/ > > Thanks, > Hannes From james.laskey at oracle.com Mon Sep 9 15:05:45 2019 From: james.laskey at oracle.com (Jim Laskey) Date: Mon, 9 Sep 2019 12:05:45 -0300 Subject: RFR: 8230766: Changed message in IllegalMonitorStateException In-Reply-To: <054D6FFB-2F01-4777-98F4-CFDC9488AB2E@oracle.com> References: <054D6FFB-2F01-4777-98F4-CFDC9488AB2E@oracle.com> Message-ID: <5728DC12-70A6-44D4-B2A1-4825197188F0@oracle.com> +1 > On Sep 9, 2019, at 11:41 AM, Hannes Walln?fer wrote: > > Please review this fix for a test failing because of a changed exception message in java.lang.Object.wait(): > > JBS: https://bugs.openjdk.java.net/browse/JDK-8230766 > Webrev: http://cr.openjdk.java.net/~hannesw/8230766/webrev.00/ > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Tue Sep 10 13:33:14 2019 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 10 Sep 2019 15:33:14 +0200 Subject: RFR: 8230709: Array index out of bounds in ES6 mode In-Reply-To: <36FA1882-F829-4D31-9989-BC98B1058657@gmail.com> References: <36FA1882-F829-4D31-9989-BC98B1058657@gmail.com> Message-ID: <4E1C6109-4539-4AE0-817C-E616077DD113@oracle.com> Am 09.09.2019 um 16:50 schrieb Attila Szegedi : > > +1. Ugh. I guess our default lexical context stack is 16 deep. > It is indeed :) Thanks for reviewing. Hannes >> On 2019. Sep 9., at 16:38, Hannes Walln?fer wrote: >> >> Please review this off-by-one array index fix that was recently reported on this list: >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8230709 >> Webrev: http://cr.openjdk.java.net/~hannesw/8230709/webrev.00/ >> >> Thanks, >> Hannes > From eric.vergnaud at wanadoo.fr Sat Sep 14 09:29:15 2019 From: eric.vergnaud at wanadoo.fr (Eric Vergnaud) Date: Sat, 14 Sep 2019 17:29:15 +0800 Subject: Nashorn future Message-ID: Hi everybody. I?m sure this has been discussed over and over, so please accept my apologies if I?m just creating noise. I joined the OpenJDK effort to help provide a workaround to Nashorn being marked as deprecated. From what I have been able to read on the web, the main rationales would be: - not enough resources to maintain it, the JS world is evolving too rapidly - users can switch to GraalVM I have to admit that I?m rather skeptical re adoption of GraalVM in large companies. I was wondering if some options had been considered: - move Nashorn out of the OpenJDK, such that more contributors can help, thanks to a more lightweight governance - incorporate the V8 engine, such that speed and language features stop being a problem - incorporate compatibility transpilers (like Babel) which is the technique used by the entire JS world to deal with cross-browser compatibility Any thoughts? n.b. as a side question, is there a web page where OpenJDK discussions content can be explored? From joe.darcy at oracle.com Thu Sep 26 22:45:05 2019 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 26 Sep 2019 15:45:05 -0700 Subject: JDK 14 RFR of JDK-8231557: Suppress warnings on non-serializable instance fields in jdk.scripting.nashorn module Message-ID: <3ead1b57-a638-8b81-2cb9-b599a16cecbe@oracle.com> Hello, Another part of an on-going cleanup of library serialization usage ahead of augmented javac -Xlint warnings (JDK-8160675), the non-serializable instance fields of serializable types in the jdk.scripting.nashorn module should have their serial warnings suppressed. The analogous issue in core libs is JDK-8231202. Please review: ??? JDK-8231557: Suppress warnings on non-serializable instance fields in jdk.scripting.nashorn module ??? http://cr.openjdk.java.net/~darcy/8231557.0/ Patch below. I'll update copyright years before a push. Thanks, -Joe --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Property.java 2019-09-26 15:28:51.764610000 -0700 +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Property.java 2019-09-26 15:28:51.572514000 -0700 @@ -103,6 +103,7 @@ ???? public static final int IS_ACCESSOR_PROPERTY??? = 1 << 12; ???? /** Property key. */ +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Object key; ???? /** Property flags. */ --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java 2019-09-26 15:28:52.300877999 -0700 +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java 2019-09-26 15:28:52.108782000 -0700 @@ -118,11 +118,13 @@ ????? * Opaque object representing parser state at the end of the function. Used when reparsing outer function ????? * to help with skipping parsing inner functions. ????? */ +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Object endParserState; ???? /** Code installer used for all further recompilation/specialization of this ScriptFunction */ ???? private transient CodeInstaller installer; +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Map nestedFunctions; ???? /** Id to parent function if one exists */ @@ -135,8 +137,10 @@ ???? private transient DebugLogger log; +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Map externalScopeDepths; +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Set internalSymbols; ???? private static final int GET_SET_PREFIX_LENGTH = "*et ".length(); --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/SharedPropertyMap.java 2019-09-26 15:28:52.861157999 -0700 +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/SharedPropertyMap.java 2019-09-26 15:28:52.657056000 -0700 @@ -40,6 +40,7 @@ ? */ ?public final class SharedPropertyMap extends PropertyMap { +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private SwitchPoint switchPoint; ???? private static final long serialVersionUID = 2166297719721778876L; --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/StoredScript.java 2019-09-26 15:28:53.357406000 -0700 +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/StoredScript.java 2019-09-26 15:28:53.157306000 -0700 @@ -42,12 +42,15 @@ ???? private final String mainClassName; ???? /** Map of class names to class bytes. */ +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Map classBytes; ???? /** Constants array. */ +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Object[] constants; ???? /** Function initializers */ +??? @SuppressWarnings("serial") // Not statically typed as Serializable ???? private final Map initializers; ???? private static final long serialVersionUID = 2958227232195298340L; From james.laskey at oracle.com Fri Sep 27 11:31:11 2019 From: james.laskey at oracle.com (Jim Laskey) Date: Fri, 27 Sep 2019 08:31:11 -0300 Subject: JDK 14 RFR of JDK-8231557: Suppress warnings on non-serializable instance fields in jdk.scripting.nashorn module In-Reply-To: <3ead1b57-a638-8b81-2cb9-b599a16cecbe@oracle.com> References: <3ead1b57-a638-8b81-2cb9-b599a16cecbe@oracle.com> Message-ID: <5BF2DBDD-30B6-406B-8E13-6FB346C63B14@oracle.com> +1 > On Sep 26, 2019, at 7:45 PM, Joe Darcy wrote: > > Hello, > > Another part of an on-going cleanup of library serialization usage ahead of augmented javac -Xlint warnings (JDK-8160675), the non-serializable instance fields of serializable types in the jdk.scripting.nashorn module should have their serial warnings suppressed. The analogous issue in core libs is JDK-8231202. > > Please review: > > JDK-8231557: Suppress warnings on non-serializable instance fields in jdk.scripting.nashorn module > http://cr.openjdk.java.net/~darcy/8231557.0/ > > Patch below. I'll update copyright years before a push. > > Thanks, > > -Joe > > --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Property.java 2019-09-26 15:28:51.764610000 -0700 > +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Property.java 2019-09-26 15:28:51.572514000 -0700 > @@ -103,6 +103,7 @@ > public static final int IS_ACCESSOR_PROPERTY = 1 << 12; > > /** Property key. */ > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Object key; > > /** Property flags. */ > --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java 2019-09-26 15:28:52.300877999 -0700 > +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java 2019-09-26 15:28:52.108782000 -0700 > @@ -118,11 +118,13 @@ > * Opaque object representing parser state at the end of the function. Used when reparsing outer function > * to help with skipping parsing inner functions. > */ > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Object endParserState; > > /** Code installer used for all further recompilation/specialization of this ScriptFunction */ > private transient CodeInstaller installer; > > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Map nestedFunctions; > > /** Id to parent function if one exists */ > @@ -135,8 +137,10 @@ > > private transient DebugLogger log; > > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Map externalScopeDepths; > > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Set internalSymbols; > > private static final int GET_SET_PREFIX_LENGTH = "*et ".length(); > --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/SharedPropertyMap.java 2019-09-26 15:28:52.861157999 -0700 > +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/SharedPropertyMap.java 2019-09-26 15:28:52.657056000 -0700 > @@ -40,6 +40,7 @@ > */ > public final class SharedPropertyMap extends PropertyMap { > > + @SuppressWarnings("serial") // Not statically typed as Serializable > private SwitchPoint switchPoint; > > private static final long serialVersionUID = 2166297719721778876L; > --- old/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/StoredScript.java 2019-09-26 15:28:53.357406000 -0700 > +++ new/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/StoredScript.java 2019-09-26 15:28:53.157306000 -0700 > @@ -42,12 +42,15 @@ > private final String mainClassName; > > /** Map of class names to class bytes. */ > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Map classBytes; > > /** Constants array. */ > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Object[] constants; > > /** Function initializers */ > + @SuppressWarnings("serial") // Not statically typed as Serializable > private final Map initializers; > > private static final long serialVersionUID = 2958227232195298340L; >