Request for comments: Bug 6306820
Michael McMahon
Michael.McMahon at Sun.COM
Thu Jun 21 03:17:51 PDT 2007
The CCC request has received initial approval,
which simply means that the API change is accepted in principle.
But, we need to finalize the specification and submit it to the CCC
for final approval.
Due to the (large) amount of discussion that has already
taken place, I don't anticipate that this will take too long.
The following is a comment from the final CCC reviewer. The comments
are based on an older version of the API, but they are still
applicable to the current version.
- Michael
A couple of quick comments:
- The names of the elements of the URIQueryString.ParameterSeparator
enum should be in UPPER_CASE, per convention. (Actually, defining
an enum for this seems like overkill to me; I'd be tempted to accept
a string argument and throw an IllegalArgumentException for anything
except "&" and ";").
- Using string arrays in the URIQueryString API is just wrong; these
should be List<String>. (Mimicing the ServletRequest API is of
marginal value at best, and so not an argument for using String[].)
More information about the net-dev
mailing list