From bradford.wetmore at sun.com Sun Apr 6 10:22:45 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Sun, 06 Apr 2008 17:22:45 +0000 Subject: hg: jdk7/jsn/jdk: 6683078: Update JCE framework and provider builds to work on read-only filesystems; ... Message-ID: <20080406172304.941642758E@hg.openjdk.java.net> Changeset: b70fc43afb8c Author: wetmore Date: 2008-04-06 10:15 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/b70fc43afb8c 6683078: Update JCE framework and provider builds to work on read-only filesystems 6644659: Error in default target of make/javax/crypto in OpenJDK build Reviewed-by: valeriep, ohair ! make/com/sun/crypto/provider/Makefile ! make/common/shared/Defs.gmk ! make/javax/crypto/Defs-jce.gmk ! make/javax/crypto/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile From weijun.wang at sun.com Thu Apr 10 05:00:01 2008 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Thu, 10 Apr 2008 12:00:01 +0000 Subject: hg: jdk7/jsn/jdk: 6675606: javax.security.auth.login.Configuration does not recognize path with spaces Message-ID: <20080410120022.5B3C22775D@hg.openjdk.java.net> Changeset: ad75c4b21d63 Author: weijun Date: 2008-04-10 19:58 +0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/ad75c4b21d63 6675606: javax.security.auth.login.Configuration does not recognize path with spaces Reviewed-by: chegar, xuelei ! src/share/classes/com/sun/security/auth/login/ConfigFile.java + test/javax/security/auth/login/Configuration/ConfigFileWithBlank.java From xuelei.fan at sun.com Fri Apr 11 00:34:17 2008 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Fri, 11 Apr 2008 07:34:17 +0000 Subject: hg: jdk7/jsn/jdk: 6546639: (spec)javax.net.ssl.SSLContext.getInstance(null) throws undocumented NPE Message-ID: <20080411073436.192CD27858@hg.openjdk.java.net> Changeset: c0eb84957bea Author: xuelei Date: 2008-04-11 03:33 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/c0eb84957bea 6546639: (spec)javax.net.ssl.SSLContext.getInstance(null) throws undocumented NPE Summary: add NullPointerException description to those methods. Reviewed-by: weijun ! src/share/classes/javax/net/ssl/SSLContext.java From xuelei.fan at sun.com Fri Apr 11 00:43:59 2008 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Fri, 11 Apr 2008 07:43:59 +0000 Subject: hg: jdk7/jsn/jdk: 6546671: (spec)javax.net.ssl.TrustManagerFactory.getInstance() throws undocumented NP; ... Message-ID: <20080411074411.DE7A52785D@hg.openjdk.java.net> Changeset: da9fa1fa9b95 Author: xuelei Date: 2008-04-11 03:43 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/da9fa1fa9b95 6546671: (spec)javax.net.ssl.TrustManagerFactory.getInstance() throws undocumented NP 5053895: (spec) Unspecified IllegalStateException in TrustManagerFactory Summary: add NullPointerException/IllegalStateException description Reviewed-by: weijun ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactorySpi.java From xuelei.fan at sun.com Fri Apr 11 00:51:16 2008 From: xuelei.fan at sun.com (xuelei.fan at sun.com) Date: Fri, 11 Apr 2008 07:51:16 +0000 Subject: hg: jdk7/jsn/jdk: 6571950: SSLSocket(raddr, rport, laddr, lport) allows null as laddr that spec doesn't reflect Message-ID: <20080411075128.550BD27862@hg.openjdk.java.net> Changeset: 143e1a9b51a9 Author: xuelei Date: 2008-04-11 03:50 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/143e1a9b51a9 6571950: SSLSocket(raddr, rport, laddr, lport) allows null as laddr that spec doesn't reflect Summary: add the description that while the local address parameter is null, anyLocalAddress will be used instead. Reviewed-by: weijun ! src/share/classes/java/net/Socket.java ! src/share/classes/javax/net/ssl/SSLSocket.java From Jean-Christophe.Collet at Sun.COM Tue Apr 15 05:23:23 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Tue, 15 Apr 2008 14:23:23 +0200 Subject: Code review for 6644726: Cookie management issues Message-ID: <48049E3B.7000300@sun.com> Here are my proposed changes to fix 6644726 It does fix all 7 issues listed in the CR (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details) and adds a proper regression test. The short list is: - support for more 'expires' date format - enforce 'secure' cookies - enforce the 'port' optional attribute - set a default 'path' when none is specified as per RFC requirement - do not apply strict RFC 2965 rules for domain matching when cookie version is 0 (aka Netscape compliant cookies) - set a default path for cookies - do not use scheme and port for identifying cookies (i.e. cookies cross over protocols like http & https, or ports) Patch attached below. -------------- next part -------------- A non-text attachment was scrubbed... Name: jdk.patch Type: text/x-patch Size: 26997 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20080415/99654d07/jdk.patch From Christopher.Hegarty at Sun.COM Tue Apr 15 06:47:35 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystem) Date: Tue, 15 Apr 2008 14:47:35 +0100 Subject: 6659779 code review Message-ID: <4804B1F7.7010209@sun.com> Hi Michael, Jessie, Can I please get a code review for CR 6659779. This trivially adds logger invocations to log tunnel requests, ie. HTTP CONNECT. -Chris. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: Patch Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20080415/a03e95c2/Patch.ksh From Jean-Christophe.Collet at Sun.COM Tue Apr 15 07:28:51 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Tue, 15 Apr 2008 16:28:51 +0200 Subject: 6659779 code review In-Reply-To: <4804B1F7.7010209@sun.com> References: <4804B1F7.7010209@sun.com> Message-ID: <4804BBA3.909@sun.com> Approved. Christopher Hegarty - Sun Microsystem wrote: > Hi Michael, Jessie, > > Can I please get a code review for CR 6659779. This trivially adds > logger invocations to log tunnel requests, ie. HTTP CONNECT. > > -Chris. From gkorland at gmail.com Tue Apr 15 07:47:47 2008 From: gkorland at gmail.com (Guy Korland) Date: Tue, 15 Apr 2008 17:47:47 +0300 Subject: 100% CPU on SocketChannelImpl.connect() Message-ID: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> Hi, It seems like the following code causes an endless loop in some cases. for (;;) { InetAddress ia = isa.getAddress(); if (ia.isAnyLocalAddress()) ia = InetAddress.getLocalHost(); n = Net.connect(fd, ia, isa.getPort(),trafficClass); if ((n == IOStatus.INTERRUPTED) && isOpen()) continue; break; } Guy From Alan.Bateman at Sun.COM Tue Apr 15 07:53:17 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 15 Apr 2008 15:53:17 +0100 Subject: 100% CPU on SocketChannelImpl.connect() In-Reply-To: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> References: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> Message-ID: <4804C15D.8000904@sun.com> Guy Korland wrote: > Hi, > It seems like the following code causes an endless loop in some cases. > > for (;;) { > InetAddress ia = isa.getAddress(); > if (ia.isAnyLocalAddress()) > ia = InetAddress.getLocalHost(); > n = Net.connect(fd, ia, isa.getPort(),trafficClass); > if ((n == IOStatus.INTERRUPTED) > && isOpen()) > continue; > break; > } > > Guy > I haven't seen this code cause problems before. Do you have an example that demonstrates this? If so, which operating system? I assume for this to loop the channel must be configured blocking and the connect is interrupted. Have you run with truss, strace, or equivalent to see if this is so. -Alan. From christopher.hegarty at sun.com Tue Apr 15 09:53:35 2008 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Tue, 15 Apr 2008 16:53:35 +0000 Subject: hg: jdk7/jsn/jdk: 6659779: HttpURLConnections logger should log tunnel requests Message-ID: <20080415165357.B7E2027D73@hg.openjdk.java.net> Changeset: 459d23a95dfb Author: chegar Date: 2008-04-15 14:22 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/459d23a95dfb 6659779: HttpURLConnections logger should log tunnel requests Summary: Invoke Logger for CONNECT request/responses. Reviewed-by: jccollet ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java From gkorland at gmail.com Tue Apr 15 10:46:04 2008 From: gkorland at gmail.com (Guy Korland) Date: Tue, 15 Apr 2008 20:46:04 +0300 Subject: 100% CPU on SocketChannelImpl.connect() In-Reply-To: <4804C15D.8000904@sun.com> References: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> <4804C15D.8000904@sun.com> Message-ID: <79be5fa30804151046y6d23c94fkeb6fd3ab8dafa890@mail.gmail.com> >I haven't seen this code cause problems before. Do you have an example that >demonstrates this? I don't have a specific example, we saw it when using we Jini with an Exporter that we developed based on NIO. >If so, which operating system? We saw it on windows XP >I assume for this to loop the channel must be configured blocking and the connect is interrupted. Yes it's configured blocking but I'm not sure about the interrupt. >Have you run with truss, strace, or equivalent to see if this is so. We saw it using JProfiler. Guy On Tue, Apr 15, 2008 at 5:53 PM, Alan Bateman wrote: > > Guy Korland wrote: > > > Hi, > > It seems like the following code causes an endless loop in some cases. > > > > for (;;) { > > InetAddress ia = isa.getAddress(); > > if (ia.isAnyLocalAddress()) > > ia = InetAddress.getLocalHost(); > > n = Net.connect(fd, ia, isa.getPort(),trafficClass); > > if ((n == IOStatus.INTERRUPTED) > > && isOpen()) > > continue; > > break; > > } > > > > Guy > > > > > I haven't seen this code cause problems before. Do you have an example that > demonstrates this? If so, which operating system? I assume for this to loop > the channel must be configured blocking and the connect is interrupted. Have > you run with truss, strace, or equivalent to see if this is so. > > -Alan. > From Alan.Bateman at Sun.COM Tue Apr 15 11:04:37 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 15 Apr 2008 19:04:37 +0100 Subject: 100% CPU on SocketChannelImpl.connect() In-Reply-To: <79be5fa30804151046y6d23c94fkeb6fd3ab8dafa890@mail.gmail.com> References: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> <4804C15D.8000904@sun.com> <79be5fa30804151046y6d23c94fkeb6fd3ab8dafa890@mail.gmail.com> Message-ID: <4804EE35.6040302@sun.com> Guy Korland wrote: >> I haven't seen this code cause problems before. Do you have an example that >> demonstrates this? >> > I don't have a specific example, we saw it when using we Jini with an > Exporter that we developed based on NIO. > > >> If so, which operating system? >> > We saw it on windows XP > > >> I assume for this to loop the channel must be configured blocking and >> > the connect is interrupted. > Yes it's configured blocking but I'm not sure about the interrupt. > > >> Have you run with truss, strace, or equivalent to see if this is so. >> > We saw it using JProfiler. > Which OpenJDK build was this? I'm curious because Windows Sockets calls are never interrupted so that error should never be returned. Any chance the application in question is in a loop creating SocketChannels and calling connect (perhaps catching and ignoring an IOException). Just a guess. It would also be interesting to know if this happens outside of the profiler. -Alan. From gkorland at gmail.com Tue Apr 15 12:21:31 2008 From: gkorland at gmail.com (Guy Korland) Date: Tue, 15 Apr 2008 22:21:31 +0300 Subject: 100% CPU on SocketChannelImpl.connect() In-Reply-To: <4804EE35.6040302@sun.com> References: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> <4804C15D.8000904@sun.com> <79be5fa30804151046y6d23c94fkeb6fd3ab8dafa890@mail.gmail.com> <4804EE35.6040302@sun.com> Message-ID: <79be5fa30804151221y38d21811q622e2815a205a11d@mail.gmail.com> We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux and Windows. As you can see form the attached jpg the application only call connect() 20 times but it takes around 6 minutes. Guy On Tue, Apr 15, 2008 at 9:04 PM, Alan Bateman wrote: > Guy Korland wrote: > > > > > > I haven't seen this code cause problems before. Do you have an example > that > > > demonstrates this? > > > > > > > > I don't have a specific example, we saw it when using we Jini with an > > Exporter that we developed based on NIO. > > > > > > > > > If so, which operating system? > > > > > > > > We saw it on windows XP > > > > > > > > > I assume for this to loop the channel must be configured blocking and > > > > > > > > the connect is interrupted. > > Yes it's configured blocking but I'm not sure about the interrupt. > > > > > > > > > Have you run with truss, strace, or equivalent to see if this is so. > > > > > > > > We saw it using JProfiler. > > > > > Which OpenJDK build was this? I'm curious because Windows Sockets calls are > never interrupted so that error should never be returned. Any chance the > application in question is in a loop creating SocketChannels and calling > connect (perhaps catching and ignoring an IOException). Just a guess. It > would also be interesting to know if this happens outside of the profiler. > > -Alan. > -------------- next part -------------- A non-text attachment was scrubbed... Name: connect.JPG Type: image/jpeg Size: 21593 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20080415/6e8154b0/connect.JPG From Alan.Bateman at Sun.COM Tue Apr 15 13:29:39 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 15 Apr 2008 21:29:39 +0100 Subject: 100% CPU on SocketChannelImpl.connect() In-Reply-To: <79be5fa30804151221y38d21811q622e2815a205a11d@mail.gmail.com> References: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> <4804C15D.8000904@sun.com> <79be5fa30804151046y6d23c94fkeb6fd3ab8dafa890@mail.gmail.com> <4804EE35.6040302@sun.com> <79be5fa30804151221y38d21811q622e2815a205a11d@mail.gmail.com> Message-ID: <48051033.9030406@sun.com> Guy Korland wrote: > We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux > and Windows. > As you can see form the attached jpg the application only call > connect() 20 times but it takes around 6 minutes. > > Guy > This may not be an OpenJDK issue in which case it may be better to seek help in the networking forum [1]. That said, are you sure the code is looping? Any chance the profiler is reporting elapsed rather than CPU time and the connect is hanging for a timeout period because the connection cannot be established. -Alan. [1] http://forum.java.sun.com/forum.jspa?forumID=536 From gkorland at gmail.com Tue Apr 15 13:44:17 2008 From: gkorland at gmail.com (Guy Korland) Date: Tue, 15 Apr 2008 23:44:17 +0300 Subject: 100% CPU on SocketChannelImpl.connect() In-Reply-To: <48051033.9030406@sun.com> References: <79be5fa30804150747p7b1de0arb83fcca903249453@mail.gmail.com> <4804C15D.8000904@sun.com> <79be5fa30804151046y6d23c94fkeb6fd3ab8dafa890@mail.gmail.com> <4804EE35.6040302@sun.com> <79be5fa30804151221y38d21811q622e2815a205a11d@mail.gmail.com> <48051033.9030406@sun.com> Message-ID: <79be5fa30804151344w73110bb7q3c48fda181d873e3@mail.gmail.com> I'm pretty sure that it's looping since the profiler shows that the CPU is wasted in the method buddy. Guy On Tue, Apr 15, 2008 at 11:29 PM, Alan Bateman wrote: > Guy Korland wrote: > > > We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux > > and Windows. > > As you can see form the attached jpg the application only call > > connect() 20 times but it takes around 6 minutes. > > > > Guy > > > > > This may not be an OpenJDK issue in which case it may be better to seek > help in the networking forum [1]. That said, are you sure the code is > looping? Any chance the profiler is reporting elapsed rather than CPU time > and the connect is hanging for a timeout period because the connection > cannot be established. > > -Alan. > > [1] http://forum.java.sun.com/forum.jspa?forumID=536 > From Christopher.Hegarty at Sun.COM Wed Apr 16 02:53:47 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Wed, 16 Apr 2008 10:53:47 +0100 Subject: Code review for 6644726: Cookie management issues In-Reply-To: <48049E3B.7000300@sun.com> References: <48049E3B.7000300@sun.com> Message-ID: <4805CCAB.1050302@Sun.COM> This change looks good. -Chris. Jean-Christophe Collet wrote: > Here are my proposed changes to fix 6644726 > It does fix all 7 issues listed in the CR (see > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details) > and adds a proper regression test. > > The short list is: > > - support for more 'expires' date format > - enforce 'secure' cookies > - enforce the 'port' optional attribute > - set a default 'path' when none is specified as per RFC requirement > - do not apply strict RFC 2965 rules for domain matching when cookie > version is 0 (aka Netscape compliant cookies) > - set a default path for cookies > - do not use scheme and port for identifying cookies (i.e. cookies cross > over protocols like http & https, or ports) > > Patch attached below. > From Christopher.Hegarty at Sun.COM Wed Apr 16 06:04:27 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Wed, 16 Apr 2008 14:04:27 +0100 Subject: 6687282 code review Message-ID: <4805F95B.20506@Sun.COM> Hi, I need to get a code review for, CR 6687282 : "URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request". Digest authentication uses the request-URI as part of its algorithm when generating the response hash. The request-URI is usually the abs_path of the uri, but not always. When tunneling the target servers 'host:port' is used as the request-URI, e.g. "CONNECT verisign.com:443 HTTP/1.1" The implementation in sun.net.www.protocol.http.DigestAuthentication only uses the abs_path of the uri. This is incorrect and the target servers 'host:port' should be used when tunneling. Also, the request method ( GET/POST/CONNECT ) is used when generating the response hash. This needs to be "CONNECT" when tunneling. (diffs below) Thanks, -Chris. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jdkHttpDigest.patch Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20080416/24d65531/jdkHttpDigest.patch From Michael.McMahon at Sun.COM Wed Apr 16 10:03:11 2008 From: Michael.McMahon at Sun.COM (Michael McMahon) Date: Wed, 16 Apr 2008 18:03:11 +0100 Subject: 6687282 code review In-Reply-To: <4805F95B.20506@Sun.COM> References: <4805F95B.20506@Sun.COM> Message-ID: <4806314F.3060107@sun.com> Looks ok to me. - Michael. Christopher Hegarty - Sun Microsystems Ireland wrote: > Hi, > > I need to get a code review for, > CR 6687282 : "URLConnection for HTTPS connection through Proxy w/ > Digest Authentication gives 400 Bad Request". > > Digest authentication uses the request-URI as part of its algorithm > when generating the response hash. The request-URI is usually the > abs_path of the uri, but not always. When tunneling the target servers > 'host:port' is used as the request-URI, e.g. > "CONNECT verisign.com:443 HTTP/1.1" > > The implementation in sun.net.www.protocol.http.DigestAuthentication > only uses the abs_path of the uri. This is incorrect and the target > servers 'host:port' should be used when tunneling. Also, the request > method ( GET/POST/CONNECT ) is used when generating the response hash. > This needs to be "CONNECT" when tunneling. > > (diffs below) > > Thanks, > -Chris. From christopher.hegarty at sun.com Wed Apr 16 14:46:09 2008 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Wed, 16 Apr 2008 21:46:09 +0000 Subject: hg: jdk7/jsn/jdk: 6687282: URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request Message-ID: <20080416214628.7395327E45@hg.openjdk.java.net> Changeset: a954a6f3be6f Author: chegar Date: 2008-04-16 14:17 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a954a6f3be6f 6687282: URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request Summary: Change http/digest implementation to use host:port from CONNECT request Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java From jean-christophe.collet at sun.com Thu Apr 17 02:09:42 2008 From: jean-christophe.collet at sun.com (jean-christophe.collet at sun.com) Date: Thu, 17 Apr 2008 09:09:42 +0000 Subject: hg: jdk7/jsn/jdk: 6644726: Cookie management issues Message-ID: <20080417091000.807F527E61@hg.openjdk.java.net> Changeset: d44e3bf49ffb Author: jccollet Date: 2008-04-17 11:05 +0200 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d44e3bf49ffb 6644726: Cookie management issues Summary: Many changes to accomodate RFC 2965 and old Netscape specs Reviewed-by: chegar ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/HttpCookie.java ! src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java + test/java/net/CookieHandler/B6644726.java From bradford.wetmore at sun.com Thu Apr 17 17:04:45 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Fri, 18 Apr 2008 00:04:45 +0000 Subject: hg: jdk7/jsn/jdk: 9 new changesets Message-ID: <20080418000639.8830F27EAA@hg.openjdk.java.net> Changeset: 2965459a8ee7 Author: emcmanus Date: 2008-04-01 14:45 +0200 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/2965459a8ee7 6610917: Define a generic NotificationFilter Summary: Adds javax.management.QueryNotificationFilter Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanAnalyzer.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanIntrospector.java + src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java ! src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java ! src/share/classes/com/sun/jmx/mbeanserver/Repository.java ! src/share/classes/com/sun/jmx/mbeanserver/Util.java ! src/share/classes/javax/management/ObjectName.java + src/share/classes/javax/management/QueryNotificationFilter.java + test/javax/management/query/QueryNotifFilterTest.java Changeset: f4205a7bdfd4 Author: wetmore Date: 2008-04-07 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/f4205a7bdfd4 Merge Changeset: c2019d1360ef Author: ksrini Date: 2008-04-10 09:02 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/c2019d1360ef 6684582: Launcher needs improved error reporting Summary: indicate the missing main class in the error message Reviewed-by: darcy, kbr ! src/share/bin/emessages.h ! src/share/bin/java.c ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/Arrrghs.sh Changeset: cb934dd5e073 Author: sherman Date: 2008-04-10 14:45 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/cb934dd5e073 6529796: Support JIS X 0213:2004 in existing JDK versions, especially for Windows Vista Summary: SJIS0213 support Reviewed-by: naoto ! make/java/sun_nio/FILES_java.gmk ! make/sun/nio/Makefile + make/tools/CharsetMapping/Makefile + make/tools/CharsetMapping/sjis0213.map ! make/tools/Makefile + make/tools/src/build/tools/charsetmapping/CharsetMapping.java + make/tools/src/build/tools/charsetmapping/GenerateMapping.java + src/share/classes/sun/nio/cs/CharsetMapping.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java + src/share/classes/sun/nio/cs/ext/MS932_0213.java + src/share/classes/sun/nio/cs/ext/SJIS_0213.java Changeset: fd563c5dd750 Author: mchung Date: 2008-04-10 10:47 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/fd563c5dd750 6610094: Add generic support for platform MXBeans of any type (also fixed 6681031) Summary: Add new methods in ManagementFactory class to obtain platform MXBeans Reviewed-by: alanb, dfuchs, emcmanus ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/java/lang/management/ClassLoadingMXBean.java ! src/share/classes/java/lang/management/CompilationMXBean.java ! src/share/classes/java/lang/management/GarbageCollectorMXBean.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/MemoryMXBean.java ! src/share/classes/java/lang/management/MemoryManagerMXBean.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/OperatingSystemMXBean.java + src/share/classes/java/lang/management/PlatformComponent.java + src/share/classes/java/lang/management/PlatformManagedObject.java ! src/share/classes/java/lang/management/RuntimeMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/logging/LoggingMXBean.java ! src/share/classes/sun/management/ClassLoadingImpl.java ! src/share/classes/sun/management/CompilationImpl.java ! src/share/classes/sun/management/GarbageCollectorImpl.java ! src/share/classes/sun/management/GcInfoBuilder.java ! src/share/classes/sun/management/GcInfoCompositeData.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/classes/sun/management/HotspotCompilation.java ! src/share/classes/sun/management/HotspotInternal.java ! src/share/classes/sun/management/LockDataConverter.java ! src/share/classes/sun/management/ManagementFactory.java + src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/management/MappedMXBeanType.java ! src/share/classes/sun/management/MemoryImpl.java ! src/share/classes/sun/management/MemoryManagerImpl.java ! src/share/classes/sun/management/MemoryNotifInfoCompositeData.java ! src/share/classes/sun/management/MemoryPoolImpl.java ! src/share/classes/sun/management/MemoryUsageCompositeData.java ! src/share/classes/sun/management/MonitorInfoCompositeData.java ! src/share/classes/sun/management/NotificationEmitterSupport.java ! src/share/classes/sun/management/OperatingSystemImpl.java ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/StackTraceElementCompositeData.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/management/ThreadInfoCompositeData.java ! src/share/classes/sun/management/Util.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/classes/sun/management/VMOptionCompositeData.java ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java ! test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticOptions.java ! test/com/sun/management/HotSpotDiagnosticMXBean/GetVMOption.java ! test/com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java + test/java/lang/management/ManagementFactory/GetPlatformMXBeans.java + test/java/lang/management/OperatingSystemMXBean/PlatformMXBeanTest.java Changeset: bcf689d26c1c Author: mchung Date: 2008-04-10 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/bcf689d26c1c Merge Changeset: 18eed13fe9f6 Author: mchung Date: 2008-04-11 10:26 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/18eed13fe9f6 6687508: Update test/sun/management jtreg tests due to sun.management.ManagementFactory class rename Summary: Modified the jtreg tests to use ManagementFactoryHelper instead Reviewed-by: emcmanus ! test/sun/management/HotspotClassLoadingMBean/GetClassInitializationTime.java ! test/sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java ! test/sun/management/HotspotClassLoadingMBean/GetInitializedClassCount.java ! test/sun/management/HotspotClassLoadingMBean/GetLoadedClassSize.java ! test/sun/management/HotspotClassLoadingMBean/GetMethodDataSize.java ! test/sun/management/HotspotClassLoadingMBean/GetUnloadedClassSize.java ! test/sun/management/HotspotRuntimeMBean/GetSafepointCount.java ! test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java ! test/sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java ! test/sun/management/HotspotThreadMBean/GetInternalThreads.java Changeset: dd212ba9a0c6 Author: sherman Date: 2008-04-14 21:45 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/dd212ba9a0c6 6635133: Exception thrown when using a Unicode escape Summary: Update regex engine to handle unicode escape correctly in character class Reviewed-by: okutsu ! src/share/classes/java/util/regex/Pattern.java Changeset: 493af4f4be79 Author: wetmore Date: 2008-04-17 16:56 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/493af4f4be79 Merge From bradford.wetmore at sun.com Thu Apr 17 17:08:34 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Fri, 18 Apr 2008 00:08:34 +0000 Subject: hg: jdk7/jsn/langtools: 12 new changesets Message-ID: <20080418000853.EA11727EAF@hg.openjdk.java.net> Changeset: 6e4cefcce80a Author: mcimadamore Date: 2008-04-02 11:20 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/6e4cefcce80a 6569789: Compiler test lang/TYPE/type153/type15304/type15304.html fails since jdk7 b05 Summary: improved glb on type-inference Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6569789/T6569789.java Changeset: aeaa0f482b28 Author: mcimadamore Date: 2008-04-02 11:38 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/aeaa0f482b28 6509042: javac rejects class literals in enum constructors Summary: javac now distinguish between enum class literals and static fields Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/enum/T6509042.java Changeset: adaa3fc51b60 Author: mcimadamore Date: 2008-04-02 11:44 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/adaa3fc51b60 6531090: Cannot access methods/fields of a captured type belonging to an intersection type Summary: fixed lookup of field/methods on intersection types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/6531090/T6531090a.java + test/tools/javac/generics/6531090/T6531090b.java Changeset: ddd77d1c1b49 Author: ksrini Date: 2008-04-03 18:01 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/ddd77d1c1b49 6570242: Regression test failures with Javac on win32. Summary: takes this test out of service until the reall bug is fixed Reviewed-by: jjg ! test/tools/javac/api/6431257/T6431257.java Changeset: 961ae2608114 Author: mcimadamore Date: 2008-04-09 13:19 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/961ae2608114 6531075: Missing synthetic casts when accessing fields/methods of intersection types including type variables Summary: bug when javac generates code involving intersection types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/generics/6531075/T6531075.java Changeset: d032d5090fd5 Author: mcimadamore Date: 2008-04-09 13:41 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/d032d5090fd5 5009937: hiding versus generics versus binary compatibility Summary: missing implementation of JLS 8.4.8.3 (different arguments with same erasure not always triggering a compiler error) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/5009937/T5009937.java + test/tools/javac/generics/5009937/T5009937.out ! test/tools/javac/generics/InheritanceConflict.java ! test/tools/javac/generics/InheritanceConflict2.java Changeset: 57ba4f70f0d8 Author: mcimadamore Date: 2008-04-09 13:53 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/57ba4f70f0d8 6365166: javac (generic) unable to resolve methods Summary: Unignore regression test as this bug has been fixed by CR 6278587 Reviewed-by: jjg + test/tools/javac/generics/inference/6356673/T6365166.java Changeset: 25338c55e458 Author: mcimadamore Date: 2008-04-09 14:05 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/25338c55e458 6481655: Parser confused by combination of parens and explicit type args Summary: Bug in the parser caused by the fact that explicit type arguments are disabled when parsing parenthesized expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/Parser.java + test/tools/javac/generics/T6481655.java Changeset: 447c300a24e7 Author: mcimadamore Date: 2008-04-09 14:45 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/447c300a24e7 6450290: Capture of nested wildcards causes type error Summary: A missing capture conversion makes javac to think that some expressions are well-formed even when they aren't Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/wildcards/T6450290.java Changeset: e7bf2e39b8fe Author: mcimadamore Date: 2008-04-09 14:57 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/e7bf2e39b8fe 6657499: javac 1.6.0 fails to compile class with inner class Summary: Lookup of member inner classes silently fails leading to an unwanted erasure to take place Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/T6657499.java Changeset: 6522ea413d23 Author: mcimadamore Date: 2008-04-09 15:04 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/6522ea413d23 6683438: Bad regression test for CR 6611449 Summary: The regression test for CR 6611449 contains some inconstistencies Reviewed-by: jjg ! test/tools/javac/generics/inference/6611449/T6611449.java ! test/tools/javac/generics/inference/6611449/T6611449.out Changeset: a1d1f335633f Author: mcimadamore Date: 2008-04-09 15:30 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/a1d1f335633f 6559182: Cast from a raw type with non-generic supertype to a raw type fails unexpectedly Summary: Javac doesn't conform to JLS 4.8 - all the supertypes of a raw type must be erased Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/Casting5.java From Jean-Christophe.Collet at Sun.COM Fri Apr 18 05:06:09 2008 From: Jean-Christophe.Collet at Sun.COM (Jean-Christophe Collet) Date: Fri, 18 Apr 2008 14:06:09 +0200 Subject: Code review needed for 6558853 Message-ID: <48088EB1.9030605@sun.com> I need a code review for the simple fix to 6558853. It's a simple case of a flag not set in the native code when creating a Inet6Address. Patch attached below. Thanks -------------- next part -------------- A non-text attachment was scrubbed... Name: jdk.patch Type: text/x-patch Size: 4441 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20080418/77a532d7/jdk.patch From Christopher.Hegarty at Sun.COM Fri Apr 18 05:19:05 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Fri, 18 Apr 2008 13:19:05 +0100 Subject: Code review needed for 6558853 In-Reply-To: <48088EB1.9030605@sun.com> References: <48088EB1.9030605@sun.com> Message-ID: <480891B9.9090102@sun.com> This change looks good. -Chris. Jean-Christophe Collet wrote: > I need a code review for the simple fix to 6558853. > It's a simple case of a flag not set in the native code when creating a > Inet6Address. > > Patch attached below. > > Thanks > From jean-christophe.collet at sun.com Fri Apr 18 06:29:35 2008 From: jean-christophe.collet at sun.com (jean-christophe.collet at sun.com) Date: Fri, 18 Apr 2008 13:29:35 +0000 Subject: hg: jdk7/jsn/jdk: 6558853: getHostAddress() on connections using IPv6 link-local addrs should have zone id Message-ID: <20080418132956.4006027F61@hg.openjdk.java.net> Changeset: a71ab67d3ece Author: jccollet Date: 2008-04-18 15:23 +0200 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a71ab67d3ece 6558853: getHostAddress() on connections using IPv6 link-local addrs should have zone id Summary: Set the scope_id_set flag when necessary Reviewed-by: chegar ! src/share/native/java/net/net_util.c + test/java/net/Inet6Address/B6558853.java From Bradford.Wetmore at Sun.COM Mon Apr 21 17:42:41 2008 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Mon, 21 Apr 2008 17:42:41 -0700 Subject: No JSN integration today. Message-ID: <480D3481.5020806@sun.com> Hi gang, I had a couple of problems with the latest integration builds/tests, so I decided to hold off on a TL integration until we understand these failures better. If there was anything that *REALLY* needs to be in TL/MASTER for this build, please let me know. We're still really early in the JDK7 cycle, so this shouldn't be a problem. Next cycle will be during J1. Brad JSN Gatekeeper From weijun.wang at sun.com Tue Apr 22 17:12:24 2008 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Wed, 23 Apr 2008 00:12:24 +0000 Subject: hg: jdk7/jsn/jdk: 6689000: Changes in 6675606 causing regression test failures on windows-i586 Message-ID: <20080423001247.3546027227@hg.openjdk.java.net> Changeset: 4e7ad09de58b Author: weijun Date: 2008-04-23 08:10 +0800 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/4e7ad09de58b 6689000: Changes in 6675606 causing regression test failures on windows-i586 Summary: Accept illegal URLs like file:c:/root/x.conf and file:this/that/x.conf Reviewed-by: alanb, chegar ! src/share/classes/com/sun/security/auth/login/ConfigFile.java + test/com/sun/security/auth/login/ConfigFile/IllegalURL.java From bradford.wetmore at sun.com Wed Apr 23 17:17:37 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:17:37 +0000 Subject: hg: jdk7/jsn: 3 new changesets Message-ID: <20080424001737.A39F827452@hg.openjdk.java.net> Changeset: 05809a7eb190 Author: ohair Date: 2008-03-18 11:01 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/05809a7eb190 6674232: OPENJDK=false is same as OPENJDK=true Summary: If OPENJDK has a value, that value must be "true", empty value == undefined with GNU make. Reviewed-by: tbell ! make/Defs-internal.gmk Changeset: cbc8ad9dd0e0 Author: ohair Date: 2008-03-25 14:38 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/cbc8ad9dd0e0 6623832: Cleanup old j2se makefile targets Summary: Just removing unneeded makefile rules and 'control' logic. Reviewed-by: xdono ! Makefile ! make/jdk-rules.gmk Changeset: 9410f77cc30c Author: xdono Date: 2008-04-09 11:18 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/rev/9410f77cc30c Added tag jdk7-b25 for changeset cbc8ad9dd0e0 ! .hgtags From bradford.wetmore at sun.com Wed Apr 23 17:18:10 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:18:10 +0000 Subject: hg: jdk7/jsn/corba: 2 new changesets Message-ID: <20080424001812.D33EA27459@hg.openjdk.java.net> Changeset: 5e61d5df6258 Author: ohair Date: 2008-03-25 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/corba/rev/5e61d5df6258 6627817: Remove ^M characters in all files (Makefiles too) Summary: Some files included the use of the ^M character, which has been deleted Reviewed-by: xdono ! src/share/classes/com/sun/corba/se/impl/corba/orb_config_design.txt ! src/share/classes/org/omg/CORBA/ir.idl ! src/share/classes/org/omg/DynamicAny/DynamicAny.idl Changeset: 0043eb3d4e62 Author: xdono Date: 2008-04-09 11:18 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/corba/rev/0043eb3d4e62 Added tag jdk7-b25 for changeset 5e61d5df6258 ! .hgtags From bradford.wetmore at sun.com Wed Apr 23 17:19:13 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:19:13 +0000 Subject: hg: jdk7/jsn/hotspot: Added tag jdk7-b25 for changeset 7836be3e92d0 Message-ID: <20080424001916.D73BD27460@hg.openjdk.java.net> Changeset: 8b0b3490194f Author: xdono Date: 2008-04-09 11:18 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/8b0b3490194f Added tag jdk7-b25 for changeset 7836be3e92d0 ! .hgtags From bradford.wetmore at sun.com Wed Apr 23 17:20:52 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:20:52 +0000 Subject: hg: jdk7/jsn/jaxp: Added tag jdk7-b25 for changeset a3b3ba7d6034 Message-ID: <20080424002054.5D12F27468@hg.openjdk.java.net> Changeset: da43cb85fac1 Author: xdono Date: 2008-04-09 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxp/rev/da43cb85fac1 Added tag jdk7-b25 for changeset a3b3ba7d6034 ! .hgtags From bradford.wetmore at sun.com Wed Apr 23 17:21:28 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:21:28 +0000 Subject: hg: jdk7/jsn/jaxws: Added tag jdk7-b25 for changeset 59fd8224ba2d Message-ID: <20080424002131.08F8927473@hg.openjdk.java.net> Changeset: debd37e1a422 Author: xdono Date: 2008-04-09 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jaxws/rev/debd37e1a422 Added tag jdk7-b25 for changeset 59fd8224ba2d ! .hgtags From bradford.wetmore at sun.com Wed Apr 23 17:22:41 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:22:41 +0000 Subject: hg: jdk7/jsn/jdk: 16 new changesets Message-ID: <20080424002554.6E4F727478@hg.openjdk.java.net> Changeset: f1c168caf94f Author: ohair Date: 2008-03-18 11:03 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/f1c168caf94f 6674226: Warning errors in freetypecheck Summary: Just corrected some C code to remove warning errors from gcc. Reviewed-by: tbell ! make/tools/freetypecheck/freetypecheck.c Changeset: e564dc9241e5 Author: ohair Date: 2008-03-18 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/e564dc9241e5 6611788: chmod a+x bin/winver.exe in make/tools/winver/Makefile fails on a read only file system Summary: Tell Mercurial this file has execute permission. Reviewed-by: tbell Changeset: ea98209ac149 Author: ohair Date: 2008-03-18 11:06 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/ea98209ac149 6674232: OPENJDK=false is same as OPENJDK=true Summary: OPENJDK should be empty (undefined) or "true". Reviewed-by: tbell ! make/common/Defs.gmk Changeset: e98ce66d7630 Author: ohair Date: 2008-03-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/e98ce66d7630 6654458: /java/devtools findbugs doesn't work on windows Summary: Changes to both ant and findbugs version checking. Reviewed-by: tbell ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Sanity.gmk Changeset: 9ae5ccf6891c Author: ohair Date: 2008-03-19 13:26 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/9ae5ccf6891c 6611629: Avoid hardcoded cygwin paths for memory detection Summary: Use free with sygwin, mem or systeminfo otherwise, to get MB_OF_MEMORY on windows. Reviewed-by: tbell ! make/common/shared/Platform.gmk Changeset: 9b0d53aa8549 Author: ohair Date: 2008-03-25 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/9b0d53aa8549 6627817: Remove ^M characters in all files (Makefiles too) Summary: Some files included the use of the ^M character, which has been deleted. Reviewed-by: xdono ! make/common/shared/Sanity.gmk ! make/docs/CORE_PKGS.gmk ! src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames.properties ! src/share/classes/com/sun/inputmethods/internal/thaiim/resources/DisplayNames.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/config.dtd ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/schema/etsi.xsd ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_en.properties ! src/share/classes/javax/swing/plaf/synth/doc-files/synth.dtd ! src/share/classes/javax/swing/plaf/synth/package.html ! src/share/demo/jfc/Notepad/resources/Notepad.properties ! src/share/sample/vm/clr-jvm/Makefile ! src/share/sample/vm/clr-jvm/README.txt ! src/share/sample/vm/clr-jvm/invoker.cs ! src/share/sample/vm/jvm-clr/README.txt ! src/share/sample/vm/jvm-clr/invoked.cs Changeset: 40b6f7fcac38 Author: ohair Date: 2008-03-26 17:48 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/40b6f7fcac38 Merge Changeset: 75fca0b0ab83 Author: xdono Date: 2008-03-27 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/75fca0b0ab83 Merge Changeset: 6e25a8a3f8c6 Author: xdono Date: 2008-04-09 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/6e25a8a3f8c6 Added tag jdk7-b25 for changeset 75fca0b0ab83 ! .hgtags Changeset: e6da580585e9 Author: tbell Date: 2008-04-07 23:27 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/e6da580585e9 Merge ! make/common/shared/Defs.gmk Changeset: 4708b9a13f24 Author: tbell Date: 2008-04-11 15:06 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/4708b9a13f24 Merge Changeset: 74a42d77106b Author: tbell Date: 2008-04-15 17:46 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/74a42d77106b Merge Changeset: 2bfddc119eea Author: kamg Date: 2008-04-17 22:00 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/2bfddc119eea 6690122: Provide a mechanism for specifying Java-level USDT-like dtrace probes Summary: Initial checkin of JSDT code Reviewed-by: sspitsyn, sbohne ! make/com/sun/Makefile + make/com/sun/tracing/Makefile + make/com/sun/tracing/dtrace/Makefile ! make/docs/Makefile ! make/docs/NON_CORE_PKGS.gmk ! make/sun/Makefile + make/sun/tracing/Makefile + make/sun/tracing/dtrace/Makefile + make/sun/tracing/dtrace/mapfile-vers + src/share/classes/com/sun/tracing/Probe.java + src/share/classes/com/sun/tracing/ProbeName.java + src/share/classes/com/sun/tracing/Provider.java + src/share/classes/com/sun/tracing/ProviderFactory.java + src/share/classes/com/sun/tracing/ProviderName.java + src/share/classes/com/sun/tracing/dtrace/ArgsAttributes.java + src/share/classes/com/sun/tracing/dtrace/Attributes.java + src/share/classes/com/sun/tracing/dtrace/DependencyClass.java + src/share/classes/com/sun/tracing/dtrace/FunctionAttributes.java + src/share/classes/com/sun/tracing/dtrace/FunctionName.java + src/share/classes/com/sun/tracing/dtrace/ModuleAttributes.java + src/share/classes/com/sun/tracing/dtrace/ModuleName.java + src/share/classes/com/sun/tracing/dtrace/NameAttributes.java + src/share/classes/com/sun/tracing/dtrace/ProviderAttributes.java + src/share/classes/com/sun/tracing/dtrace/StabilityLevel.java + src/share/classes/com/sun/tracing/dtrace/package-info.java + src/share/classes/com/sun/tracing/package-info.java + src/share/classes/sun/tracing/MultiplexProviderFactory.java + src/share/classes/sun/tracing/NullProviderFactory.java + src/share/classes/sun/tracing/PrintStreamProviderFactory.java + src/share/classes/sun/tracing/ProbeSkeleton.java + src/share/classes/sun/tracing/ProviderSkeleton.java + src/share/classes/sun/tracing/dtrace/Activation.java + src/share/classes/sun/tracing/dtrace/DTraceProbe.java + src/share/classes/sun/tracing/dtrace/DTraceProvider.java + src/share/classes/sun/tracing/dtrace/DTraceProviderFactory.java + src/share/classes/sun/tracing/dtrace/JVM.java + src/share/classes/sun/tracing/package-info.java ! src/share/javavm/export/jvm.h + src/share/native/sun/tracing/dtrace/JVM.c + src/share/native/sun/tracing/dtrace/jvm_symbols.h + src/solaris/native/sun/tracing/dtrace/jvm_symbols_md.c + src/windows/native/sun/tracing/dtrace/jvm_symbols_md.c + test/com/sun/tracing/BasicFunctionality.java Changeset: 79b594e72df0 Author: kamg Date: 2008-04-21 11:24 -0400 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/79b594e72df0 6691494: doc build broken in tracingdocs Summary: Wrong variable names in makefile Reviewed-by: tbell ! make/docs/Makefile Changeset: 92ea0ac77d2f Author: emcmanus Date: 2008-04-22 18:58 +0200 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/92ea0ac77d2f 6692027: Custom subclasses of QueryEval don't serialize Summary: Remove non-public superclass of QueryEval Reviewed-by: dfuchs ! src/share/classes/javax/management/AndQueryExp.java ! src/share/classes/javax/management/BetweenQueryExp.java ! src/share/classes/javax/management/BinaryRelQueryExp.java ! src/share/classes/javax/management/NotQueryExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/OrQueryExp.java ! src/share/classes/javax/management/Query.java ! src/share/classes/javax/management/QueryEval.java + test/javax/management/query/CustomQueryTest.java Changeset: d3af7105cc15 Author: wetmore Date: 2008-04-23 10:20 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d3af7105cc15 Merge From bradford.wetmore at sun.com Wed Apr 23 17:29:26 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Thu, 24 Apr 2008 00:29:26 +0000 Subject: hg: jdk7/jsn/langtools: 4 new changesets Message-ID: <20080424002933.CDF9A2747D@hg.openjdk.java.net> Changeset: 18f0b1b5ffd6 Author: xdono Date: 2008-04-09 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/18f0b1b5ffd6 Added tag jdk7-b25 for changeset 58039502942e ! .hgtags Changeset: c46d25a2350a Author: tbell Date: 2008-04-11 15:08 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/c46d25a2350a Merge Changeset: 627deea1ea4f Author: tbell Date: 2008-04-15 17:48 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/627deea1ea4f Merge Changeset: ec29a1a284ca Author: mcimadamore Date: 2008-04-23 17:10 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/langtools/rev/ec29a1a284ca 6682380: Foreach loop with generics inside finally block crashes javac with -target 1.5 Summary: A missing type-erasure in Lower.java causes the compiler to crash since JDK6 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/foreach/T6682380.java From Christopher.Hegarty at Sun.COM Tue Apr 29 08:59:32 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Tue, 29 Apr 2008 16:59:32 +0100 Subject: Symbol ``['' and a java.net.URI.create method In-Reply-To: <200804291730.46932.mvyskocil@suse.cz> References: <200804291730.46932.mvyskocil@suse.cz> Message-ID: <481745E4.8010406@Sun.COM> Since this is a question about java.net.URI I am moving this question to the OpenJDK Net Dev alias. I will try to answer it there. -Chris. Michal Vyskocil wrote: > Hi all, > > I'm working on adopting of jpackage project to openSUSE and got a problem with > build of maven. The jpackage's folks have a script build-jar-repository, > which symlinks the jar files in /usr/share/java to defined dir. > > My problem is, that the script produces a links in this > form - /foo/bar/[ant].jar which later causes an IllegalArgumentException, > because a java.net.URI.create dissallows ``[]'' in URI. The response from > jpackage is, that java.net.URI.create has a bug, because symbol ``['' is > valid in a Unix path. > > > I'm testing several JRE implementations, but only gcj allows the ``[]'' in > URI, other ones not. > > What do you think about? Is this really a bug in handling of unix filenames? > > Regards > Michal Vyskocil From Christopher.Hegarty at Sun.COM Tue Apr 29 09:21:43 2008 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty - Sun Microsystems Ireland) Date: Tue, 29 Apr 2008 17:21:43 +0100 Subject: Symbol ``['' and a java.net.URI.create method In-Reply-To: <481745E4.8010406@Sun.COM> References: <200804291730.46932.mvyskocil@suse.cz> <481745E4.8010406@Sun.COM> Message-ID: <48174B17.8010606@Sun.COM> The square bracket characters ('[' and ']') are reserved characters in a URI. If they are to be used then they need to percent encoded. That is, '[' is percent encoded to be %5B. The single argument java.net.URI constructor requires any illegal characters in its argument to be quoted and preserves any escaped octets and other characters that are present. The static create method simply invokes the URI(String) constructor, with some extra Exception handling. Therefore any reserved characters need to be percent encoded before passing the String as an argument. You can look at the java.net.URI class description to give you a better understanding of how this encoding works. -Chris. Christopher Hegarty - Sun Microsystems Ireland wrote: > Since this is a question about java.net.URI I am moving this question to > the OpenJDK Net Dev alias. > > I will try to answer it there. > > -Chris. > > Michal Vyskocil wrote: >> Hi all, >> >> I'm working on adopting of jpackage project to openSUSE and got a >> problem with build of maven. The jpackage's folks have a script >> build-jar-repository, which symlinks the jar files in /usr/share/java >> to defined dir. >> >> My problem is, that the script produces a links in this form - >> /foo/bar/[ant].jar which later causes an IllegalArgumentException, >> because a java.net.URI.create dissallows ``[]'' in URI. The response >> from jpackage is, that java.net.URI.create has a bug, because symbol >> ``['' is valid in a Unix path. >> >> >> I'm testing several JRE implementations, but only gcj allows the >> ``[]'' in URI, other ones not. >> >> What do you think about? Is this really a bug in handling of unix >> filenames? >> >> Regards >> Michal Vyskocil From Alan.Bateman at Sun.COM Tue Apr 29 09:29:50 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 29 Apr 2008 17:29:50 +0100 Subject: Symbol ``['' and a java.net.URI.create method In-Reply-To: <48174B17.8010606@Sun.COM> References: <200804291730.46932.mvyskocil@suse.cz> <481745E4.8010406@Sun.COM> <48174B17.8010606@Sun.COM> Message-ID: <48174CFE.3060107@sun.com> Yep, it sounds like it might be doing "URI.create(file)" rather than "new File(file).toURI()". -Alan. Christopher Hegarty - Sun Microsystems Ireland wrote: > The square bracket characters ('[' and ']') are reserved characters in > a URI. If they are to be used then they need to percent encoded. That > is, '[' is percent encoded to be %5B. > > The single argument java.net.URI constructor requires any illegal > characters in its argument to be quoted and preserves any escaped > octets and other characters that are present. The static create method > simply invokes the URI(String) constructor, with some extra Exception > handling. Therefore any reserved characters need to be percent encoded > before passing the String as an argument. > > You can look at the java.net.URI class description to give you a > better understanding of how this encoding works. > > -Chris. > > Christopher Hegarty - Sun Microsystems Ireland wrote: >> Since this is a question about java.net.URI I am moving this question >> to the OpenJDK Net Dev alias. >> >> I will try to answer it there. >> >> -Chris. >> >> Michal Vyskocil wrote: >>> Hi all, >>> >>> I'm working on adopting of jpackage project to openSUSE and got a >>> problem with build of maven. The jpackage's folks have a script >>> build-jar-repository, which symlinks the jar files in >>> /usr/share/java to defined dir. >>> >>> My problem is, that the script produces a links in this form - >>> /foo/bar/[ant].jar which later causes an IllegalArgumentException, >>> because a java.net.URI.create dissallows ``[]'' in URI. The response >>> from jpackage is, that java.net.URI.create has a bug, because symbol >>> ``['' is valid in a Unix path. >>> >>> >>> I'm testing several JRE implementations, but only gcj allows the >>> ``[]'' in URI, other ones not. >>> >>> What do you think about? Is this really a bug in handling of unix >>> filenames? >>> >>> Regards >>> Michal Vyskocil