Code review for 6644726: Cookie management issues

Jean-Christophe Collet Jean-Christophe.Collet at Sun.COM
Tue Apr 15 05:23:23 PDT 2008


Here are my proposed changes to fix 6644726
It does fix all 7 issues listed in the CR (see 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details) 
and adds a proper regression test.

The short list is:

- support for more 'expires' date format
- enforce 'secure' cookies
- enforce the 'port' optional attribute
- set a default 'path' when none is specified as per RFC requirement
- do not apply strict RFC 2965 rules for domain matching when cookie 
version is 0 (aka Netscape compliant cookies)
- set a default path for cookies
- do not use scheme and port for identifying cookies (i.e. cookies cross 
over protocols like http & https, or ports)

Patch attached below.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: jdk.patch
Type: text/x-patch
Size: 26997 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20080415/99654d07/jdk.patch 


More information about the net-dev mailing list