[Fwd: [PATCH]: Portability fixes]
Martin Buchholz
martinrb at google.com
Mon Feb 2 07:53:49 PST 2009
On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems
Ireland <Christopher.Hegarty at sun.com> wrote:
> +static int isAsciiSpace(char c) {
> + return (((c) == '\t') || ((c) == '\r') || ((c) == '\b') ||
> + ((c) == '\n') || ((c) == ' ') );
> +}
> +
A very minor comment -
the parens around (c) are a very good idea in macro definitions,
but they are overkill in a function definition.
More information about the net-dev
mailing list