[Fwd: [PATCH]: Portability fixes]

[Christopher Hegarty - Sun Microsystems Ireland]

OK, after checking with the Solaris folks on the possibility of removing 
the workaround ( that contains the isspace check ), it looks like they 
cannot confirm that it has indeed been fixed. With that in mind I 
decided to keep it and only include it for Solaris builds.

Please take a look at the final changes:
   http://cr.openjdk.java.net/~chegar/6799040

Thanks,
-Chris.

On 02/02/09 22:13, Christopher Hegarty - Sun Microsystems wrote:
> Martin Buchholz wrote:
>> On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems
>> Ireland <Christopher.Hegarty at sun.com> wrote:
>>> +static int isAsciiSpace(char c) {
>>> +  return (((c) == '\t') || ((c) == '\r')  || ((c) == '\b') ||
>>> +          ((c) == '\n') || ((c) == ' ') );
>>> +}
>>> +
>>
>> A very minor comment -
>> the parens around (c) are a very good idea in macro definitions,
>> but they are overkill in a function definition.
> 
> Thanks Martin,
> 
> I will remove the parentheses if I proceed with this part of the change. 
> After the comments from Alan, I'm going to check with the Solaris folks 
> on the status of 4160367, which appears to be fixed in S10 and greater. 
> If we can I would like to remove the isspace check completely.
> 
> -Chris.
>