Request for Review 6855335

[Christopher Hegarty - Sun Microsystems Ireland]

Hi Michael, Jessie,

I need a code review for some SCTP changes that were found during testing.

CR 6855335:
   Several changes in the SCTP implementation.

Webrev:
   http://cr.openjdk.java.net/~chegar/6855335/webrev.00/webrev/

1) SctpMultiChannel.branch returns null.
    branch was not implemented in the first push of sctp. It is now.

2) SCTP_PRIMARY_ADDR not working correctly for both SctpChannel and
    SctpMultiChannel
    Fixed native implementation.

3) SctpChannel.connect(SocketAddress,int,int) throws
    "java.net.SocketException: Invalid argument" on a connected channel.
    Need to check channel state before setting options.

4) SendFailedNotification/Shutdown notification is null sometimes with
    SctpMultiChannel.
    Fall through in switch statement that implements the notification
    handler for SctpMutliChannel which leads to some handlers being
    invoked when actually a different notification was received.

5) SendFailedNotification sometimes has a null SocketAddress or
    ByteBuffer and invalid errorCode and streamNumber.
    Incorrect parameter listing when creating SendFailedNotification from
    native.

6) SctpServerChannel.getAllLocalAddresses returns null for unbound
    channel.
    Now returns empty set as specified.

7) getRemoteAddresses throws "java.net.SocketException: Invalid
    argument" for shutdown association.
    Fixed.

8) Add some new testcases as well as update existing ones to cover some
    of the above changes.

Thanks,
-Chris.