Review request for 6817246
Jean-Christophe Collet
Jean-Christophe.Collet at Sun.COM
Wed Mar 18 03:30:46 PDT 2009
Alan Bateman wrote:
> Mandy Chung wrote:
>> 6817246: Redundant call to set InetAddressCachePolicy to FOREVER if
>> not set during initialization
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/6817246/webrev.00/
>>
>> System.setSecurityManager0 calls
>> InetAddressCachePolicy.setIfNotSet(InetAddressCachePolicy.FOREVER) to
>> set the cache policy to FOREVER if not set by the command-line
>> property. In fact, this call is redundant since the default cache
>> policy is already set to FOREVER by the static initializer of the
>> InetAddressCachePolicy class.
>>
>> This fix is to remove the InetAddressCachePolicy.setIfNotSet method
>> call from System.setSecurityManager0.
>>
>> I ran the io and net jtreg tests.
>>
>> Thanks
>> Mandy
> This looks okay to me and I don't see any side effects to have the
> caching policy initialized a bit later.
>
> -Alan.
Looks good to me too.
More information about the net-dev
mailing list