Review request for 6819122

Jean-Christophe Collet Jean-Christophe.Collet at Sun.COM
Wed Mar 25 11:40:02 PDT 2009


The changes look good to me.

Mandy Chung wrote:
> 6819122: DefaultProxySelector should lazily initialize the Pattern 
> object and the NonProxyInfo objects
>
> Webrev at:
>  http://cr.openjdk.java.net/~mchung/6819122/webrev.00/
>
> Details:
> 1. The Pattern object is only used for checking a IPv6 loopback 
> address.   The current fix is to create a Pattern object for every 
> check instead of caching it.   The other alternative is to cache the 
> Pattern object at the first time it is needed.   Do you believe 
> typically applications will hit this path frequently such that caching 
> the Pattern object is needed?
>  
> 2. Move the static NonProxyInfo fields into the NonProxyInfo classes 
> so that they will only be initialized when it is needed.
>
> Thanks
> Mandy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: jean-christophe_collet.vcf
Type: text/x-vcard
Size: 246 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20090325/440fbbe4/jean-christophe_collet.vcf 


More information about the net-dev mailing list