Request for Review: 6893238

Alan Bateman Alan.Bateman at Sun.COM
Wed Oct 21 07:47:17 PDT 2009


Christopher Hegarty - Sun Microsystems Ireland wrote:
> :
> Yes, this would certainly be cleaner. I've updated the webrev. Please 
> take a look.
>
>   http://cr.openjdk.java.net/~chegar/6893238/webrev.1/webrev/
>
> Note: The lack of the initial cause of the IOException in firstToken 
> should not be a problem since the Exception is swallowed in setHeaders 
> ( a few lines above).
This looks much better - thanks for doing this. Minor bit is that the 
L183 can simply be "throw new IOException(...)".

-Alan.



More information about the net-dev mailing list