Request for Review 6882384

Christopher Hegarty - Sun Microsystems Ireland Christopher.Hegarty at Sun.COM
Tue Sep 22 05:00:25 PDT 2009


On 22/09/2009 12:58, Alan Bateman wrote:
> Christopher Hegarty - Sun Microsystems Ireland wrote:
>>
>> 6882384: Update http protocol handler to use PlatformLogger
>>
>> Webrev:
>>   http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/
>>
>> Change http logging to use the PlatformLogger. We can simply remove 
>> the reflective calls to the logging API from HttpCapture as the 
>> PlatformLogger will take care of that for us.
>>
>> -Chris.
> Looks good to me (and I see you've fixed a delegation issue in 
> PlatformLogger). Minor nit is that the indent seems to be messed up in 
> HttpClient line 809.
Ah yes, thanks Alan. It is now fixed.

-Chris.

> 
> -Alan.



More information about the net-dev mailing list