Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

[Michael McMahon]

gustav trede wrote:
>
> On 18 August 2010 12:10, Chris Hegarty <chris.hegarty at oracle.com 
> <mailto:chris.hegarty at oracle.com>> wrote:
>
>     Michael,
>
>     java.net.HttpCookie uses static SimpleDateFormat which is not
>     thread safe. I think the best solution here is to simply create
>     local SimpleDateFormat as needed.
>
>     Webrev:
>      http://cr.openjdk.java.net/~chegar/6965924/webrev.00/webrev/
>     <http://cr.openjdk.java.net/%7Echegar/6965924/webrev.00/webrev/>
>
>
> Why not use a threadlocal dateformater ?.
perhaps ...
> For certain cases Its also viable to exploit the fact that its enough 
> to generate a new value once per second for HTTP timestamps.
> Even if its not "needed", it would imo be nice if the JDK code itself 
> could somehow act as reference / good examples of how to THINK(design) 
> and implement.
>
I suspect you're looking at this from a server perspective. This code is 
involved with parsing
of incoming cookies. So, the generation of timestamps isn't being done here.

- Michael.
>
> regards
>    gustav trede