Code Review 6977851: NPE from FileURLConnection.connect

Michael McMahon michael.x.mcmahon at oracle.com
Mon Aug 23 09:04:30 PDT 2010


Chris Hegarty wrote:
> Michael,
>
> The file handler can fail with NPE in cases where permission is denied 
> to the directory. Small change, throw FileNotFoundException where a 
> directory listing is not available.
>
> Webrev:
>   http://cr.openjdk.java.net/~chegar/6977851/webrev.00/webrev/
>
> Thanks,
> -Chris.
One minor comment, and maybe it's not worth the hassle. But, when
file.list() returns null, you could call file.exists() and then use the
result of that to customise the exception text.
false ==> new FileNotFoundException (filename);
true ==> new FileNotFoundException(filename + " exists, but is not 
accessible");

- Michael



More information about the net-dev mailing list