Code Review 7004439: SCTP_SET_PEER_PRIMARY_ADDR throws SocketException on Linux

Michael McMahon michael.x.mcmahon at oracle.com
Wed Dec 8 08:48:57 PST 2010


Chris Hegarty wrote:
> Hi Michael,
>
> The native sockaddr is not being correctly set in sctp_setpeerprim. 
> Also, the value of SCTP_SET_PEER_PRIMARY_ADDR should not be an 
> IPv4-mapped address for IPv4 addresses on lksctp. It should be an IPv4 
> address, in a similar way to how we handle addresses being passed to 
> bindx.
>
> Webrev:
>   http://cr.openjdk.java.net/~chegar/7004439/webrev.00/webrev/
>
> Thanks,
> -Chris.
Looks fine.

Thanks
Michael.



More information about the net-dev mailing list