Request for Review 6922151
Christopher Hegarty -Sun Microsystems Ireland
Christopher.Hegarty at Sun.COM
Tue Feb 2 06:09:33 PST 2010
Hi Alan, Michael,
While investigating another issue I noticed that there is quite a bit of
redundant static caching of methodIDs, fieldIDs, and global references
to class objects. Most of these are for InetAddress, Inet4Address,
Inet6Address and NetworkInterface.
These classes already provide native init methods that cache a reference
to their class objects and common ID's. We should simply ensure that
this init (net_util.c) method is called and then use them. Also, all
these ID's are externally defined in net_util.h so we can use them directly.
Note:
I also cleaned up a few compiler warning in the windows code.
6922151: Cleanup static caching of method/fieldIDs and unnecessary
global references
Webrev:
http://cr.openjdk.java.net/~chegar/6922151/webrev.0/webrev/
Thanks,
-Chris.
More information about the net-dev
mailing list