Request Review: 6912868

Alan Bateman Alan.Bateman at Sun.COM
Fri Feb 19 12:22:53 PST 2010


Christopher Hegarty - Sun Microsystems Ireland wrote:
> Hi All,
>
> This patch corrects Java's usage of Gnome's proxy setting, in 
> particular the previously ignored "use_same_proxy" setting as 
> described on 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6912868 and
> https://bugzilla.redhat.com/show_bug.cgi?id=536704.
>
> I've added a manual test where the fix can be seen to resolve the bug.
>
> 6912868: "java.net.useSystemProxies" behavior fails to check 
> "use_same_proxy" in GNOME
>
> OpenJDK Bugzilla ID:
>   https://bugs.openjdk.java.net/show_bug.cgi?id=100128
>
> Webrev:
>   http://cr.openjdk.java.net/~chegar/6912868/webrev.00/webrev/
>
> Contribution-by: damjan.jov at gmail.com
>
> Thanks,
> -Chris.
Looks okay to me.  Sometime it might be good to re-write this in java 
and just have a couple of simple native method to call the gconf_  
functions.

-Alan.



More information about the net-dev mailing list