6365587: Proxy-Connection header sent through tunnel

Christopher Hegarty -Sun Microsystems Ireland Christopher.Hegarty at Sun.COM
Tue Feb 23 02:46:23 PST 2010


Hi Michael,

I need a review for CR 6365587: "Proxy-Connection header sent through 
tunnel".

Proxy-Connection header is being sent to the http server over an SSL 
tunnel. The Proxy-Connection header is only of interest to the proxy. 
You can see in our 
sun.net.www.protocol.http.HttpURLConnection.writeRequests() that we do 
not check if we are in a tunnel situation before setting this header.

When tunneling through a proxy then the proxy is essentially just 
forwarding the data and does not interpret it. We do not need to set 
this header and may cause issues with http servers that do not interpret 
it correctly.

Webrev:
   http://cr.openjdk.java.net/~chegar/6365587/webrev.00/webrev/

There is no regression test since it requires a https server and proxy, 
too convoluted for such a trivial change!

-Chris.



More information about the net-dev mailing list