Code Review 6966846: Incorrect assertion in java.net.Inet6Address.readObject

Michael McMahon michael.x.mcmahon at oracle.com
Thu Jul 8 08:50:22 PDT 2010


Chris Hegarty wrote:
> Michael,
>
> CR 6966846: Incorrect assertion in java.net.Inet6Address.readObject
>
> The readObject implementation tries to determine the scope_id of the 
> network interface, given its name ( if there is one ). It in correctly 
> asserts that the interface must have at least one IPv6 address of the 
> same site or link local prefix. The deserialization may be happening 
> on different machine, that has the same interface name and may not 
> have IPv6 enabled. This assertion is too strong and should be removed.
>
> This problem causes 
> test/java/net/Inet6Address/serialize/Serialize.java to fail on some 
> test machines, when run with assertions enabled.
>
> Webrev:
>   http://cr.openjdk.java.net/~chegar/6966846/webrev.00/webrev/
>
> Thanks,
> -Chris.
Looks fine.

- Michael.



More information about the net-dev mailing list