6964714, Please review the fix (XS), round 3

Alan Bateman Alan.Bateman at oracle.com
Mon Jul 12 01:00:03 PDT 2010


Dmitry Samersoff wrote:
> Chris,
>
> Please review my changes.
>
> see:
>
> http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/
>
> -Dmitry
>
The fix to NetworkInterface.c looks good to me.

I notice you've got the Sun copyright header in the test so that should 
be fixed. Also I agree with Chris's comment that the test can simply 
check if the Enumeration contains an element that is an instance of 
Inet6Address. Minor nit is that you seem to be intending by 8 instead of 
4 spaces. Given that the test is in the NetworkInterface directory then 
an alternative name might be IPv4Only.java (keep the name short?).

-Alan.



More information about the net-dev mailing list