Code Review 6967937: Scope id no longer being set after 6931566

Chris Hegarty chris.hegarty at oracle.com
Mon Jul 12 05:21:42 PDT 2010


On 07/12/10 12:32, Alan Bateman wrote:
> Chris Hegarty wrote:
>> Alan, Dmitry, Michael,
>>
>> CR: Scope id no longer being set after 6931566
>>
>> CR 6931566 accidentally removes the setting of the scope id for IPv6
>> addresses before adding them to the interface list. This was missed
>> during code review as there was a lot of refactoring to clean up the
>> code. The solution is to simply set the scope id as was the case in
>> the original code.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~chegar/6967937/webrev.00/webrev/
>>
>> Thanks,
>> -Chris.
> Looks okay to me. Is this covered by an existing test or do we need a
> new test?

Yes, there is a specific test for this.

> While you are there, does getIndex need the env parameter? It doesn't
> seem to be needed.

Done.

Updated Webrev:
   http://cr.openjdk.java.net/~chegar/6967937/webrev.01/webrev/

Thanks,
-Chris.

>
> -Alan.



More information about the net-dev mailing list