Code Review 6972374: NetworkInterface.getNetworkInterfaces throws "java.net.SocketException" on Solaris zone
Alan Bateman
Alan.Bateman at oracle.com
Wed Jul 28 04:55:07 PDT 2010
Chris Hegarty wrote:
> :
> Thanks, I removed it. Updated webrev:
> http://cr.openjdk.java.net/~chegar/6972374/webrev.00/webrev/
The updated webrev looks good to me.
>
> :
> I would be hopeful that there wouldn't be any more issues arising from
> 6931566 now. As you said, it's also difficult to test the various
> different types of configurations. What made reviewing the changes for
> 6931566 difficult is that there was a lot of refactoring in the code.
> I believe this makes the code much more readably, but the down side is
> these kind of issues.
I agree it's much more readable, just concerned that there are other
issues lurking.
-Alan.
More information about the net-dev
mailing list