Code Review 6935199: java/net regression tests failing with Assertions

Christopher Hegarty -Sun Microsystems Ireland Christopher.Hegarty at Sun.COM
Tue Mar 16 03:45:28 PDT 2010



Michael McMahon wrote:
> Christopher Hegarty -Sun Microsystems Ireland wrote:
>> Hi Michael,
>>
>> The following tests have incorrect assertion failures if run with 
>> assertions enabled:
>>   test/java/net/CookieHandler/TestHttpCookie.java
> Would it be better to just remove the assertion in the first one as well?

I don't think it really matters. The assertion just verifies that the 
that the construction is not called with null, which seems reasonable. 
It is just this one specific test that doesn't conform since it verifies 
that NPE is actually thrown. If you feel strongly I can remove it.

-Chris.

> 
>>   test/java/net/URLClassLoader/closetest/CloseTest.java
>>
>> Webrev:
>>   http://cr.openjdk.java.net/~chegar/6935199/webrev.00/webrev/
>>
>> -Chris.
> 



More information about the net-dev mailing list