Code Review 6863419: MimeTable initialization is too greedy

Chris Hegarty chris.hegarty at oracle.com
Tue Oct 12 07:39:40 PDT 2010


Alan Bateman wrote:
> Chris Hegarty wrote:
>> Alan, Michael,
>>
>> This is the JDK part of the changes for this CR. Trivially, it just 
>> fixes the unsafe lazy initialization of default instance of MimeTable.
>>
>> http://cr.openjdk.java.net/~chegar/6863419/webrev.00/webrev/
>>
>> Thanks,
>> -Chris.
> Looks okay to me. A comment on the new DefaultInstanceHolder class would 
> be good. One other thing is that the bug synopsis and description is 
> mis-leading so maybe they should be changed/updated.

CR 6991300: "MimeTable is unsafe" has been filed to track this issue. 
The changes in the webrev will be pushed under this bug number.

-Chris.
> 
> -Alan.



More information about the net-dev mailing list