Code Review 6993490: SocketTimeoutException on HTTP keep-alive connections

[Michael McMahon]

Chris Hegarty wrote:
> Hi Michael,
>
> The resetting of the read timeout after, error stream buffering, 
> Expect 100-Continue handling, and keepalive cleaner, may be 
> problematic if the read timeout is the default value. The default read 
> tmeout is -1 ( not set ), but Networkclient.setReadTimeout ignores 
> values less than 0. So if no timeout is explicitly set, -1, any of 
> these three pieces of code may not actually correctly reset the 
> timeout to infinity. This may lead to SocketTimeoutException on 
> persistent connections returned from the cache.
>
> The most problematic case is error stream buffering as it sets a 
> timeout of 60 millis.
>
> http://cr.openjdk.java.net/~chegar/6993490/webrev.00/webrev/
>
> Thanks,
> -Chris.
Looks fine.

- Michael