Code Review 6994079: PlainSocketImpl should close the socket if it fails

Alan Bateman Alan.Bateman at oracle.com
Fri Oct 22 09:52:53 PDT 2010


Chris Hegarty wrote:
> Alan, Michael,
>
> connect(SocketAddress,int) should close the underlying file descriptor 
> if it fails for any reason. This is consistent with the other connect 
> methods. A little other cleanup while there.
>
> http://cr.openjdk.java.net/~chegar/6994079/webrev.00/webrev/
>
> -Chris.
Looks fine to me.  It might be nicer to have "boolean connected", which 
is set to true when connectToAddress succeeds. 

-Alan




More information about the net-dev mailing list