Code Review 7030649: URL.equals() fails to compare jar urls

[Chris Hegarty]

On 04/14/11 05:56 PM, Michael McMahon wrote:
> Chris Hegarty wrote:
>> Alan, Michael,
>>
>> This is an old issue. JAR URLs may not compare equal when their
>> enclosing URL's are. The reason is that
>> URLStreamHandle.equals(URL,URL) and sameFile(URL,URL) doesn't know
>> about the composite URL syntax used by JAR URLs. To resolve this we
>> should overridden samefile in sun.net.www.protocol.jar.Handler. Ditto
>> for hashCode.
>>
>> http://cr.openjdk.java.net/~chegar/7030649/webrev.00/webrev/
>>
>> -Chris.
>
> line 106: += should be just +
>
> In the test the flag passed is being reset for each test, so only the
> result of the last test is considered for the overall test.

Thanks Michael, Updated webrev:

http://cr.openjdk.java.net/~chegar/7030649/webrev.01/webrev/

-Chris.

> Looks fine otherwise
>
> - Michael