Code Review 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

[Chris Hegarty]

On 8/10/2011 11:47 AM, Alan Bateman wrote:
> Chris Hegarty wrote:
>> ......
> Should this be parentName as I assume parent.getName will NPE here.

Do'h,  thanks. Updated patch below...

hg diff NetParamsTest.java
diff -r cf203f293b4e test/java/net/NetworkInterface/NetParamsTest.java
--- a/test/java/net/NetworkInterface/NetParamsTest.java Tue Aug 09 
16:59:44 2011 +0100
+++ b/test/java/net/NetworkInterface/NetParamsTest.java Wed Aug 10 
11:48:23 2011 +0100
@@ -45,7 +45,9 @@ public class NetParamsTest {
          System.out.println("\tPoint to Point: " + netif.isPointToPoint());
          System.out.println("\tVirtual: " + netif.isVirtual());
          if (netif.isVirtual()) {
-            System.out.println("\tParent Interface: " + 
netif.getParent().getName());
+            NetworkInterface parent = netif.getParent();
+            String parentName = parent == null ? "null" : parent.getName();
+            System.out.println("\tParent Interface: " + parentName);
          }
          System.out.println("\tMulticast: " + netif.supportsMulticast());


-Chris.

>
> -Alan