Code Review 7025938: Add bitmap mime type to content-types.properties

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 18 10:03:04 PDT 2011


Chris Hegarty wrote:
> Can I get a review for this contribution?
>
> It adds bitmap mime type support to content-types.properties, so that 
> URLConnection.getContentType() returns 'image/bmp' rather than 
> 'content/unknown'. This is not a commonly used API, but the 
> contribution seems reasonable.
>
> I agree with the change, just cannot be a reviewer of my own commits!
When you are pushing a change-set that lists someone else in the 
Contributed-by field then you can be the reviewer. I've done this a few 
times. In any case, I think this change is okay too.

-Alan.


>
> diff -r af15e902cf08 src/solaris/lib/content-types.properties
> --- a/src/solaris/lib/content-types.properties  Wed Aug 10 12:30:29 
> 2011 +0100
> +++ b/src/solaris/lib/content-types.properties  Thu Aug 18 17:36:31 
> 2011 +0100
> @@ -225,6 +225,10 @@ image/png: \
>         icon=png;\
>         action=browser
>
> +image/bmp: \
> +       description=Bitmap Image;\
> +       file_extensions=.bmp;
> +
>  text/html: \
>         description=HTML Document;\
>         file_extensions=.htm,.html;\
> diff -r af15e902cf08 src/windows/lib/content-types.properties
> --- a/src/windows/lib/content-types.properties  Wed Aug 10 12:30:29 
> 2011 +0100
> +++ b/src/windows/lib/content-types.properties  Thu Aug 18 17:36:31 
> 2011 +0100
> @@ -222,6 +222,10 @@ image/png: \
>         icon=png;\
>         action=browser
>
> +image/bmp: \
> +       description=Bitmap Image;\
> +       file_extensions=.bmp;
> +
>  text/html: \
>         description=HTML Document;\
>         file_extensions=.htm,.html;\
>
> -Chris.




More information about the net-dev mailing list