Review request: 7120875 fix macos ipv6 issue and update multiple test scripts

[Kurchi Hazra]

On 12/14/2011 11:54 AM, Alan Bateman wrote:
> On 14/12/2011 19:39, Michael McMahon wrote:
>> Hi,
>>
>> This webrev fixes a bunch of test script issues in networking and 
>> core-libs.
>> In most if not all cases, the change relates to recognising the OS 
>> that the test
>> is running on.
>>
>> It also fixes an IPv6 issue, which requires Macos versions of a 
>> couple of java.net
>> classes. These are the new files at the end of the webrev. The change 
>> is to provide
>> a default sin6_scope_id when none is provided by the user.
>>
>> http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/
>>
>> Thanks,
>> Michael.
> Michael - I haven't studied the IPv6 changes yet but I'm concerned 
> that this creates a copy of java.net.MulticastSocket. Would some 
> refactoring allow us to avoid this?
>
> In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would 
> make sense to combine SunOS, Linux and Darin into the one case. More 
> generally then I guess most of these tests could be changed so that 
> they default to PS=":" FS="/" when not on Windows or cygwin. Did you 
> check the java code for the tests in these areas for any cases where 
> they test based on os.name?

I made that shell script change - I agree that all can be combined into 
one case but I just stuck to the general format in those files.


>
> -Alan.
>
>

-- 
-Kurchi