Code Review 7020136: java/net/URLConnection/RedirectLimit.java fails intermittently
Alan Bateman
Alan.Bateman at oracle.com
Thu Feb 24 03:11:15 PST 2011
Chris Hegarty wrote:
>
> Yeah, a little more love is required. I hope I've covered all your
> concerns.
>
> http://cr.openjdk.java.net/~chegar/7020136/webrev.01/webrev/
This looks much better. In the main method it doesn't look like you
need to catch IOException. In run() you just could use
try-with-resource to ensure that s is closed (two cases). Otherwise I
think this is a big improvement.
-Alan
More information about the net-dev
mailing list