Code Review 7022269: clean up fscanf usage in soalris networking native code

Alan Bateman Alan.Bateman at oracle.com
Fri Feb 25 05:49:17 PST 2011


Chris Hegarty wrote:
> Michael, Alan,
>
> Some small cleanups to the use of scanf with specified string width. 
> The buffers should be sized large enough to handle the specified width 
> and the null terminator.
>
> http://cr.openjdk.java.net/~chegar/7022269/webrev.00/webrev/
>
> -Chris.
Looks okay although slightly inconsistent in that the code in 
initLocalIfs allows a device name up to 32 chars but the other places it 
is 20. I don't know what the right answer is.

-Alan



More information about the net-dev mailing list