Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

[Alan Bateman]

Chris Hegarty wrote:
> I received some offline comments on this.
>
> 1) SocksProxyVersionFour -> SocksProxy
> 2) SocksProxy now contains the protocol version
>
> Updated webrev:
>
> http://cr.openjdk.java.net/~chegar/6964547/webrev.01/webrev/
>
> -Chris.
This looks much cleaner. A few minor comments on the changes:

- I assume DefaultProxySelector.SOCKS_PROXY_VERSION can be private
- DefaultProxySelector line 300, might be simpler to just do "return 
SocksProxy.create(saddr, version)".

On the test, it looks like it will pass if we always use V4. Should the 
main thread get the completion status of the thread so that it knows 
that the right versions were sent?

-Alan.