Code Review 6964547: Impossible to set useV4 in SocksSocketImpl

[Chris Hegarty]

On 01/12/11 06:25 PM, Alan Bateman wrote:
> Chris Hegarty wrote:
>> :
>>
>> Updated Webrev:
>> http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/
> Looks fine except that that main thread needs to wait for the "socks
> server" thread to terminate as otherwise the test might pass before the
> thread sets failed to true.

Ah yes, I just moved the socket close to after the version check. The 
client will be blocked (in the socks protocol handhake) until the socket 
on the server side is closed.

Updated test:
 
http://cr.openjdk.java.net/~chegar/6964547/webrev.02/webrev/test/java/net/Socks/SocksProxyVersion.java.html

Thanks,
-Chris.

>
> -Alan