Code Review 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi
Alan Bateman
Alan.Bateman at oracle.com
Thu Jan 20 08:33:45 PST 2011
Chris Hegarty wrote:
> :
> Good point, I think it would be best to keep these tests all together
> and in sun/net.
>
> The name service used in these tests needs to be declared in the
> service provider configuration files, in META-INF/services ( which
> will be in the classpath of the running test ). It is easiest to put
> each test that requires a name service in its own directory where it
> can store its own service configuration files.
>
> We have 3 such tests:
> * sun/net/InetAddress/nameservice (existing) ->
> sun/net/InetAddress/nameservice/simple
> * java/net/InetAddress/B4762344.java ->
> sun/net/InetAddress/nameservice/chaining
> * sun/net/InetAddress/nameservice/deadlock (new for this bug)
>
> Updated Webrev. Moved files are just that, no other changes.
> http://cr.openjdk.java.net/~chegar/7012768/webrev.01/webrev/
>
> -Chris.
Thanks for doing that.
One small suggestion is to rename B6442088.java while you are there (it
looks odd given that the rest of the tests have proper names).
-Alan.
More information about the net-dev
mailing list