SocketPermission's implies() interesting behavior

[Charles Lee]

On 07/19/2011 04:00 PM, Chris Hegarty wrote:
>
>
> On 07/13/11 04:07 AM, Charles Lee wrote:
>> On 07/12/2011 07:03 PM, Chris Hegarty wrote:
>>>
>>>
>>> On 07/ 5/11 10:10 AM, Charles Lee wrote:
>>>> On 04/08/2011 04:47 PM, Chris Hegarty wrote:
>>>>> On 04/ 7/11 04:53 PM, Neil Richards wrote:
>>>>>> On Wed, 2011-03-16 at 10:43 +0000, Neil Richards wrote:
>>>>>>> On 11 March 2011 14:39, Chris Hegarty<chris.hegarty at oracle.com>
>>>>>>> wrote:
>>>>>>>> As Michael (cc'ed) mentioned in an earlier mail, he is going to be
>>>>>>>> making
>>>>>>>> some significant changes in this area in the next week or two. He
>>>>>>>> will
>>>>>>>> include this change with the other one, so their impact can be
>>>>>>>> considered
>>>>>>>> together, if that is ok?
>>>>>>>
>>>>>>> That's fine by me, so long as the changeset that addresses this
>>>>>>> problem is linked back to this conversation (so that one can track
>>>>>>> the
>>>>>>> progress of the fix for this problem into the component, then 
>>>>>>> master
>>>>>>> repository).
>>>>>>
>>>>>> Can you tell me if the changes headlined above have yet been made
>>>>>> to the
>>>>>> code (and point me to the URL of the change) ?
>>>>>
>>>>> These changes have not yet been integrated. I believe Michael will be
>>>>> pushing them soon.
>>>>>
>>>>> -Chris.
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Neil
>>>>>>
>>>> Hi Chris,
>>>>
>>>> I have tested this issue with latest openjdk7 build (b147). The
>>>> "blabla"[1] test case still fails. Is it ok if I am going to give a
>>>> patch according the openjdk 8 code base?
>>>
>>> I apologize for this. By the time the other changes were ready for
>>> SocketPermission we were past the lock down period for JDK7. I'll
>>> proceed with getting the changes we agreed upon [1] into JDK8.
>
> I pushed a changeset for this last night.
>
> Changeset: 8bbea505b060
> Author:    chegar
> Date:      2011-07-18 22:25 +0100
> URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bbea505b060
>
> 7021280: SocketPermission should accept wildcards
> Reviewed-by: michaelm
>
> ! src/share/classes/java/net/SocketPermission.java
> + test/java/net/SocketPermission/Wildcard.java
>
>
> -Chris.
>
Yes. Chris. I saw this change on the jdk8 tools and language repos. It 
works. Thank you very much.



>>>
>>> -Chris.
>>>
>>> [1] http://cr.openjdk.java.net/~chegar/7021280/webrev.01/webrev/
>>>
>>>>
>>>> [1] http://bugs.sun.com/view_bug.do?bug_id=7021280
>>>>
>> No problem. Thank you very much, Chris.
>>


-- 
Yours Charles