Code Review 6670868: StackOverFlow with bad authenticated Proxy tunnels

Michael McMahon michael.x.mcmahon at oracle.com
Wed Jul 27 05:15:23 PDT 2011


On 26/07/11 16:21, Chris Hegarty wrote:
> Michael,
>
> There is an issue in the tunneling/Http retry code whereby a proxy 
> requiring authentication, if it gives a bad response after the initial 
> 407, may cause the HTTPClient to perform recursive calls to parseHTTP 
> until StackOverFlow. The reason is obvious when you look at the "try 
> once more" in HttpClient (webrev).
>
> This fix required some cleaned in HttpURLConnection, and partially 
> removes a previous fix, CR 6216082. I verified that this part of the 
> change for 6216082 is no longer required, and confirmed this by 
> running the test that was added as part of 6216082.
>
> Webrev:
>   http://cr.openjdk.java.net/~chegar/6670868/webrev.00/webrev/
>
> -Chris.

Looks fine.

Thanks
Michael.



More information about the net-dev mailing list