Code Review 7030256: Cleanup/Remove code supporting old Windows versions (98, NT, 2000, etc)

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 24 03:55:13 PDT 2011


Chris Hegarty wrote:
> Alan, Michael,
>
> The subject line says it all! Nice to be able to remove this old code 
> that is no longer necessary. Hopefully this will make maintenance a 
> little easier going forward.
>
> http://cr.openjdk.java.net/~chegar/7030256/webrev.00/webrev/
>
> Mike Duigou noticed I pushed this webrev to cr.openjdk yesterday and 
> has already given feedback. Thanks Mike.
>
> -Chris.
This looks a good cleanup to me. Lots of 95/98 crud in the repository 
and always hard to get time to clear it out.

I guess the only concern is that net.dll will now require iphlpapi.dll.

Minor comments:

src/windows/native/java/net/Inet6AddressImpl.c - you might need to 
re-aligned line 344.

src/windows/native/java/net/net_util_md.c line - cast to jint???

-Alan.



More information about the net-dev mailing list