Code Review 7030256: Cleanup/Remove code supporting old Windows versions (98, NT, 2000, etc)

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 24 04:49:14 PDT 2011


Chris Hegarty wrote:
>
> Yes, we will now have a dependency on iphlpapi.dll, but this dll is 
> part of Windows since Windows 2000 and the functions we are using are 
> all available on XP. Does this address your concern, or do you have 
> another issue?
The concern is that we load yet another DLL at startup. It might be 
worth checking if it gets loaded already.

> :
>
> I forgot to mention that I fixed a few compiler warning while I was 
> here. Are you referring to the casting of SOCKET s to jint, line 982? 
> SOCKET is an unsigned int pointer and needs an explicit cast. I 
> thought it was safe, and is what is done in Java_sun_nio_ch_Net_socket0.
NET_Socket is declared to return an int so I assume you meant to cast to 
int rather than jint.

-Alan.



More information about the net-dev mailing list