From jim.holmlund at sun.com Tue Nov 1 15:50:55 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Tue, 01 Nov 2011 22:50:55 +0000 Subject: hg: jdk8/tl/langtools: 7101933: langtools jtreg tests do not work with jprt on windows Message-ID: <20111101225059.479F9471F7@hg.openjdk.java.net> Changeset: 9e2eb4bc49eb Author: jjh Date: 2011-11-01 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9e2eb4bc49eb 7101933: langtools jtreg tests do not work with jprt on windows Summary: Fixed langtools/test/Makefile to work on cygwin. Updated jtreg to 4.1 and JCK to JCK8. Reviewed-by: jjg, ohair ! test/Makefile From littlee at linux.vnet.ibm.com Wed Nov 2 01:34:56 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 02 Nov 2011 16:34:56 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EA7E18A.1020809@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> Message-ID: <4EB100B0.1070706@linux.vnet.ibm.com> On 10/26/2011 06:31 PM, Chris Hegarty wrote: > On 26/10/2011 10:36, Alan Bateman wrote: >> On 26/10/2011 10:24, Charles Lee wrote: >>> >>> >>> />>> I don't think this code has changed too much since then and >>> probably could do with a clean-up./ >>> Not true. >> I'm talking about the InetAddress* code, that hasn't changed >> significantly and probably could do with some modernization now. > > Yes, please submit a patch for this cleanup and we'll review it. > > -Chris. > >> >> -Alan. > Hi Alan, Chris and Neil, Here is the early review version of cleanup patch (attached). It only changes Inet4AddressImpl.c file and does: 1. Inet4AddressImpl_getLocalHostName is changed to use getaddrinfo things. 2. Inet4AddressImpl_lookupAllHostAddr is changed to use getaddrinfo things. 3. Inet4AddressImpl_getHostByAddr is changed to use getaddrinfo things. I am not using function pointer but function directly. There are some things I will do next step: 1. Remove NET_addrtransAvailable() in the net_util_md.[ch] 2. Remove function pointer assignment in the net_util._md.c IPv6_supported method. 3. Remove the NET_addrtransAvailable() check in the Inet6AddressImpl.c 4. Use the direct function instead of the function pointer in the Inet6AddressImpl.c Since this patch will be a little big, I would like to post the patch step by step. Any suggestions and comments? P.S. Neil, would you please help to file a CR about this issue? -- Yours Charles -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch.contr.v1 Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111102/c390ae20/patch.contr.v1 From littlee at linux.vnet.ibm.com Wed Nov 2 08:07:19 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 02 Nov 2011 23:07:19 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EA7E18A.1020809@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> Message-ID: <4EB15CA7.8040305@linux.vnet.ibm.com> On 10/26/2011 06:31 PM, Chris Hegarty wrote: > On 26/10/2011 10:36, Alan Bateman wrote: >> On 26/10/2011 10:24, Charles Lee wrote: >>> >>> >>> />>> I don't think this code has changed too much since then and >>> probably could do with a clean-up./ >>> Not true. >> I'm talking about the InetAddress* code, that hasn't changed >> significantly and probably could do with some modernization now. > > Yes, please submit a patch for this cleanup and we'll review it. > > -Chris. > >> >> -Alan. > Hi Chris, Alan and Neil, Here is the rest of the patch (attached). The patch is a little big because some formats. -- Yours Charles -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch.contr.part2 Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111102/36f4450b/patch.contr.part2 From neil.richards at ngmr.net Wed Nov 2 09:33:28 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Wed, 02 Nov 2011 16:33:28 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EB15CA7.8040305@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> Message-ID: <1320251608.7502.7.camel@chalkhill> On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote: > On 10/26/2011 06:31 PM, Chris Hegarty wrote: > > On 26/10/2011 10:36, Alan Bateman wrote: > >> On 26/10/2011 10:24, Charles Lee wrote: > >>> > >>> > >>> />>> I don't think this code has changed too much since then and > >>> probably could do with a clean-up./ > >>> Not true. > >> I'm talking about the InetAddress* code, that hasn't changed > >> significantly and probably could do with some modernization now. > > > > Yes, please submit a patch for this cleanup and we'll review it. > > > > -Chris. > > > >> > >> -Alan. > > > Hi Chris, Alan and Neil, > > Here is the rest of the patch (attached). The patch is a little big > because some formats. > For ease of review, I've uploaded this change (ie. the combination of Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1]. My initial (and picky) observation is that the code indentation needs a little work to comply with the OpenJDK coding conventions [2]. (Particularly using a standard indentation for 4 spaces). Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/ [2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From mark.reinhold at oracle.com Thu Nov 3 12:29:03 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 03 Nov 2011 12:29:03 -0700 Subject: JEP 125: Network Interface Aliases, Events, and Defaults Message-ID: <20111103192903.9D2AE26CF@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/125 - Mark From mike.duigou at oracle.com Thu Nov 3 14:00:24 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 03 Nov 2011 21:00:24 +0000 Subject: hg: jdk8/tl/jdk: 4533691: Add Collections.emptySortedSet() Message-ID: <20111103210053.E80D247224@hg.openjdk.java.net> Changeset: 2f2f56ac8b82 Author: mduigou Date: 2011-11-03 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f2f56ac8b82 4533691: Add Collections.emptySortedSet() Reviewed-by: mduigou, alanb, dholmes Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/util/Collections.java + test/java/util/Collections/EmptySortedSet.java From maurizio.cimadamore at oracle.com Fri Nov 4 05:57:22 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 04 Nov 2011 12:57:22 +0000 Subject: hg: jdk8/tl/langtools: 7104201: Refactor DocCommentScanner Message-ID: <20111104125724.B49FB4723F@hg.openjdk.java.net> Changeset: 56830d5cb5bb Author: mcimadamore Date: 2011-11-04 12:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/56830d5cb5bb 7104201: Refactor DocCommentScanner Summary: Add new Comment helper class to parse contents of comments in source code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java + test/tools/javac/depDocComment/DeprecatedDocComment4.java + test/tools/javac/depDocComment/DeprecatedDocComment4.out From lana.steuck at oracle.com Sat Nov 5 09:47:07 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 05 Nov 2011 16:47:07 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20111105164707.BC4B847253@hg.openjdk.java.net> Changeset: ca977d167697 Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ca977d167697 Added tag jdk8-b11 for changeset d1b7a4f6dd20 ! .hgtags Changeset: bcc739229f63 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bcc739229f63 Added tag jdk8-b12 for changeset ca977d167697 ! .hgtags From lana.steuck at oracle.com Sat Nov 5 09:47:07 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 05 Nov 2011 16:47:07 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20111105164707.BF55447254@hg.openjdk.java.net> Changeset: 8e2104d565ba Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8e2104d565ba Added tag jdk8-b11 for changeset 1defbc57940a ! .hgtags Changeset: 26fb81a1e9ce Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/26fb81a1e9ce Added tag jdk8-b12 for changeset 8e2104d565ba ! .hgtags From lana.steuck at oracle.com Sat Nov 5 09:47:10 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 05 Nov 2011 16:47:10 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20111105164710.BC5BE47255@hg.openjdk.java.net> Changeset: e6eed2ff5d5f Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e6eed2ff5d5f Added tag jdk8-b11 for changeset a12ab897a249 ! .hgtags Changeset: adf2a6b5fde1 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/adf2a6b5fde1 Added tag jdk8-b12 for changeset e6eed2ff5d5f ! .hgtags From lana.steuck at oracle.com Sat Nov 5 09:47:07 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 05 Nov 2011 16:47:07 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20111105164712.A8FEC47256@hg.openjdk.java.net> Changeset: 31d70911b712 Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/31d70911b712 Added tag jdk8-b11 for changeset 0199e4fef5cc ! .hgtags Changeset: 5b9d9b839d3d Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5b9d9b839d3d Added tag jdk8-b12 for changeset 31d70911b712 ! .hgtags From lana.steuck at oracle.com Sat Nov 5 09:47:25 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 05 Nov 2011 16:47:25 +0000 Subject: hg: jdk8/tl/langtools: 5 new changesets Message-ID: <20111105164737.0309147257@hg.openjdk.java.net> Changeset: 8ff85191a7ac Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8ff85191a7ac Added tag jdk8-b11 for changeset 4bf01f1c4e34 ! .hgtags Changeset: 52df2131e294 Author: lana Date: 2011-10-25 21:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/52df2131e294 Merge - src/share/classes/com/sun/tools/javac/file/Paths.java - src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java - src/share/classes/com/sun/tools/javac/parser/Keywords.java - src/share/classes/com/sun/tools/javac/parser/Token.java Changeset: f2d6ed25857d Author: lana Date: 2011-10-28 17:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f2d6ed25857d Merge - src/share/classes/com/sun/tools/javac/file/Paths.java - src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java - src/share/classes/com/sun/tools/javac/parser/Keywords.java - src/share/classes/com/sun/tools/javac/parser/Token.java Changeset: ae25163501bc Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae25163501bc Added tag jdk8-b12 for changeset f2d6ed25857d ! .hgtags Changeset: 11c184155128 Author: lana Date: 2011-11-05 00:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/11c184155128 Merge From lana.steuck at oracle.com Sat Nov 5 09:47:14 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 05 Nov 2011 16:47:14 +0000 Subject: hg: jdk8/tl/hotspot: 34 new changesets Message-ID: <20111105164829.5A42547258@hg.openjdk.java.net> Changeset: bc257a801090 Author: jcoomes Date: 2011-10-14 21:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bc257a801090 7101096: Bump the hs23 build number to 03 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 940513efe83a Author: iveresov Date: 2011-10-04 10:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/940513efe83a 7097679: Tiered: events with bad bci to Gotos reduced from Ifs Summary: Save bci of instruction that produced Goto and use it to call back to runtime Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: ec5ce9326985 Author: kvn Date: 2011-10-04 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ec5ce9326985 6865265: JVM crashes with "missing exception handler" error Summary: Retry the call to fast_exception_handler_bci_for() after it returned with a pending exception. Don't cache the exception handler pc computed by compute_compiled_exc_handler() if the handler is for another (nested) exception. Reviewed-by: kamg, kvn Contributed-by: volker.simonis at gmail.com ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/sharedRuntime.cpp + test/compiler/6865265/StackOverflowBug.java Changeset: eba73e0c7780 Author: bdelsart Date: 2011-10-07 13:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eba73e0c7780 7096366: PPC: corruption of floating-point values with DeoptimizeALot Summary: fix for a deoptimization found on PPC, which could impact other big endian platforms Reviewed-by: roland, dholmes ! src/share/vm/c1/c1_LinearScan.cpp Changeset: 0abefdb54d21 Author: twisti Date: 2011-10-11 02:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0abefdb54d21 7081938: JSR292: assert(magic_number_2() == MAGIC_NUMBER_2) failed Reviewed-by: never, bdelsart ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp Changeset: 5eb9169b1a14 Author: twisti Date: 2011-10-12 21:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5eb9169b1a14 7092712: JSR 292: unloaded invokedynamic call sites can lead to a crash with signature types not on BCP Reviewed-by: jrose, never ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp Changeset: a786fdc79c5f Author: never Date: 2011-10-13 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a786fdc79c5f 7100165: JSR 292: leftover printing code in methodHandleWalk.cpp Reviewed-by: kvn, twisti ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 4bac06a82bc3 Author: kvn Date: 2011-10-14 10:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4bac06a82bc3 7100757: The BitSet.nextSetBit() produces incorrect result in 32bit VM on Sparc Summary: Instruction countTrailingZerosL() should use iRegIsafe dst register since it is used in long arithmetic. Reviewed-by: never, twisti ! src/cpu/sparc/vm/sparc.ad + test/compiler/7100757/Test7100757.java Changeset: 11d17c7d2ee6 Author: iveresov Date: 2011-10-16 02:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11d17c7d2ee6 Merge Changeset: 2ef3386478e6 Author: dholmes Date: 2011-10-10 21:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2ef3386478e6 7096278: Update the VM name to indicate it is an embedded build Reviewed-by: kvn, never, jcoomes, bobv ! src/share/vm/runtime/vm_version.cpp Changeset: 436b4a3231bf Author: dcubed Date: 2011-10-13 09:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/436b4a3231bf 7098194: integrate macosx-port changes Summary: Integrate bsd-port/hotspot and macosx-port/hotspot changes as of 2011.09.29. Reviewed-by: kvn, dholmes, never, phh Contributed-by: Christos Zoulas , Greg Lewis , Kurt Miller , Alexander Strange , Mike Swingler , Roger Hoover , Victor Hernandez , Pratik Solanki ! .hgignore + agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/os/bsd/Makefile ! agent/src/os/bsd/symtab.c ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java ! make/Makefile ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/sa.make ! make/bsd/makefiles/saproc.make ! make/bsd/makefiles/top.make ! make/bsd/makefiles/vm.make ! make/defs.make - make/templates/bsd-header ! src/cpu/x86/vm/jni_x86.h + src/os/bsd/dtrace/generateJvmOffsets.cpp + src/os/bsd/dtrace/generateJvmOffsets.h + src/os/bsd/dtrace/generateJvmOffsetsMain.c + src/os/bsd/dtrace/hotspot.d + src/os/bsd/dtrace/hotspot_jni.d + src/os/bsd/dtrace/hs_private.d + src/os/bsd/dtrace/jhelper.d + src/os/bsd/dtrace/jvm_dtrace.c + src/os/bsd/dtrace/jvm_dtrace.h + src/os/bsd/dtrace/libjvm_db.c + src/os/bsd/dtrace/libjvm_db.h ! src/os/bsd/vm/dtraceJSDT_bsd.cpp ! src/os/bsd/vm/jvm_bsd.h ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/bsd_x86_32.s ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/bytes_bsd_zero.inline.hpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/dtrace.hpp + src/share/vm/utilities/dtrace_usdt2_disabled.hpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/hashtable.cpp Changeset: 23a1c8de9d51 Author: dholmes Date: 2011-10-17 01:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/23a1c8de9d51 Merge - make/templates/bsd-header ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp Changeset: 8187c94a9a87 Author: never Date: 2011-10-17 11:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8187c94a9a87 7093690: JSR292: SA-JDI AssertionFailure: Expected raw sp likely got real sp, value was Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCFrame.java Changeset: e5928e7dab26 Author: never Date: 2011-10-17 21:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e5928e7dab26 7098528: crash with java -XX:+ExtendedDTraceProbes Reviewed-by: kvn ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/oops/instanceMirrorKlass.cpp Changeset: 16f9fa2bf76c Author: kvn Date: 2011-10-19 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/16f9fa2bf76c 7100935: win32: memmove is not atomic but is used for pd_conjoint_*_atomic operations Summary: replace the call to memmove by a simple copy loop Reviewed-by: dholmes, kvn, never Contributed-by: axel.siebenborn at sap.com, volker.simonis at gmail.com ! src/cpu/sparc/vm/copy_sparc.hpp ! src/os_cpu/windows_x86/vm/copy_windows_x86.inline.hpp + test/runtime/7100935/TestConjointAtomicArraycopy.java + test/runtime/7100935/TestShortArraycopy.java Changeset: 1179647ee175 Author: iveresov Date: 2011-10-21 00:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1179647ee175 Merge Changeset: ec4b032a4977 Author: tonyp Date: 2011-10-13 13:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ec4b032a4977 7098085: G1: partially-young GCs not initiated under certain circumstances Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: 074f0252cc13 Author: tonyp Date: 2011-10-14 11:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/074f0252cc13 7088680: G1: Cleanup in the G1CollectorPolicy class Summary: Removed unused fields and methods, removed the G1CollectoryPolicy_BestRegionsFirst class and folded its functionality into the G1CollectorPolicy class. Reviewed-by: ysr, brutisso, jcoomes ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/memory/universe.cpp Changeset: bf2d2b8b1726 Author: johnc Date: 2011-10-17 09:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf2d2b8b1726 7095243: Disambiguate ReferenceProcessor::_discoveredSoftRefs Summary: Add a new, separate, pointer to the base of the array of discovered reference lists and use this new pointer in places where we iterate over the entire array. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp Changeset: 647872693572 Author: tonyp Date: 2011-10-21 07:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/647872693572 Merge Changeset: 4d3850d9d326 Author: jcoomes Date: 2011-10-21 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4d3850d9d326 Merge - make/templates/bsd-header Changeset: 4538caeef7b6 Author: jcoomes Date: 2011-10-21 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4538caeef7b6 Added tag hs23-b03 for changeset 4d3850d9d326 ! .hgtags Changeset: 02fe430d493e Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/02fe430d493e Added tag jdk8-b11 for changeset 4538caeef7b6 ! .hgtags Changeset: c9d25d93ddfe Author: jcoomes Date: 2011-10-21 16:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9d25d93ddfe 7103619: Bump the hs23 build number to 04 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5e5d4821bf07 Author: brutisso Date: 2011-10-20 10:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5e5d4821bf07 7097516: G1: assert(0<= from_card && from_card Changeset: e1f4b4b4b96e Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1f4b4b4b96e Added tag jdk8-b11 for changeset 7ab0d613cd1a ! .hgtags Changeset: 7746eb8c610b Author: bae Date: 2011-10-17 15:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7746eb8c610b 6997116: The case automatically failed due to java.lang.ClassCastException. Reviewed-by: jgodinez, prr ! src/windows/classes/sun/java2d/d3d/D3DSurfaceData.java + test/sun/java2d/DirectX/DrawBitmaskToSurfaceTest.java Changeset: a7a001378444 Author: jgodinez Date: 2011-10-24 09:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7a001378444 6604109: javax.print.PrintServiceLookup.lookupPrintServices fails SOMETIMES for Cups Reviewed-by: bae, prr ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: 8f9b0629d088 Author: lana Date: 2011-10-25 21:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f9b0629d088 Merge Changeset: 7814800c64bd Author: lana Date: 2011-10-25 21:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7814800c64bd Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 09fd2067f715 Author: lana Date: 2011-10-28 17:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09fd2067f715 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: d636e737c478 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d636e737c478 Added tag jdk8-b12 for changeset 09fd2067f715 ! .hgtags Changeset: ead9dabe8c75 Author: lana Date: 2011-11-05 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead9dabe8c75 Merge From ahughes at redhat.com Sun Nov 6 16:07:15 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Mon, 7 Nov 2011 00:07:15 +0000 Subject: JEP 125: Network Interface Aliases, Events, and Defaults In-Reply-To: <20111103192903.9D2AE26CF@eggemoggin.niobe.net> References: <20111103192903.9D2AE26CF@eggemoggin.niobe.net> Message-ID: <20111107000715.GA25917@rivendell.middle-earth.co.uk> On 12:29 Thu 03 Nov , mark.reinhold at oracle.com wrote: > Posted: http://openjdk.java.net/jeps/125 > > - Mark Could these not be posted in the mail with a link to the online version? They're just text after all. It's annoying to have numerous mails with just a link in, and it means having to move away from the mail client to the browser all the time. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111107/7f793d27/attachment.bin From littlee at linux.vnet.ibm.com Sun Nov 6 22:14:12 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 07 Nov 2011 14:14:12 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <1320251608.7502.7.camel@chalkhill> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> Message-ID: <4EB77734.8040609@linux.vnet.ibm.com> On 11/03/2011 12:33 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote: >> On 10/26/2011 06:31 PM, Chris Hegarty wrote: >>> On 26/10/2011 10:36, Alan Bateman wrote: >>>> On 26/10/2011 10:24, Charles Lee wrote: >>>>> >>>>> />>> I don't think this code has changed too much since then and >>>>> probably could do with a clean-up./ >>>>> Not true. >>>> I'm talking about the InetAddress* code, that hasn't changed >>>> significantly and probably could do with some modernization now. >>> Yes, please submit a patch for this cleanup and we'll review it. >>> >>> -Chris. >>> >>>> -Alan. >> Hi Chris, Alan and Neil, >> >> Here is the rest of the patch (attached). The patch is a little big >> because some formats. >> > For ease of review, I've uploaded this change (ie. the combination of > Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1]. > > My initial (and picky) observation is that the code indentation needs a > little work to comply with the OpenJDK coding conventions [2]. > (Particularly using a standard indentation for 4 spaces). > > Regards, Neil > > [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/ > [2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf > Thanks Neil. I will change it. -- Yours Charles From xueming.shen at oracle.com Mon Nov 7 13:43:24 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 07 Nov 2011 21:43:24 +0000 Subject: hg: jdk8/tl/jdk: 7096080: UTF8 update and new CESU-8 charset; ... Message-ID: <20111107214342.E2C4047272@hg.openjdk.java.net> Changeset: 417d91754849 Author: sherman Date: 2011-11-07 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/417d91754849 7096080: UTF8 update and new CESU-8 charset 7082884: Incorrect UTF8 conversion for sequence ED 31 7082883: Incorrect UTF8 conversion for sequence fc 80 80 8f bf bf Summary: Updated UTF8 and added CESU-8 to following the latest Standard Reviewed-by: alanb ! make/java/nio/FILES_java.gmk + src/share/classes/sun/nio/cs/CESU_8.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/standard-charsets ! test/java/nio/charset/coders/Errors.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/TestStringCodingUTF8.java ! test/sun/nio/cs/TestUTF8.java From littlee at linux.vnet.ibm.com Tue Nov 8 05:44:29 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 08 Nov 2011 21:44:29 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <1320251608.7502.7.camel@chalkhill> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> Message-ID: <4EB9323D.1060206@linux.vnet.ibm.com> On 11/03/2011 12:33 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote: >> On 10/26/2011 06:31 PM, Chris Hegarty wrote: >>> On 26/10/2011 10:36, Alan Bateman wrote: >>>> On 26/10/2011 10:24, Charles Lee wrote: >>>>> >>>>> />>> I don't think this code has changed too much since then and >>>>> probably could do with a clean-up./ >>>>> Not true. >>>> I'm talking about the InetAddress* code, that hasn't changed >>>> significantly and probably could do with some modernization now. >>> Yes, please submit a patch for this cleanup and we'll review it. >>> >>> -Chris. >>> >>>> -Alan. >> Hi Chris, Alan and Neil, >> >> Here is the rest of the patch (attached). The patch is a little big >> because some formats. >> > For ease of review, I've uploaded this change (ie. the combination of > Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1]. > > My initial (and picky) observation is that the code indentation needs a > little work to comply with the OpenJDK coding conventions [2]. > (Particularly using a standard indentation for 4 spaces). > > Regards, Neil > > [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/ > [2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf > Hi guys, Apart from the code convention issues, would anyone help to review the patch? It's kind of big patch :-) -- Yours Charles From chris.hegarty at oracle.com Tue Nov 8 11:25:59 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 08 Nov 2011 19:25:59 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EB9323D.1060206@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> Message-ID: <4EB98247.2020903@oracle.com> Charles, Is it possible to fix up the style issues, etc that Neil pointed out, and have the webrev updated? Thanks, -Chris. On 11/ 8/11 01:44 PM, Charles Lee wrote: > On 11/03/2011 12:33 AM, Neil Richards wrote: >> On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote: >>> On 10/26/2011 06:31 PM, Chris Hegarty wrote: >>>> On 26/10/2011 10:36, Alan Bateman wrote: >>>>> On 26/10/2011 10:24, Charles Lee wrote: >>>>>> >>>>>> />>> I don't think this code has changed too much since then and >>>>>> probably could do with a clean-up./ >>>>>> Not true. >>>>> I'm talking about the InetAddress* code, that hasn't changed >>>>> significantly and probably could do with some modernization now. >>>> Yes, please submit a patch for this cleanup and we'll review it. >>>> >>>> -Chris. >>>> >>>>> -Alan. >>> Hi Chris, Alan and Neil, >>> >>> Here is the rest of the patch (attached). The patch is a little big >>> because some formats. >>> >> For ease of review, I've uploaded this change (ie. the combination of >> Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1]. >> >> My initial (and picky) observation is that the code indentation needs a >> little work to comply with the OpenJDK coding conventions [2]. >> (Particularly using a standard indentation for 4 spaces). >> >> Regards, Neil >> >> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/ >> [2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf >> > Hi guys, > > Apart from the code convention issues, would anyone help to review the > patch? It's kind of big patch :-) > From jonathan.gibbons at oracle.com Tue Nov 8 11:52:10 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 08 Nov 2011 19:52:10 +0000 Subject: hg: jdk8/tl/langtools: 6921494: provide way to print javac tree tag values Message-ID: <20111108195215.4E9F747298@hg.openjdk.java.net> Changeset: ca49d50318dc Author: jjg Date: 2011-11-08 11:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca49d50318dc 6921494: provide way to print javac tree tag values Reviewed-by: jjg, mcimadamore Contributed-by: vicenterz at yahoo.es ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/AbstractTreeScannerTest.java ! test/tools/javac/tree/TreePosTest.java From jonathan.gibbons at oracle.com Tue Nov 8 17:29:18 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 09 Nov 2011 01:29:18 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20111109012923.97C05472A1@hg.openjdk.java.net> Changeset: 36553cb94345 Author: jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/36553cb94345 7108668: allow Log to be initialized and used earlier Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! src/share/classes/com/sun/tools/javadoc/Start.java Changeset: ae361e7f435a Author: jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae361e7f435a 7108669: cleanup Log methods for direct printing to streams Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/6410653/T6410653.java ! test/tools/javac/diags/ArgTypeCompilerFactory.java From weijun.wang at oracle.com Tue Nov 8 17:51:19 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 09 Nov 2011 01:51:19 +0000 Subject: hg: jdk8/tl/jdk: 7107019: sun.security.krb5.internal.ccache.CCacheInputStream.readCred does not use auth data Message-ID: <20111109015130.0CF22472A2@hg.openjdk.java.net> Changeset: f410b91caf45 Author: weijun Date: 2011-11-09 09:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f410b91caf45 7107019: sun.security.krb5.internal.ccache.CCacheInputStream.readCred does not use auth data Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ccache/CCacheInputStream.java ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java From littlee at linux.vnet.ibm.com Tue Nov 8 20:19:14 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 09 Nov 2011 12:19:14 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EB98247.2020903@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> Message-ID: <4EB9FF42.8010700@linux.vnet.ibm.com> On 11/09/2011 03:25 AM, Chris Hegarty wrote: > Charles, > > Is it possible to fix up the style issues, etc that Neil pointed out, > and have the webrev updated? > > Thanks, > -Chris. > > On 11/ 8/11 01:44 PM, Charles Lee wrote: >> On 11/03/2011 12:33 AM, Neil Richards wrote: >>> On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote: >>>> On 10/26/2011 06:31 PM, Chris Hegarty wrote: >>>>> On 26/10/2011 10:36, Alan Bateman wrote: >>>>>> On 26/10/2011 10:24, Charles Lee wrote: >>>>>>> >>>>>>> />>> I don't think this code has changed too much since then and >>>>>>> probably could do with a clean-up./ >>>>>>> Not true. >>>>>> I'm talking about the InetAddress* code, that hasn't changed >>>>>> significantly and probably could do with some modernization now. >>>>> Yes, please submit a patch for this cleanup and we'll review it. >>>>> >>>>> -Chris. >>>>> >>>>>> -Alan. >>>> Hi Chris, Alan and Neil, >>>> >>>> Here is the rest of the patch (attached). The patch is a little big >>>> because some formats. >>>> >>> For ease of review, I've uploaded this change (ie. the combination of >>> Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1]. >>> >>> My initial (and picky) observation is that the code indentation needs a >>> little work to comply with the OpenJDK coding conventions [2]. >>> (Particularly using a standard indentation for 4 spaces). >>> >>> Regards, Neil >>> >>> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/ >>> [2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf >>> >> Hi guys, >> >> Apart from the code convention issues, would anyone help to review the >> patch? It's kind of big patch :-) >> > Hi Chris, Here it is. (attached) -- Yours Charles -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch.contr.v2 Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111109/ccb65e16/patch.contr.v2 From weijun.wang at oracle.com Tue Nov 8 23:51:52 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 09 Nov 2011 07:51:52 +0000 Subject: hg: jdk8/tl/jdk: 7109096: keytool -genkeypair needn't call -selfcert Message-ID: <20111109075203.1D76F472A5@hg.openjdk.java.net> Changeset: 52be75d060f9 Author: weijun Date: 2011-11-09 15:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52be75d060f9 7109096: keytool -genkeypair needn't call -selfcert Reviewed-by: xuelei ! src/share/classes/sun/security/tools/CertAndKeyGen.java ! src/share/classes/sun/security/tools/KeyTool.java From chris.hegarty at oracle.com Thu Nov 10 04:23:07 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 10 Nov 2011 12:23:07 +0000 Subject: hg: jdk8/tl/jdk: 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative Message-ID: <20111110122328.26002472E2@hg.openjdk.java.net> Changeset: d6a5da5f6ba0 Author: dl Date: 2011-11-10 12:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6a5da5f6ba0 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative Reviewed-by: chegar, mduigou, dholmes ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java From michael.x.mcmahon at oracle.com Thu Nov 10 05:31:20 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 10 Nov 2011 13:31:20 +0000 Subject: Code review: 7110484 Message-ID: <4EBBD228.9060104@oracle.com> Chris, Would you mind taking a look at this? It's a small change to the http server. http://cr.openjdk.java.net/~michaelm/7110484/webrev.1/ I haven't included a regression test because to test it reliably would require at least a minute's worth of test time. I'm not sure the issue warrants that given the recent improvements in test run time. Thanks Michael From michael.x.mcmahon at oracle.com Thu Nov 10 06:27:56 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 10 Nov 2011 14:27:56 +0000 Subject: Code review: 7110484 In-Reply-To: <4EBBD228.9060104@oracle.com> References: <4EBBD228.9060104@oracle.com> Message-ID: <4EBBDF6C.7080400@oracle.com> On 10/11/11 13:31, Michael McMahon wrote: > Chris, > > Would you mind taking a look at this? It's a small change to the http > server. > http://cr.openjdk.java.net/~michaelm/7110484/webrev.1/ > > I haven't included a regression test because to test it reliably would > require > at least a minute's worth of test time. I'm not sure the issue > warrants that given > the recent improvements in test run time. > > Thanks > Michael Slightly improved version. http://cr.openjdk.java.net/~michaelm/7110484/webrev.2/ From chris.hegarty at oracle.com Thu Nov 10 06:43:55 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 10 Nov 2011 14:43:55 +0000 Subject: Code review: 7110484 In-Reply-To: <4EBBDF6C.7080400@oracle.com> References: <4EBBD228.9060104@oracle.com> <4EBBDF6C.7080400@oracle.com> Message-ID: <4EBBE32B.7000903@oracle.com> On 10/11/2011 14:27, Michael McMahon wrote: > On 10/11/11 13:31, Michael McMahon wrote: >> Chris, >> >> Would you mind taking a look at this? It's a small change to the http >> server. >> http://cr.openjdk.java.net/~michaelm/7110484/webrev.1/ >> >> I haven't included a regression test because to test it reliably would >> require >> at least a minute's worth of test time. I'm not sure the issue >> warrants that given >> the recent improvements in test run time. >> >> Thanks >> Michael > Slightly improved version. > > http://cr.openjdk.java.net/~michaelm/7110484/webrev.2/ Looks good to me. -Chris. From michael.x.mcmahon at oracle.com Thu Nov 10 08:25:42 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 10 Nov 2011 16:25:42 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111110162624.AB781472EE@hg.openjdk.java.net> Changeset: 0ccfb35cce26 Author: michaelm Date: 2011-11-10 15:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ccfb35cce26 7110484: HttpServer.stop() not closing selector Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: e5d65a583c15 Author: michaelm Date: 2011-11-10 15:41 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5d65a583c15 Merge From lance.andersen at oracle.com Thu Nov 10 08:42:39 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 10 Nov 2011 16:42:39 +0000 Subject: hg: jdk8/tl/jdk: 7110111: Minor Java SE javadoc & Constructor clean up Message-ID: <20111110164249.AEEAF472EF@hg.openjdk.java.net> Changeset: 830d2e46023a Author: lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc & Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/io/Writer.java ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/util/jar/Attributes.java From sean.coffey at oracle.com Fri Nov 11 02:09:07 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 11 Nov 2011 10:09:07 +0000 Subject: hg: jdk8/tl/jdk: 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile Message-ID: <20111111100937.879D647312@hg.openjdk.java.net> Changeset: 9dd994f319ee Author: coffeys Date: 2011-11-11 10:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9dd994f319ee 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/solaris/classes/java/io/FileDescriptor.java ! src/windows/classes/java/io/FileDescriptor.java - test/java/io/FileDescriptor/FileChannelFDTest.java + test/java/io/FileDescriptor/Sharing.java - test/java/io/etc/FileDescriptorSharing.java From sean.coffey at oracle.com Fri Nov 11 02:16:25 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 11 Nov 2011 10:16:25 +0000 Subject: hg: jdk8/tl/corba: 7091388: Regular unexplained npe's from corba libs after system has been running for days Message-ID: <20111111101628.4F27947313@hg.openjdk.java.net> Changeset: 44c269731425 Author: coffeys Date: 2011-11-11 10:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/44c269731425 7091388: Regular unexplained npe's from corba libs after system has been running for days Reviewed-by: alanb ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream_1_0.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream_1_0.java From neil.richards at ngmr.net Fri Nov 11 06:53:24 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Fri, 11 Nov 2011 14:53:24 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EB9FF42.8010700@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> Message-ID: <1321023204.24687.3.camel@chalkhill> On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: > On 11/09/2011 03:25 AM, Chris Hegarty wrote: > > Charles, > > > > Is it possible to fix up the style issues, etc that Neil pointed out, > > and have the webrev updated? > > > Hi Chris, > > Here it is. (attached) > And here it is, in webrev form [1]. Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/ -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From kurchi.subhra.hazra at oracle.com Fri Nov 11 10:57:21 2011 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Fri, 11 Nov 2011 13:57:21 -0500 Subject: Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Message-ID: <4EBD7011.8040701@oracle.com> Hi, As specified in the CR description, this is a bug in src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() should be called instead of socketSetOption(). This bug did not create a problem yet since setOption() is usually called for setting socket options. Submitting hg diff: diff --git a/src/windows/classes/java/net/PlainSocketImpl.java b/src/windows/classes/java/net/PlainSocketImpl.java --- a/src/windows/classes/java/net/PlainSocketImpl.java +++ b/src/windows/classes/java/net/PlainSocketImpl.java @@ -314,7 +314,7 @@ class PlainSocketImpl extends AbstractPl void socketSetOption(int cmd, boolean on, Object value) throws SocketException { - socketSetOption(cmd, on, value); + impl.socketSetOption(cmd, on, value); } int socketGetOption(int opt, Object iaContainerObj) throws SocketException { Thanks, -- -Kurchi From Alan.Bateman at oracle.com Fri Nov 11 11:10:11 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 11 Nov 2011 19:10:11 +0000 Subject: Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself In-Reply-To: <4EBD7011.8040701@oracle.com> References: <4EBD7011.8040701@oracle.com> Message-ID: <4EBD7313.7080707@oracle.com> On 11/11/2011 18:57, Kurchi Hazra wrote: > Hi, > > As specified in the CR description, this is a bug in > src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() > should be called instead of socketSetOption(). > > This bug did not create a problem yet since setOption() is usually > called for setting socket options. > > Submitting hg diff: > > diff --git a/src/windows/classes/java/net/PlainSocketImpl.java > b/src/windows/classes/java/net/PlainSocketImpl.java > --- a/src/windows/classes/java/net/PlainSocketImpl.java > +++ b/src/windows/classes/java/net/PlainSocketImpl.java > @@ -314,7 +314,7 @@ class PlainSocketImpl extends AbstractPl > > void socketSetOption(int cmd, boolean on, Object value) > throws SocketException { > - socketSetOption(cmd, on, value); > + impl.socketSetOption(cmd, on, value); > } > > int socketGetOption(int opt, Object iaContainerObj) throws > SocketException { Looks fine to me. -Alan From mike.duigou at oracle.com Fri Nov 11 12:07:44 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 11 Nov 2011 12:07:44 -0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <1321023204.24687.3.camel@chalkhill> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> Message-ID: <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> Some comments: Inet4AddressImpl.c: - why use bzero rather than posix memset? - MAXHOSTNAMELEN is used. Shouldn't this be NI_MAXHOST as in the Inet6 version? Mike On Nov 11 2011, at 06:53 , Neil Richards wrote: > On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: >> On 11/09/2011 03:25 AM, Chris Hegarty wrote: >>> Charles, >>> >>> Is it possible to fix up the style issues, etc that Neil pointed out, >>> and have the webrev updated? >>> > >> Hi Chris, >> >> Here it is. (attached) >> > > And here it is, in webrev form [1]. > > Regards, Neil > > [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/ > > -- > Unless stated above: > IBM email: neil_richards at uk.ibm.com > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > From littlee at linux.vnet.ibm.com Sun Nov 13 21:41:02 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 14 Nov 2011 13:41:02 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> Message-ID: <4EC0A9EE.9060108@linux.vnet.ibm.com> On 11/12/2011 04:07 AM, Mike Duigou wrote: > Some comments: > > Inet4AddressImpl.c: > > - why use bzero rather than posix memset? > - MAXHOSTNAMELEN is used. Shouldn't this be NI_MAXHOST as in the Inet6 version? > > Mike > > > On Nov 11 2011, at 06:53 , Neil Richards wrote: > >> On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: >>> On 11/09/2011 03:25 AM, Chris Hegarty wrote: >>>> Charles, >>>> >>>> Is it possible to fix up the style issues, etc that Neil pointed out, >>>> and have the webrev updated? >>>> >> >>> Hi Chris, >>> >>> Here it is. (attached) >>> >> And here it is, in webrev form [1]. >> >> Regards, Neil >> >> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/ >> >> -- >> Unless stated above: >> IBM email: neil_richards at uk.ibm.com >> IBM United Kingdom Limited - Registered in England and Wales with number 741598. >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >> I will change the patch: 1. bzero(&hints, sizeof(hints)) ---> memset(&hints, 0, sizeof(hints)) (2 in Inet4AddressImpl, 2 in Inet6AddressImpl) 2. MAXHOSTNAMELEN in getaddrinfo in Inet4AddressImpl to NI_MAXHOST. Thanks for the review, Mike. -- Yours Charles From xuelei.fan at oracle.com Mon Nov 14 01:22:25 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 14 Nov 2011 09:22:25 +0000 Subject: hg: jdk8/tl/jdk: 7111548: unexpected debug log message Message-ID: <20111114092249.A7D3747352@hg.openjdk.java.net> Changeset: 5c7c83a6ee24 Author: xuelei Date: 2011-11-14 01:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7c83a6ee24 7111548: unexpected debug log message Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java From chris.hegarty at oracle.com Mon Nov 14 01:59:22 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 14 Nov 2011 09:59:22 +0000 Subject: Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself In-Reply-To: <4EBD7011.8040701@oracle.com> References: <4EBD7011.8040701@oracle.com> Message-ID: <4EC0E67A.4000402@oracle.com> On 11/11/2011 18:57, Kurchi Hazra wrote: > Hi, > > As specified in the CR description, this is a bug in > src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() > should be called instead of socketSetOption(). > > This bug did not create a problem yet since setOption() is usually > called for setting socket options. > > Submitting hg diff: > > diff --git a/src/windows/classes/java/net/PlainSocketImpl.java > b/src/windows/classes/java/net/PlainSocketImpl.java > --- a/src/windows/classes/java/net/PlainSocketImpl.java > +++ b/src/windows/classes/java/net/PlainSocketImpl.java > @@ -314,7 +314,7 @@ class PlainSocketImpl extends AbstractPl > > void socketSetOption(int cmd, boolean on, Object value) > throws SocketException { > - socketSetOption(cmd, on, value); > + impl.socketSetOption(cmd, on, value); > } > > int socketGetOption(int opt, Object iaContainerObj) throws > SocketException { Looks fine. Thanks for taking care of this. -Chris. > > Thanks, > From chris.hegarty at oracle.com Mon Nov 14 03:06:19 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 14 Nov 2011 11:06:19 +0000 Subject: hg: jdk8/tl/jdk: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Message-ID: <20111114110642.BEABE47356@hg.openjdk.java.net> Changeset: 68fc55d12ae6 Author: chegar Date: 2011-11-14 10:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68fc55d12ae6 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/windows/classes/java/net/PlainSocketImpl.java From chris.hegarty at oracle.com Mon Nov 14 06:15:04 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 14 Nov 2011 14:15:04 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC0A9EE.9060108@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> Message-ID: <4EC12268.2040605@oracle.com> I agree with Mikes comments, and here are a few of trivial ones of my own. - 'struct sockaddr_in6 him6' here is unused in getHostByAddr - caddr[16] - > caddr[4] in getHostByAddr Thanks for making this change. It really cleans up this old code. It is not your fault as the same is in Inet6AddressImpl, but I do see warnings building this: "../../../src/solaris/native/java/net/Inet4AddressImpl.c", line 70: warning: declaration can not follow a statement "../../../src/solaris/native/java/net/Inet4AddressImpl.c", line 71: warning: declaration can not follow a statement If you have the time maybe you could resolve these? Thanks, -Chris. On 14/11/2011 05:41, Charles Lee wrote: > On 11/12/2011 04:07 AM, Mike Duigou wrote: >> Some comments: >> >> Inet4AddressImpl.c: >> >> - why use bzero rather than posix memset? >> - MAXHOSTNAMELEN is used. Shouldn't this be NI_MAXHOST as in the Inet6 >> version? >> >> Mike >> >> >> On Nov 11 2011, at 06:53 , Neil Richards wrote: >> >>> On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: >>>> On 11/09/2011 03:25 AM, Chris Hegarty wrote: >>>>> Charles, >>>>> >>>>> Is it possible to fix up the style issues, etc that Neil pointed out, >>>>> and have the webrev updated? >>>>> >>> >>>> Hi Chris, >>>> >>>> Here it is. (attached) >>>> >>> And here it is, in webrev form [1]. >>> >>> Regards, Neil >>> >>> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/ >>> >>> -- >>> Unless stated above: >>> IBM email: neil_richards at uk.ibm.com >>> IBM United Kingdom Limited - Registered in England and Wales with >>> number 741598. >>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire >>> PO6 3AU >>> > I will change the patch: > 1. bzero(&hints, sizeof(hints)) ---> memset(&hints, 0, sizeof(hints)) (2 > in Inet4AddressImpl, 2 in Inet6AddressImpl) > 2. MAXHOSTNAMELEN in getaddrinfo in Inet4AddressImpl to NI_MAXHOST. > > Thanks for the review, Mike. > From kumar.x.srinivasan at oracle.com Mon Nov 14 08:38:16 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 14 Nov 2011 16:38:16 +0000 Subject: hg: jdk8/tl/langtools: 7110974: (javac) add coding conventions and style checkers for langtools Message-ID: <20111114163820.B61A847358@hg.openjdk.java.net> Changeset: c1238fcc9515 Author: ksrini Date: 2011-11-14 08:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c1238fcc9515 7110974: (javac) add coding conventions and style checkers for langtools Reviewed-by: jjg ! make/build.properties ! make/build.xml + make/conf/checkstyle-emacs.xsl + make/conf/checkstyle-langtools.xml From kumar.x.srinivasan at oracle.com Mon Nov 14 15:36:33 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 14 Nov 2011 23:36:33 +0000 Subject: hg: jdk8/tl/langtools: 7106166: (javac) re-factor EndPos parser Message-ID: <20111114233635.3AB444735E@hg.openjdk.java.net> Changeset: 7375d4979bd3 Author: ksrini Date: 2011-11-14 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7375d4979bd3 7106166: (javac) re-factor EndPos parser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java - src/share/classes/com/sun/tools/javac/parser/EndPosParser.java + src/share/classes/com/sun/tools/javac/parser/EndPosTable.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/TreePosTest.java From littlee at linux.vnet.ibm.com Mon Nov 14 17:45:25 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 15 Nov 2011 09:45:25 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC12268.2040605@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> Message-ID: <4EC1C435.1010704@linux.vnet.ibm.com> On 11/14/2011 10:15 PM, Chris Hegarty wrote: > I agree with Mikes comments, and here are a few of trivial ones of my > own. > > - 'struct sockaddr_in6 him6' here is unused in getHostByAddr > - caddr[16] - > caddr[4] in getHostByAddr > > Thanks for making this change. It really cleans up this old code. > > It is not your fault as the same is in Inet6AddressImpl, but I do see > warnings building this: > > "../../../src/solaris/native/java/net/Inet4AddressImpl.c", line 70: > warning: declaration can not follow a statement > "../../../src/solaris/native/java/net/Inet4AddressImpl.c", line 71: > warning: declaration can not follow a statement > > If you have the time maybe you could resolve these? > > Thanks, > -Chris. > > On 14/11/2011 05:41, Charles Lee wrote: >> On 11/12/2011 04:07 AM, Mike Duigou wrote: >>> Some comments: >>> >>> Inet4AddressImpl.c: >>> >>> - why use bzero rather than posix memset? >>> - MAXHOSTNAMELEN is used. Shouldn't this be NI_MAXHOST as in the Inet6 >>> version? >>> >>> Mike >>> >>> >>> On Nov 11 2011, at 06:53 , Neil Richards wrote: >>> >>>> On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: >>>>> On 11/09/2011 03:25 AM, Chris Hegarty wrote: >>>>>> Charles, >>>>>> >>>>>> Is it possible to fix up the style issues, etc that Neil pointed >>>>>> out, >>>>>> and have the webrev updated? >>>>>> >>>> >>>>> Hi Chris, >>>>> >>>>> Here it is. (attached) >>>>> >>>> And here it is, in webrev form [1]. >>>> >>>> Regards, Neil >>>> >>>> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/ >>>> >>>> -- >>>> Unless stated above: >>>> IBM email: neil_richards at uk.ibm.com >>>> IBM United Kingdom Limited - Registered in England and Wales with >>>> number 741598. >>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire >>>> PO6 3AU >>>> >> I will change the patch: >> 1. bzero(&hints, sizeof(hints)) ---> memset(&hints, 0, sizeof(hints)) (2 >> in Inet4AddressImpl, 2 in Inet6AddressImpl) >> 2. MAXHOSTNAMELEN in getaddrinfo in Inet4AddressImpl to NI_MAXHOST. >> >> Thanks for the review, Mike. >> > Interesting. I do not see those warnings. I will double check it. Thanks Chris. -- Yours Charles From littlee at linux.vnet.ibm.com Mon Nov 14 22:57:12 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 15 Nov 2011 14:57:12 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC12268.2040605@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> Message-ID: <4EC20D48.9060503@linux.vnet.ibm.com> On 11/14/2011 10:15 PM, Chris Hegarty wrote: > I agree with Mikes comments, and here are a few of trivial ones of my > own. > > - 'struct sockaddr_in6 him6' here is unused in getHostByAddr > - caddr[16] - > caddr[4] in getHostByAddr > > Thanks for making this change. It really cleans up this old code. > > It is not your fault as the same is in Inet6AddressImpl, but I do see > warnings building this: > > "../../../src/solaris/native/java/net/Inet4AddressImpl.c", line 70: > warning: declaration can not follow a statement > "../../../src/solaris/native/java/net/Inet4AddressImpl.c", line 71: > warning: declaration can not follow a statement > > If you have the time maybe you could resolve these? > > Thanks, > -Chris. > > On 14/11/2011 05:41, Charles Lee wrote: >> On 11/12/2011 04:07 AM, Mike Duigou wrote: >>> Some comments: >>> >>> Inet4AddressImpl.c: >>> >>> - why use bzero rather than posix memset? >>> - MAXHOSTNAMELEN is used. Shouldn't this be NI_MAXHOST as in the Inet6 >>> version? >>> >>> Mike >>> >>> >>> On Nov 11 2011, at 06:53 , Neil Richards wrote: >>> >>>> On Wed, 2011-11-09 at 12:19 +0800, Charles Lee wrote: >>>>> On 11/09/2011 03:25 AM, Chris Hegarty wrote: >>>>>> Charles, >>>>>> >>>>>> Is it possible to fix up the style issues, etc that Neil pointed >>>>>> out, >>>>>> and have the webrev updated? >>>>>> >>>> >>>>> Hi Chris, >>>>> >>>>> Here it is. (attached) >>>>> >>>> And here it is, in webrev form [1]. >>>> >>>> Regards, Neil >>>> >>>> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.01/ >>>> >>>> -- >>>> Unless stated above: >>>> IBM email: neil_richards at uk.ibm.com >>>> IBM United Kingdom Limited - Registered in England and Wales with >>>> number 741598. >>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire >>>> PO6 3AU >>>> >> I will change the patch: >> 1. bzero(&hints, sizeof(hints)) ---> memset(&hints, 0, sizeof(hints)) (2 >> in Inet4AddressImpl, 2 in Inet6AddressImpl) >> 2. MAXHOSTNAMELEN in getaddrinfo in Inet4AddressImpl to NI_MAXHOST. >> >> Thanks for the review, Mike. >> > Sigh. Chris, I still fail to see those warnings, even if I do a very clean remove of my build directory and rebuild the whole jdk .... Here is the new (big) patch(attached) according to the comments from you and Mike. Thank you guys :-) -- Yours Charles -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch.contr Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111115/d15fefd5/patch.contr From chris.hegarty at oracle.com Tue Nov 15 03:10:30 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 15 Nov 2011 11:10:30 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC20D48.9060503@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> Message-ID: <4EC248A6.6040703@oracle.com> On 11/15/11 06:57 AM, Charles Lee wrote: > .... >>> >> > Sigh. Chris, I still fail to see those warnings, even if I do a very > clean remove of my build directory and rebuild the whole jdk .... The warning are being generated on Solaris when using the Sun compilers ( both full and incremental builds ). > Here is the new (big) patch(attached) according to the comments from you > and Mike. Thank you guys :-) I can't apply the patch you sent. Is it possible to generate a webrev, another patch, or let me know how to apply the the one you sent? Thanks, -Chris. From littlee at linux.vnet.ibm.com Tue Nov 15 03:37:18 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 15 Nov 2011 19:37:18 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC248A6.6040703@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> Message-ID: <4EC24EEE.9030801@linux.vnet.ibm.com> On 11/15/2011 07:10 PM, Chris Hegarty wrote: > On 11/15/11 06:57 AM, Charles Lee wrote: >> .... >>>> >>> >> Sigh. Chris, I still fail to see those warnings, even if I do a very >> clean remove of my build directory and rebuild the whole jdk .... > > The warning are being generated on Solaris when using the Sun > compilers ( both full and incremental builds ). > >> Here is the new (big) patch(attached) according to the comments from you >> and Mike. Thank you guys :-) > > I can't apply the patch you sent. Is it possible to generate a webrev, > another patch, or let me know how to apply the the one you sent? > > Thanks, > -Chris. > Hi Chris, patch -p0 < mypatch under the jdk directory will do the trick. I will try to find a solaris to test my patch. -- Yours Charles From neil.richards at ngmr.net Tue Nov 15 09:00:14 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Tue, 15 Nov 2011 17:00:14 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC24EEE.9030801@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> Message-ID: <1321376414.3957.1.camel@chalkhill> On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: > On 11/15/2011 07:10 PM, Chris Hegarty wrote: > > On 11/15/11 06:57 AM, Charles Lee wrote: > >> .... > >>>> > >>> > >> Sigh. Chris, I still fail to see those warnings, even if I do a very > >> clean remove of my build directory and rebuild the whole jdk .... > > > > The warning are being generated on Solaris when using the Sun > > compilers ( both full and incremental builds ). > > > >> Here is the new (big) patch(attached) according to the comments from you > >> and Mike. Thank you guys :-) > > > > I can't apply the patch you sent. Is it possible to generate a webrev, > > another patch, or let me know how to apply the the one you sent? > > > > Thanks, > > -Chris. > > > Hi Chris, > > patch -p0 < mypatch under the jdk directory will do the trick. > > I will try to find a solaris to test my patch. > Here is Charles' latest patch in webrev form [1]. Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/ -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From littlee at linux.vnet.ibm.com Tue Nov 15 17:48:47 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 16 Nov 2011 09:48:47 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <1321376414.3957.1.camel@chalkhill> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> Message-ID: <4EC3167F.5010404@linux.vnet.ibm.com> On 11/16/2011 01:00 AM, Neil Richards wrote: > On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: >> On 11/15/2011 07:10 PM, Chris Hegarty wrote: >>> On 11/15/11 06:57 AM, Charles Lee wrote: >>>> .... >>>> Sigh. Chris, I still fail to see those warnings, even if I do a very >>>> clean remove of my build directory and rebuild the whole jdk .... >>> The warning are being generated on Solaris when using the Sun >>> compilers ( both full and incremental builds ). >>> >>>> Here is the new (big) patch(attached) according to the comments from you >>>> and Mike. Thank you guys :-) >>> I can't apply the patch you sent. Is it possible to generate a webrev, >>> another patch, or let me know how to apply the the one you sent? >>> >>> Thanks, >>> -Chris. >>> >> Hi Chris, >> >> patch -p0< mypatch under the jdk directory will do the trick. >> >> I will try to find a solaris to test my patch. >> > Here is Charles' latest patch in webrev form [1]. > > Regards, Neil > > [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/ > Thanks Neil. Hi Chris, With the latest patch, the warning of Inet4AddressImpl seems gone :-P (I have reordered the statement and declaration). They used to happen on the solaris indeed. Do you see other warnings now? -- Yours Charles From weijun.wang at oracle.com Tue Nov 15 19:54:35 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 16 Nov 2011 03:54:35 +0000 Subject: hg: jdk8/tl/jdk: 7111579: klist starttime, renewtill, ticket etype Message-ID: <20111116035453.EF98B4738A@hg.openjdk.java.net> Changeset: c740519fe83a Author: weijun Date: 2011-11-16 11:53 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c740519fe83a 7111579: klist starttime, renewtill, ticket etype Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java From masayoshi.okutsu at oracle.com Tue Nov 15 20:31:00 2011 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Wed, 16 Nov 2011 04:31:00 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111116043119.9EFE64738B@hg.openjdk.java.net> Changeset: cd6d236e863b Author: okutsu Date: 2011-11-16 12:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd6d236e863b 7111903: (tz) Windows-only: tzmappings needs update for KB2570791 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 1266e72f7896 Author: okutsu Date: 2011-11-16 13:17 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1266e72f7896 Merge From chris.hegarty at oracle.com Wed Nov 16 12:57:18 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 16 Nov 2011 20:57:18 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC3167F.5010404@linux.vnet.ibm.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> Message-ID: <4EC423AE.9090801@oracle.com> On 11/16/11 01:48 AM, Charles Lee wrote: > On 11/16/2011 01:00 AM, Neil Richards wrote: >> On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: >>> On 11/15/2011 07:10 PM, Chris Hegarty wrote: >>>> On 11/15/11 06:57 AM, Charles Lee wrote: >>>>> .... >>>>> Sigh. Chris, I still fail to see those warnings, even if I do a very >>>>> clean remove of my build directory and rebuild the whole jdk .... >>>> The warning are being generated on Solaris when using the Sun >>>> compilers ( both full and incremental builds ). >>>> >>>>> Here is the new (big) patch(attached) according to the comments >>>>> from you >>>>> and Mike. Thank you guys :-) >>>> I can't apply the patch you sent. Is it possible to generate a webrev, >>>> another patch, or let me know how to apply the the one you sent? >>>> >>>> Thanks, >>>> -Chris. >>>> >>> Hi Chris, >>> >>> patch -p0< mypatch under the jdk directory will do the trick. >>> >>> I will try to find a solaris to test my patch. >>> >> Here is Charles' latest patch in webrev form [1]. >> >> Regards, Neil >> >> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/ >> > Thanks Neil. > > Hi Chris, > > With the latest patch, the warning of Inet4AddressImpl seems gone :-P (I > have reordered the statement and declaration). They used to happen on > the solaris indeed. Do you see other warnings now? Thank you Charles, and Neil. I ran some builds and tests and all looks good to me. Thanks for fixing the warnings, I know they were not caused by your changes. Just noticed that we haven't just filed a bug for this, so I just created: CR 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Neil, I assume you will push this? -Chris. From kumar.x.srinivasan at oracle.com Wed Nov 16 13:07:55 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 16 Nov 2011 21:07:55 +0000 Subject: hg: jdk8/tl/jdk: 7112160: jdk8 javadoc failure in jdk/make/docs javadoc: error - java.lang.OutOfMemoryError Message-ID: <20111116210812.E9E9F47393@hg.openjdk.java.net> Changeset: 398442b00b2b Author: ksrini Date: 2011-11-16 12:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/398442b00b2b 7112160: jdk8 javadoc failure in jdk/make/docs javadoc: error - java.lang.OutOfMemoryError Reviewed-by: ohair, katleman ! make/docs/Makefile From littlee at linux.vnet.ibm.com Wed Nov 16 18:10:50 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Thu, 17 Nov 2011 10:10:50 +0800 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC423AE.9090801@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> <4EC423AE.9090801@oracle.com> Message-ID: <4EC46D2A.50103@linux.vnet.ibm.com> On 11/17/2011 04:57 AM, Chris Hegarty wrote: > On 11/16/11 01:48 AM, Charles Lee wrote: >> On 11/16/2011 01:00 AM, Neil Richards wrote: >>> On Tue, 2011-11-15 at 19:37 +0800, Charles Lee wrote: >>>> On 11/15/2011 07:10 PM, Chris Hegarty wrote: >>>>> On 11/15/11 06:57 AM, Charles Lee wrote: >>>>>> .... >>>>>> Sigh. Chris, I still fail to see those warnings, even if I do a very >>>>>> clean remove of my build directory and rebuild the whole jdk .... >>>>> The warning are being generated on Solaris when using the Sun >>>>> compilers ( both full and incremental builds ). >>>>> >>>>>> Here is the new (big) patch(attached) according to the comments >>>>>> from you >>>>>> and Mike. Thank you guys :-) >>>>> I can't apply the patch you sent. Is it possible to generate a >>>>> webrev, >>>>> another patch, or let me know how to apply the the one you sent? >>>>> >>>>> Thanks, >>>>> -Chris. >>>>> >>>> Hi Chris, >>>> >>>> patch -p0< mypatch under the jdk directory will do the trick. >>>> >>>> I will try to find a solaris to test my patch. >>>> >>> Here is Charles' latest patch in webrev form [1]. >>> >>> Regards, Neil >>> >>> [1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.02/ >>> >> Thanks Neil. >> >> Hi Chris, >> >> With the latest patch, the warning of Inet4AddressImpl seems gone :-P (I >> have reordered the statement and declaration). They used to happen on >> the solaris indeed. Do you see other warnings now? > > Thank you Charles, and Neil. > > I ran some builds and tests and all looks good to me. Thanks for > fixing the warnings, I know they were not caused by your changes. > > Just noticed that we haven't just filed a bug for this, so I just > created: > CR 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo > > Neil, > I assume you will push this? > > -Chris. > That's great. Thanks Chris. Thanks all. -- Yours Charles From mandy.chung at oracle.com Thu Nov 17 15:48:10 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 17 Nov 2011 23:48:10 +0000 Subject: hg: jdk8/tl/jdk: 7067691: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Message-ID: <20111117234828.14214473BD@hg.openjdk.java.net> Changeset: 3cd7dcf4a302 Author: mchung Date: 2011-11-17 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cd7dcf4a302 7067691: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Reviewed-by: alanb, mchung Contributed-by: gary.adams at oracle.com ! test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java ! test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java From weijun.wang at oracle.com Fri Nov 18 00:14:34 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 18 Nov 2011 08:14:34 +0000 Subject: hg: jdk8/tl/jdk: 7077172: KerberosTime does not take into account system clock adjustement Message-ID: <20111118081452.A6274473CF@hg.openjdk.java.net> Changeset: 5bfff9616b86 Author: weijun Date: 2011-11-18 16:13 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bfff9616b86 7077172: KerberosTime does not take into account system clock adjustement Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/KerberosTime.java From chris.hegarty at oracle.com Fri Nov 18 02:38:49 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 18 Nov 2011 10:38:49 +0000 Subject: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: References: Message-ID: <4EC635B9.3030007@oracle.com> Kris, This issue would be more appropriate on the net-dev or nio-dev mailing lists. So, I'll cross post it and bcc off jdk8-dev. Thanks, -Chris. On 11/18/11 08:22 AM, ???? wrote: > Hi all, > > I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor: > > In OpenJDK 6, 7 and 8, sun.nio.ch.SocketAdaptor is used to adapt a SocketChannelImpl to a java.net.Socket. > > A comment in the constructor of SocketAdaptor says "super will create a useless impl", but it actually doesn't have to. AFAICT the SocksSocketImpl instance created here really isn't used at all in SocketAdaptor, unless someone invokes non-public methods on java.net.Socket via reflection. > > The attached patch is to get rid of creation of the useless SocksSocketImpl. > > At a glance, creating a useless SocksSocketImpl for every SocketAdaptor seems innocent. But that's not the case when the allocation rate/heap memory pressure is high. SocksSocketImpl has a finalizer (inherited from PlainSocketImpl), and when: > * old generation is large > * there are a lot of ready-to-die SocksSocketImpl instances > these instances can be queued up in the finalizer queue, which increases the heap pressure. > > In one of our Hadoop NameNode nodes in production, excessive SocksSocketImpl instances had been causing frequent CMS collections + long reference processing pause. Using this patch helps side-steping the problem. > > I don't have a bug ID for this yet. Could anyone kindly open a bug for this? > > Regards, > Kris Mok > Software Engineer, Taobao (http://www.taobao.com) > > ________________________________ > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? From chris.hegarty at oracle.com Fri Nov 18 02:44:09 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 18 Nov 2011 10:44:09 +0000 Subject: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor Message-ID: <4EC636F9.9020807@oracle.com> -------- Original Message -------- Subject: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor Date: Fri, 18 Nov 2011 16:38:28 +0800 From: Krystal Mok To: ???? CC: jdk8-dev at openjdk.java.net Oops, looks like my company email stripped the attachment. Here's that patch again: diff -r 00e2c88e2234 src/share/classes/sun/nio/ch/SocketAdaptor.java --- a/src/share/classes/sun/nio/ch/SocketAdaptor.java Thu Nov 17 10:46:02 2011 -0800 +++ b/src/share/classes/sun/nio/ch/SocketAdaptor.java Fri Nov 18 15:37:20 2011 +0800 @@ -57,13 +57,17 @@ // Timeout "option" value for reads private volatile int timeout = 0; - // ## super will create a useless impl - private SocketAdaptor(SocketChannelImpl sc) { + private SocketAdaptor(SocketChannelImpl sc) throws SocketException { + super((SocketImpl) null); this.sc = sc; } public static Socket create(SocketChannelImpl sc) { - return new SocketAdaptor(sc); + try { + return new SocketAdaptor(sc); + } catch (SocketException e) { + throw new RuntimeException("should not reach here"); + } } public SocketChannel getChannel() { - Kris 2011/11/18 ???? > Hi all, > > I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor: > > In OpenJDK 6, 7 and 8, sun.nio.ch.SocketAdaptor is used to adapt a > SocketChannelImpl to a java.net.Socket. > > A comment in the constructor of SocketAdaptor says "super will create a > useless impl", but it actually doesn't have to. AFAICT the SocksSocketImpl > instance created here really isn't used at all in SocketAdaptor, unless > someone invokes non-public methods on java.net.Socket via reflection. > > The attached patch is to get rid of creation of the useless > SocksSocketImpl. > > At a glance, creating a useless SocksSocketImpl for every SocketAdaptor > seems innocent. But that's not the case when the allocation rate/heap > memory pressure is high. SocksSocketImpl has a finalizer (inherited from > PlainSocketImpl), and when: > * old generation is large > * there are a lot of ready-to-die SocksSocketImpl instances > these instances can be queued up in the finalizer queue, which increases > the heap pressure. > > In one of our Hadoop NameNode nodes in production, excessive > SocksSocketImpl instances had been causing frequent CMS collections + long > reference processing pause. Using this patch helps side-steping the problem. > > I don't have a bug ID for this yet. Could anyone kindly open a bug for > this? > > Regards, > Kris Mok > Software Engineer, Taobao (http://www.taobao.com) > > ________________________________ > This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it > immediately and do not copy it or use it for any purpose or disclose its > contents to any other person. Thank you. > > > ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? > From chris.hegarty at oracle.com Fri Nov 18 02:57:21 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 18 Nov 2011 10:57:21 +0000 Subject: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: <4EC636F9.9020807@oracle.com> References: <4EC636F9.9020807@oracle.com> Message-ID: <4EC63A11.9050302@oracle.com> Hi Kris, I think this change should be fine, but I would like Alan to comment also. Thanks, -Chris. On 11/18/11 10:44 AM, Chris Hegarty wrote: > > > -------- Original Message -------- > Subject: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's > constructor > Date: Fri, 18 Nov 2011 16:38:28 +0800 > From: Krystal Mok > To: ???? > CC: jdk8-dev at openjdk.java.net > > Oops, looks like my company email stripped the attachment. > Here's that patch again: > > diff -r 00e2c88e2234 src/share/classes/sun/nio/ch/SocketAdaptor.java > --- a/src/share/classes/sun/nio/ch/SocketAdaptor.java Thu Nov 17 10:46:02 > 2011 -0800 > +++ b/src/share/classes/sun/nio/ch/SocketAdaptor.java Fri Nov 18 15:37:20 > 2011 +0800 > @@ -57,13 +57,17 @@ > // Timeout "option" value for reads > private volatile int timeout = 0; > > - // ## super will create a useless impl > - private SocketAdaptor(SocketChannelImpl sc) { > + private SocketAdaptor(SocketChannelImpl sc) throws SocketException { > + super((SocketImpl) null); > this.sc = sc; > } > > public static Socket create(SocketChannelImpl sc) { > - return new SocketAdaptor(sc); > + try { > + return new SocketAdaptor(sc); > + } catch (SocketException e) { > + throw new RuntimeException("should not reach here"); > + } > } > > public SocketChannel getChannel() { > > > - Kris > > 2011/11/18 ???? > >> Hi all, >> >> I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor: >> >> In OpenJDK 6, 7 and 8, sun.nio.ch.SocketAdaptor is used to adapt a >> SocketChannelImpl to a java.net.Socket. >> >> A comment in the constructor of SocketAdaptor says "super will create a >> useless impl", but it actually doesn't have to. AFAICT the SocksSocketImpl >> instance created here really isn't used at all in SocketAdaptor, unless >> someone invokes non-public methods on java.net.Socket via reflection. >> >> The attached patch is to get rid of creation of the useless >> SocksSocketImpl. >> >> At a glance, creating a useless SocksSocketImpl for every SocketAdaptor >> seems innocent. But that's not the case when the allocation rate/heap >> memory pressure is high. SocksSocketImpl has a finalizer (inherited from >> PlainSocketImpl), and when: >> * old generation is large >> * there are a lot of ready-to-die SocksSocketImpl instances >> these instances can be queued up in the finalizer queue, which increases >> the heap pressure. >> >> In one of our Hadoop NameNode nodes in production, excessive >> SocksSocketImpl instances had been causing frequent CMS collections + long >> reference processing pause. Using this patch helps side-steping the problem. >> >> I don't have a bug ID for this yet. Could anyone kindly open a bug for >> this? >> >> Regards, >> Kris Mok >> Software Engineer, Taobao (http://www.taobao.com) >> >> ________________________________ >> This email (including any attachments) is confidential and may be legally >> privileged. If you received this email in error, please delete it >> immediately and do not copy it or use it for any purpose or disclose its >> contents to any other person. Thank you. >> >> >> ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? >> From Alan.Bateman at oracle.com Fri Nov 18 03:38:47 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 18 Nov 2011 11:38:47 +0000 Subject: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: <4EC63A11.9050302@oracle.com> References: <4EC636F9.9020807@oracle.com> <4EC63A11.9050302@oracle.com> Message-ID: <4EC643C7.9040909@oracle.com> On 18/11/2011 10:57, Chris Hegarty wrote: > Hi Kris, > > I think this change should be fine, but I would like Alan to comment also. > I'm not around this week but will look at it next week. One initial comment is that the need to use the socket adapter went away in jdk7. Newer code using SocketChannel can invoke SocketChannel's bind or setOption methods directly. -Alan From lana.steuck at oracle.com Fri Nov 18 14:37:19 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:37:19 +0000 Subject: hg: jdk8/tl: 7 new changesets Message-ID: <20111118223719.C1C08473E0@hg.openjdk.java.net> Changeset: 8da26d5c32a7 Author: katleman Date: 2011-11-10 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8da26d5c32a7 Added tag jdk8-b13 for changeset 26fb81a1e9ce ! .hgtags Changeset: a62a0f35eb9c Author: asaha Date: 2011-06-27 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a62a0f35eb9c Merge Changeset: f9b3e6b2aa2c Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f9b3e6b2aa2c Merge Changeset: ea2ab83ce564 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ea2ab83ce564 Merge Changeset: 8f525559ae73 Author: asaha Date: 2011-11-07 21:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8f525559ae73 Merge Changeset: 23aa7f2c80a2 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/23aa7f2c80a2 Merge Changeset: a4f28069d44a Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a4f28069d44a Added tag jdk8-b14 for changeset 23aa7f2c80a2 ! .hgtags From lana.steuck at oracle.com Fri Nov 18 14:37:31 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:37:31 +0000 Subject: hg: jdk8/tl/jaxp: 7 new changesets Message-ID: <20111118223731.9AF06473E1@hg.openjdk.java.net> Changeset: e7172d80a8f4 Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e7172d80a8f4 Added tag jdk8-b13 for changeset bcc739229f63 ! .hgtags Changeset: 7adf14d6060c Author: asaha Date: 2011-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7adf14d6060c Merge Changeset: d239aa024b6e Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d239aa024b6e Merge Changeset: eca33f89c823 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/eca33f89c823 Merge Changeset: 0ed9ae36ee2a Author: asaha Date: 2011-11-07 21:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0ed9ae36ee2a Merge Changeset: 9d0c9d638757 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9d0c9d638757 Merge Changeset: 804f666d6d44 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/804f666d6d44 Added tag jdk8-b14 for changeset 9d0c9d638757 ! .hgtags From lana.steuck at oracle.com Fri Nov 18 14:37:36 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:37:36 +0000 Subject: hg: jdk8/tl/jaxws: 9 new changesets Message-ID: <20111118223737.3E29E473E2@hg.openjdk.java.net> Changeset: f502a343a92e Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f502a343a92e Added tag jdk8-b13 for changeset adf2a6b5fde1 ! .hgtags Changeset: 75a652e72489 Author: asaha Date: 2011-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/75a652e72489 Merge Changeset: b058cae6fd3b Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b058cae6fd3b Merge Changeset: 61c046c6895a Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/61c046c6895a Merge Changeset: 9e82b46cd4fa Author: asaha Date: 2011-07-25 11:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9e82b46cd4fa 7046794: Configurable behavior for server-side stacktraces Reviewed-by: ramap ! jaxws.properties Changeset: c78fccb01d4e Author: asaha Date: 2011-11-07 21:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c78fccb01d4e Merge Changeset: cae6db74d6af Author: asaha Date: 2011-11-10 13:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/cae6db74d6af 7110676: Update jaf source download url for jaxws Reviewed-by: ramap ! jaxws.properties Changeset: 54c4bf4b83ec Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/54c4bf4b83ec Merge Changeset: c9ab96ff23d5 Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c9ab96ff23d5 Added tag jdk8-b14 for changeset 54c4bf4b83ec ! .hgtags From lana.steuck at oracle.com Fri Nov 18 14:37:26 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:37:26 +0000 Subject: hg: jdk8/tl/corba: 9 new changesets Message-ID: <20111118223744.5C049473E3@hg.openjdk.java.net> Changeset: 6f601a737e0f Author: katleman Date: 2011-11-10 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6f601a737e0f Added tag jdk8-b13 for changeset 5b9d9b839d3d ! .hgtags Changeset: d84682019b5f Author: asaha Date: 2011-06-27 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d84682019b5f Merge Changeset: 9c20c1e7cdd9 Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9c20c1e7cdd9 Merge Changeset: cb5aec0570a5 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/cb5aec0570a5 Merge Changeset: 21369018a679 Author: mbankal Date: 2011-08-09 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/21369018a679 7055902: Oracle Java IIOP Deserialization Type Confusion Remote Code Execution Vulnerability Reviewed-by: coffeys ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java Changeset: 058c18d237a9 Author: asaha Date: 2011-11-07 21:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/058c18d237a9 Merge Changeset: e59c47de1ad8 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e59c47de1ad8 Merge Changeset: 99925e8d1b86 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/99925e8d1b86 Added tag jdk8-b14 for changeset e59c47de1ad8 ! .hgtags Changeset: 7da69e7175a7 Author: lana Date: 2011-11-18 11:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7da69e7175a7 Merge From lana.steuck at oracle.com Fri Nov 18 14:37:17 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:37:17 +0000 Subject: hg: jdk8/tl/hotspot: 8 new changesets Message-ID: <20111118223755.A0417473E4@hg.openjdk.java.net> Changeset: 5c8c7bef6403 Author: jcoomes Date: 2011-10-28 18:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c8c7bef6403 7106092: Bump the hs23 build number to 05 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: d5c4c73aa855 Author: dholmes Date: 2011-10-27 18:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d5c4c73aa855 7104173: sun/tools tests fail with debug build after 7012206 Summary: Disable PrintVMOptions in embedded debug builds so tests are unaffected by extra output Reviewed-by: twisti, coleenp, phh, fparain, dsamersoff ! src/share/vm/runtime/globals.hpp Changeset: 6da94c5a6746 Author: dholmes Date: 2011-10-30 18:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6da94c5a6746 Merge Changeset: 95009f678859 Author: brutisso Date: 2011-11-01 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/95009f678859 7106766: Move the precompiled header from the src/share/vm directory Summary: Moved precompiled.hpp to src/share/vm/precompiled Reviewed-by: coleenp, dholmes Contributed-by: rbackman ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/gcc.make ! make/windows/makefiles/vm.make - src/share/vm/precompiled.hpp + src/share/vm/precompiled/precompiled.hpp Changeset: 3e609627e780 Author: jcoomes Date: 2011-11-04 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3e609627e780 Merge - src/share/vm/precompiled.hpp Changeset: b92ca8e229d2 Author: jcoomes Date: 2011-11-04 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b92ca8e229d2 Added tag hs23-b05 for changeset 3e609627e780 ! .hgtags Changeset: 088d09a130ff Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/088d09a130ff Added tag jdk8-b13 for changeset b92ca8e229d2 ! .hgtags Changeset: 883328bfc472 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/883328bfc472 Added tag jdk8-b14 for changeset 088d09a130ff ! .hgtags From lana.steuck at oracle.com Fri Nov 18 14:37:48 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:37:48 +0000 Subject: hg: jdk8/tl/langtools: 9 new changesets Message-ID: <20111118223811.BD4E8473E5@hg.openjdk.java.net> Changeset: 65444e7998e3 Author: katleman Date: 2011-11-10 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/65444e7998e3 Added tag jdk8-b13 for changeset ae25163501bc ! .hgtags Changeset: b7003a6a530b Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7003a6a530b Merge Changeset: 15ea1c763273 Author: asaha Date: 2011-06-27 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/15ea1c763273 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: c79cf0f04be6 Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c79cf0f04be6 Merge Changeset: 34e175c1fabc Author: asaha Date: 2011-07-19 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/34e175c1fabc Merge Changeset: c4478931e22d Author: asaha Date: 2011-11-07 21:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4478931e22d Merge Changeset: 58f1325d72b2 Author: lana Date: 2011-11-14 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58f1325d72b2 Merge Changeset: 16906df5bffc Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/16906df5bffc Added tag jdk8-b14 for changeset 58f1325d72b2 ! .hgtags Changeset: f07d6f55d39a Author: lana Date: 2011-11-18 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f07d6f55d39a Merge From lana.steuck at oracle.com Fri Nov 18 14:39:47 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Nov 2011 22:39:47 +0000 Subject: hg: jdk8/tl/jdk: 50 new changesets Message-ID: <20111118224756.C723B473E6@hg.openjdk.java.net> Changeset: bfd720647db2 Author: yhuang Date: 2011-10-31 20:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfd720647db2 7077119: remove past transition dates from CurrencyData.properties file Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/CurrencyTest.java ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt Changeset: cfc6fd491b97 Author: yhuang Date: 2011-10-31 21:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfc6fd491b97 6755060: Collator.compare() does not compare correctly for the Thai locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/CollationData_th.java + test/sun/text/resources/Collator/Bug6755060.java Changeset: 0549410acf26 Author: yhuang Date: 2011-10-31 21:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0549410acf26 Merge Changeset: f3227efde13d Author: yhuang Date: 2011-10-31 21:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3227efde13d 7101495: In Latvia first day of week is Monday Reviewed-by: naoto, peytoia ! src/share/classes/sun/util/resources/CalendarData_lv.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: ab837acc60fb Author: yhuang Date: 2011-10-31 21:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ab837acc60fb Merge Changeset: 631ee738378a Author: mfang Date: 2011-11-03 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/631ee738378a Merge Changeset: 94e5604022fa Author: ngmr Date: 2011-09-15 19:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94e5604022fa 6988099: jvmti demos missing Publisher (COMPANY resource) in dlls/exes on windows Summary: Add creation/linking of resource data to link step for demos on Windows Reviewed-by: dcubed, zgu, ngmr, ohair Contributed-by: Sean Chou ! make/common/Demo.gmk Changeset: 5791714b9472 Author: ohair Date: 2011-11-04 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5791714b9472 Merge Changeset: 4cb2e8679b27 Author: katleman Date: 2011-11-09 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cb2e8679b27 Merge Changeset: 52bd7fc8fcb0 Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52bd7fc8fcb0 Added tag jdk8-b13 for changeset 4cb2e8679b27 ! .hgtags Changeset: 9de1dbf8c9be Author: lana Date: 2011-10-26 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9de1dbf8c9be Merge - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/tools/jar/JarImageSource.java Changeset: 76defa20906a Author: ngmr Date: 2011-09-23 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76defa20906a 7105640: Unix printing does not check the result of exec'd lpr/lp command Summary: Add checking, exception for spool process failure Reviewed-by: prr, jgodinez Contributed-by: Neil Richards ! src/share/classes/sun/print/PSPrinterJob.java ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: 4544585a3cea Author: lana Date: 2011-11-05 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4544585a3cea Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: aa3f5117c485 Author: rupashka Date: 2011-10-17 15:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aa3f5117c485 7099251: javax.swing.text.html.HTMLDocument.insertAfterStart(null, something) throws NPE Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/javax/swing/text/html/HTMLDocument.java Changeset: 4f74e3fdf86b Author: rupashka Date: 2011-10-17 16:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f74e3fdf86b 7100004: javax.swing.JTable.setAutoCreateRowSorter(boolean autoCreateRowSorter) should mention default value Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/javax/swing/JTable.java Changeset: f1dbc62c7c6d Author: rupashka Date: 2011-10-17 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1dbc62c7c6d 7077293: javax/swing/JComponent/4337267/bug4337267.java failed on windows 2003 Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: a2f5d7049258 Author: dbuck Date: 2011-10-17 19:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2f5d7049258 6887286: StackOverflowError at sun.awt.image.ImageWatched$WeakLink.isWatcher Summary: Fixed OffScreenImageSource to call imageComplete() with SINGLEFAMEDONE, not STATICIMAGEDONE. This fixed memory leak (that caused SOFE when we use recursion to iterate over linked list). Reviewed-by: bae ! src/share/classes/sun/awt/image/OffScreenImageSource.java Changeset: 7636a62aba7e Author: anthony Date: 2011-11-01 18:01 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7636a62aba7e 7104625: sun.awt.X11.XEvent is creating 600 MB of char[] for no good reason Summary: Wrap logging calls with if(){} statements Reviewed-by: anthony, son Contributed-by: Federico Tello Gentile ! src/solaris/classes/sun/awt/X11/XComponentPeer.java Changeset: ac55f169fadd Author: anthony Date: 2011-11-01 18:03 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac55f169fadd 7105529: XAWT: Optimize getFieldsAsString() methods generated by WrapperGenerator Summary: Replace string concatenation with StringBuilder.append() Reviewed-by: anthony, son Contributed-by: Federico Tello Gentile ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java Changeset: 41610a897379 Author: rupashka Date: 2011-11-02 14:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41610a897379 6624077: Regression test fails: closed/javax/swing/ToolTipManager/6256140/bug6256140.java Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/ToolTipManager/Test6256140.java Changeset: 8068f1584715 Author: mrkam Date: 2011-11-02 17:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8068f1584715 7074853: TransparentRuler demos Readme should mention the correct jar file name Reviewed-by: rupashka ! src/share/demo/jfc/TransparentRuler/README.txt Changeset: 323f6d046cc9 Author: rupashka Date: 2011-11-02 23:53 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/323f6d046cc9 7049024: DnD fails with JTextArea and JTextField Reviewed-by: rupashka Contributed-by: Sean Chou ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/JTextArea/7049024/bug7049024.java Changeset: 7c29751a9331 Author: rupashka Date: 2011-11-03 14:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c29751a9331 6955919: Intermittent ClassCastException in bug4492274 test Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JEditorPane/4492274/bug4492274.java + test/javax/swing/JEditorPane/4492274/test.html Changeset: 1c0624d9a2b6 Author: ngmr Date: 2011-10-13 13:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c0624d9a2b6 7107957: AWT: Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h and fcntl.h Reviewed-by: anthony, ngmr Contributed-by: Charles Lee ! src/solaris/native/sun/awt/splashscreen/splashscreen_config.h Changeset: adb31ff942ef Author: rupashka Date: 2011-11-07 16:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adb31ff942ef 7080203: JTree.getSelectionPaths() now returns empty array instead of null Reviewed-by: malenkov ! src/share/classes/javax/swing/JTree.java Changeset: d219e0b11327 Author: lana Date: 2011-11-07 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d219e0b11327 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/classes/sun/tools/jar/JarImageSource.java - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: f8a3dff76b48 Author: rupashka Date: 2011-11-08 14:36 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8a3dff76b48 7107585: Test incorrect calculate position of object on frame Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JSlider/6348946/bug6348946.java Changeset: af4fb33fca29 Author: lana Date: 2011-11-08 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af4fb33fca29 Merge Changeset: 0bb498332894 Author: lana Date: 2011-11-08 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bb498332894 Merge Changeset: 51db54a3b953 Author: lana Date: 2011-11-14 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51db54a3b953 Merge Changeset: 3b2128c89361 Author: alanb Date: 2011-06-15 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b2128c89361 7000600: InputStream.skip() makes sensitive data accessible to malicious code Reviewed-by: hawtin, chegar ! src/share/classes/java/io/InputStream.java Changeset: 06e0d91548b3 Author: anthony Date: 2011-06-21 20:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06e0d91548b3 7022113: Security icon can be moved behind the window using the com.sun.SecurityWarning.setPosition() method Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: d32b75c73389 Author: alanb Date: 2011-06-27 20:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d32b75c73389 7059259: (process) ProcessBuilder.start permission check should be improved when redirecting output to append Reviewed-by: hawtin ! src/windows/classes/java/lang/ProcessImpl.java Changeset: 446b13a08aca Author: asaha Date: 2011-06-27 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/446b13a08aca Merge Changeset: 4fdd1a44e846 Author: asaha Date: 2011-06-27 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4fdd1a44e846 Merge Changeset: 3e42f7893861 Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e42f7893861 Merge Changeset: f578448792b9 Author: ksrini Date: 2011-07-15 13:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f578448792b9 7057857: SIGSEGV [libunpack.so] store_Utf8_char(signed char*, unsigned short) in java.util.jar.pack200 Reviewed-by: jrose, asaha, hawtin ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.h Changeset: 4b20375fe623 Author: asaha Date: 2011-07-19 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b20375fe623 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: bc9c70e57f62 Author: asaha Date: 2011-07-20 09:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc9c70e57f62 7032417: Fix for 6981922 does not address multiple VM case Reviewed-by: michaelm ! src/share/classes/sun/net/ResourceManager.java Changeset: a7177942302f Author: asaha Date: 2011-07-20 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7177942302f 7023640: calculation for malloc size in TransformHelper.c could overflow an integer Reviewed-by: flar ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: 6c76f2a49061 Author: denis Date: 2011-07-22 21:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c76f2a49061 7019773: AWTKeyStroke.ctor is a mutable static Reviewed-by: art ! src/share/classes/java/awt/AWTKeyStroke.java Changeset: b25558c39ffc Author: smarks Date: 2011-08-30 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b25558c39ffc 7077466: fix for RMI DGC Reviewed-by: valeriep ! src/share/classes/sun/rmi/server/UnicastServerRef.java Changeset: efd8035f3d14 Author: smarks Date: 2011-08-30 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efd8035f3d14 7083012: fix for RMI Registry Reviewed-by: jdn, valeriep ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java Changeset: 27bda11f1330 Author: smarks Date: 2011-09-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27bda11f1330 7092186: adjust package access in rmiregistry Reviewed-by: asaha, coffeys ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! test/sun/tools/jstatd/jstatdExternalRegistry.sh Changeset: 42eb725f739c Author: xuelei Date: 2011-09-29 17:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42eb725f739c 7064341: jsse/runtime security problem Reviewed-by: wetmore ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/sun/security/ssl/AppOutputStream.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargeBufs.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java Changeset: 53a16cf28db3 Author: xuelei Date: 2011-09-30 18:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53a16cf28db3 7096936: issue in jsse/runtime 7096937: TEST: com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java need modification as a result of TLS fix Reviewed-by: wetmore, jdn, xuelei ! src/share/classes/com/sun/net/ssl/HttpsURLConnection.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java Changeset: 27a8f4fc555a Author: asaha Date: 2011-11-14 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27a8f4fc555a Merge ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java ! test/sun/tools/jstatd/jstatdExternalRegistry.sh Changeset: 99632935785e Author: lana Date: 2011-11-14 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99632935785e Merge Changeset: 00e2c88e2234 Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00e2c88e2234 Added tag jdk8-b14 for changeset 99632935785e ! .hgtags Changeset: cd37d8066437 Author: lana Date: 2011-11-18 11:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd37d8066437 Merge ! src/share/classes/sun/security/ssl/SSLSocketImpl.java From Alan.Bateman at oracle.com Sat Nov 19 11:44:56 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 19 Nov 2011 19:44:56 +0000 Subject: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: <4EC63A11.9050302@oracle.com> References: <4EC636F9.9020807@oracle.com> <4EC63A11.9050302@oracle.com> Message-ID: <4EC80738.2000609@oracle.com> On 18/11/2011 10:57, Chris Hegarty wrote: > Hi Kris, > > I think this change should be fine, but I would like Alan to comment also. > I looked at it in more detail and I think it should okay. Will you sponsor it? My only comment on the change is the catching of SocketException causes a RuntimeException to be thrown but that is inconsistent with other areas of this code where AssertionError or InternalError is thrown. -Alan From alan.bateman at oracle.com Sat Nov 19 12:09:45 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 19 Nov 2011 20:09:45 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20111119201024.60B18473FC@hg.openjdk.java.net> Changeset: c98235762b30 Author: alanb Date: 2011-11-19 19:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c98235762b30 6818464: TEST_BUG: java/util/Timer/KillThread.java failing intermittently Reviewed-by: dholmes, alanb, forax Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/KillThread.java Changeset: 8be37eae9598 Author: alanb Date: 2011-11-19 19:59 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8be37eae9598 6731620: TEST_BUG: java/util/Timer/Args.java is too optimistic about the execution time of System.out.printf Reviewed-by: dholmes, forax Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/Args.java Changeset: 450c17e4808d Author: alanb Date: 2011-11-19 20:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/450c17e4808d 6860309: TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/StreamsSurviveDestroy.java Reviewed-by: alanb, dholmes, forax Contributed-by: gary.adams at oracle.com ! test/java/lang/Runtime/exec/StreamsSurviveDestroy.java From jim.holmlund at sun.com Sat Nov 19 16:00:54 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Sun, 20 Nov 2011 00:00:54 +0000 Subject: hg: jdk8/tl/langtools: 7110611: compiler message file broken for javac -fullversion Message-ID: <20111120000059.A5396473FE@hg.openjdk.java.net> Changeset: 07599bd780ca Author: jjh Date: 2011-11-19 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/07599bd780ca 7110611: compiler message file broken for javac -fullversion Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java From chris.hegarty at oracle.com Mon Nov 21 02:02:37 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 21 Nov 2011 10:02:37 +0000 Subject: Fwd: Re: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: <4EC80738.2000609@oracle.com> References: <4EC636F9.9020807@oracle.com> <4EC63A11.9050302@oracle.com> <4EC80738.2000609@oracle.com> Message-ID: <4ECA21BD.2070503@oracle.com> On 19/11/2011 19:44, Alan Bateman wrote: > On 18/11/2011 10:57, Chris Hegarty wrote: >> Hi Kris, >> >> I think this change should be fine, but I would like Alan to comment also. >> > I looked at it in more detail and I think it should okay. Will you > sponsor it? My only comment on the change is the catching of > SocketException causes a RuntimeException to be thrown but that is > inconsistent with other areas of this code where AssertionError or > InternalError is thrown. Yes, I can sponsor this change. And yes, I agree InternalError would be better. -Chris. > > -Alan From alan.bateman at oracle.com Mon Nov 21 04:54:18 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 21 Nov 2011 12:54:18 +0000 Subject: hg: jdk8/tl/jdk: 7084033: TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermittently Message-ID: <20111121125440.9B5784740C@hg.openjdk.java.net> Changeset: 184578f3e8b9 Author: alanb Date: 2011-11-21 12:51 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184578f3e8b9 7084033: TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermittently Reviewed-by: forax, chegar, dholmes Contributed-by: gary.adams at oracle.com ! test/java/lang/ThreadGroup/Stop.java From alan.bateman at oracle.com Mon Nov 21 05:00:41 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 21 Nov 2011 13:00:41 +0000 Subject: hg: jdk8/tl/jdk: 7114125: TEST_BUG: java/util/Timer/KillThread.java should use volatile cross thread variable declaration Message-ID: <20111121130051.0B6B34740D@hg.openjdk.java.net> Changeset: 2db942c7eb9c Author: alanb Date: 2011-11-21 12:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2db942c7eb9c 7114125: TEST_BUG: java/util/Timer/KillThread.java should use volatile cross thread variable declaration Reviewed-by: dholmes, alanb Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/KillThread.java From zhouyx at linux.vnet.ibm.com Tue Nov 22 00:40:24 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Tue, 22 Nov 2011 16:40:24 +0800 Subject: A behavior difference about reachable test for address zero Message-ID: Hi all, I found a behavior difference when running the testcase PingZero on linux and windows. On Linux, it prints "reachable" while on windows "unreachable", which is the same with the result of running "ping 0.0.0.0" on these two platforms. Is it a bug or intended? PingZero.java : ////////////////////////////////////////////////////////////// import java.net.*; class PingZero { public static void main(String args[]) { try { InetAddress inetAddress = InetAddress.getByAddress(new byte[] { 0, 0, 0, 0 }); boolean b = inetAddress.isReachable((int) (1.0 * 3000)); if (b) { System.out.println(" 0.0.0.0 is reachable ! "); } else { System.out.println(" 0.0.0.0 is not reachable ! "); } } catch (Exception e) { e.printStackTrace(); } } } ////////////////////////////////////////////////////////////// -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111122/11d2df6f/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: PingZero.java Type: application/octet-stream Size: 563 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111122/11d2df6f/PingZero.java From neil.richards at ngmr.net Tue Nov 22 01:07:40 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Tue, 22 Nov 2011 09:07:40 +0000 Subject: hg: jdk8/tl/jdk: 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Message-ID: <20111122090802.E28404741F@hg.openjdk.java.net> Changeset: 81987765cb81 Author: ngmr Date: 2011-11-11 14:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Reviewed-by: chegar, alanb, mduigou, ngmr Contributed-by: Charles Lee ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h From neil.richards at ngmr.net Tue Nov 22 01:27:36 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Tue, 22 Nov 2011 09:27:36 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4EC423AE.9090801@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> <4EC423AE.9090801@oracle.com> Message-ID: <1321954056.5911.79.camel@chalkhill> On Wed, 2011-11-16 at 20:57 +0000, Chris Hegarty wrote: > Thank you Charles, and Neil. > > I ran some builds and tests and all looks good to me. Thanks for fixing > the warnings, I know they were not caused by your changes. > > Just noticed that we haven't just filed a bug for this, so I just created: > CR 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo > > Neil, > I assume you will push this? > > -Chris. > Hi Chris, Thank you for creating the bug id for this issue. I've now pushed the change [1]. However, I've just realised I've foolishly pushed a previous version of the change, and not the final agreed version. (aargh!) Could you please advise me how i might best rectify this, and furnish me with another bug id if I need one for this purpose? Humble apologies for this :-( Regards, Neil [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From chris.hegarty at oracle.com Tue Nov 22 01:38:12 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 22 Nov 2011 09:38:12 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <1321954056.5911.79.camel@chalkhill> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> <4EC423AE.9090801@oracle.com> <1321954056.5911.79.camel@chalkhill> Message-ID: <4ECB6D84.3010402@oracle.com> On 11/22/11 09:27 AM, Neil Richards wrote: > .... > Hi Chris, > Thank you for creating the bug id for this issue. > > I've now pushed the change [1]. > > However, I've just realised I've foolishly pushed a previous version of > the change, and not the final agreed version. (aargh!) No problem. This happens from time to time. > Could you please advise me how i might best rectify this, and furnish me > with another bug id if I need one for this purpose? Let me know the details synopsis/descriptions/etc and I'll file a new CR. I'm guessing its just some cleanup/style issues, right? -Chris. > > Humble apologies for this :-( > > Regards, Neil > > [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 > From neil.richards at ngmr.net Tue Nov 22 02:00:53 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Tue, 22 Nov 2011 10:00:53 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4ECB6D84.3010402@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> <4EC423AE.9090801@oracle.com> <1321954056.5911.79.camel@chalkhill> <4ECB6D84.3010402@oracle.com> Message-ID: <1321956053.6943.6.camel@chalkhill> On Tue, 2011-11-22 at 09:38 +0000, Chris Hegarty wrote: > Let me know the details synopsis/descriptions/etc and I'll file a new > CR. I'm guessing its just some cleanup/style issues, right? > > -Chris. I've uploaded a webrev with the gap between the two [1]. The differences are the use of memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN). Thanks for helping me out with this, Regards, Neil [1] http://cr.openjdk.java.net/~ngmr/ojdk-229.1/webrev.00/ -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From chris.hegarty at oracle.com Tue Nov 22 02:07:43 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 22 Nov 2011 10:07:43 +0000 Subject: code review request : JDK 7 backport: 7102369 RedirectLimit & Redirect307Test fail intermittently In-Reply-To: <4ECAB01A.5090503@oracle.com> References: <4ECAB01A.5090503@oracle.com> Message-ID: <4ECB746F.6030308@oracle.com> On 11/21/11 08:10 PM, Rob McKenna wrote: > webrev : http://cr.openjdk.java.net/~robm/7095949/webrev.00/ > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7095949 Looks fine to me. Thanks for porting this to 7u-dev. These intermittent failures are a real pain! -Chris. > > -Rob From chris.hegarty at oracle.com Tue Nov 22 02:49:46 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 22 Nov 2011 10:49:46 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <1321956053.6943.6.camel@chalkhill> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> <4EC423AE.9090801@oracle.com> <1321954056.5911.79.camel@chalkhill> <4ECB6D84.3010402@oracle.com> <1321956053.6943.6.camel@chalkhill> Message-ID: <4ECB7E4A.5000505@oracle.com> Neil, I filed: CR 7114558: "Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN)" And also reviewed your webrev. Looks fine. -Chris. On 11/22/11 10:00 AM, Neil Richards wrote: > On Tue, 2011-11-22 at 09:38 +0000, Chris Hegarty wrote: >> Let me know the details synopsis/descriptions/etc and I'll file a new >> CR. I'm guessing its just some cleanup/style issues, right? >> >> -Chris. > > I've uploaded a webrev with the gap between the two [1]. > > The differences are the use of memset (rather than bzero) and NI_MAXHOST > (rather than MAXHOSTNAMELEN). > > Thanks for helping me out with this, > > Regards, Neil > > [1] http://cr.openjdk.java.net/~ngmr/ojdk-229.1/webrev.00/ > From neil.richards at ngmr.net Tue Nov 22 03:02:44 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Tue, 22 Nov 2011 11:02:44 +0000 Subject: hg: jdk8/tl/jdk: 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Message-ID: <20111122110306.6DB7647421@hg.openjdk.java.net> Changeset: ee2fa62fb09f Author: ngmr Date: 2011-11-22 09:51 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee2fa62fb09f 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Reviewed-by: chegar Contributed-by: Neil Richards ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c From neil.richards at ngmr.net Tue Nov 22 03:10:25 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Tue, 22 Nov 2011 11:10:25 +0000 Subject: Question about getaddrinfo in Inet4AddressImpl.c In-Reply-To: <4ECB7E4A.5000505@oracle.com> References: <4EA665E0.3000607@linux.vnet.ibm.com> <4EA68442.5070202@oracle.com> <4EA7BB07.4040407@linux.vnet.ibm.com> <4EA7C539.4010602@oracle.com> <4EA7D1D2.3040405@linux.vnet.ibm.com> <4EA7D4A2.1010507@oracle.com> <4EA7E18A.1020809@oracle.com> <4EB15CA7.8040305@linux.vnet.ibm.com> <1320251608.7502.7.camel@chalkhill> <4EB9323D.1060206@linux.vnet.ibm.com> <4EB98247.2020903@oracle.com> <4EB9FF42.8010700@linux.vnet.ibm.com> <1321023204.24687.3.camel@chalkhill> <12E04DDE-587B-42AB-884A-FF63451159B6@oracle.com> <4EC0A9EE.9060108@linux.vnet.ibm.com> <4EC12268.2040605@oracle.com> <4EC20D48.9060503@linux.vnet.ibm.com> <4EC248A6.6040703@oracle.com> <4EC24EEE.9030801@linux.vnet.ibm.com> <1321376414.3957.1.camel@chalkhill> <4EC3167F.5010404@linux.vnet.ibm.com> <4EC423AE.9090801@oracle.com> <1321954056.5911.79.camel@chalkhill> <4ECB6D84.3010402@oracle.com> <1321956053.6943.6.camel@chalkhill> <4ECB7E4A.5000505@oracle.com> Message-ID: <1321960225.6943.10.camel@chalkhill> On Tue, 2011-11-22 at 10:49 +0000, Chris Hegarty wrote: > Neil, > > I filed: > CR 7114558: "Inet4AddressImpl should use memset (rather than bzero) and > NI_MAXHOST (rather than MAXHOSTNAMELEN)" > > And also reviewed your webrev. Looks fine. > > -Chris. Hi Chris, Thanks for reviewing this for me - I've now pushed the change up [1]. Regards, Neil [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee2fa62fb09f -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From Alan.Bateman at oracle.com Tue Nov 22 05:22:15 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 22 Nov 2011 13:22:15 +0000 Subject: A behavior difference about reachable test for address zero In-Reply-To: References: Message-ID: <4ECBA207.4070608@oracle.com> On 22/11/2011 08:40, Sean Chou wrote: > > Hi all, > > I found a behavior difference when running the testcase PingZero > on linux and windows. > On Linux, it prints "reachable" while on windows "unreachable", which > is the same with > the result of running "ping 0.0.0.0" on these two platforms. > > Is it a bug or intended? > Do you get the same thing when you use the ping command? -Alan From sean.mullan at oracle.com Tue Nov 22 07:00:27 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 22 Nov 2011 15:00:27 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20111122150129.76BD647427@hg.openjdk.java.net> Changeset: 1945abeb82a0 Author: mullan Date: 2011-11-22 08:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1945abeb82a0 7093090: Reduce synchronization in java.security.Policy.getPolicyNoCheck Reviewed-by: valeriep ! src/share/classes/java/security/Policy.java Changeset: bb8f19b80557 Author: mullan Date: 2011-11-22 09:00 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb8f19b80557 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: b4d7020c2a40 Author: mullan Date: 2011-11-22 09:17 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4d7020c2a40 Merge From xuelei.fan at oracle.com Wed Nov 23 03:42:22 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 23 Nov 2011 11:42:22 +0000 Subject: hg: jdk8/tl/jdk: 7113275: compatibility issue with MD2 trust anchor and old X509TrustManager Message-ID: <20111123114243.2BCA647437@hg.openjdk.java.net> Changeset: 82151e860a64 Author: xuelei Date: 2011-11-23 03:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82151e860a64 7113275: compatibility issue with MD2 trust anchor and old X509TrustManager Summary: also reviewed by Dennis.Gu at oracle.com Reviewed-by: mullan ! src/share/classes/sun/security/ssl/SSLContextImpl.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/MD2InTrustAnchor.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/TrustTrustedCert.java From chris.hegarty at oracle.com Wed Nov 23 04:31:24 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 23 Nov 2011 12:31:24 +0000 Subject: hg: jdk8/tl/jdk: 6776144: java/lang/ThreadGroup/NullThreadName.java fails with Thread group is not destroyed , fastdebug LINUX Message-ID: <20111123123142.4948947439@hg.openjdk.java.net> Changeset: 7eb0debca9b3 Author: chegar Date: 2011-11-23 12:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7eb0debca9b3 6776144: java/lang/ThreadGroup/NullThreadName.java fails with Thread group is not destroyed ,fastdebug LINUX Reviewed-by: chegar, dholmes Contributed-by: gary.adams at oracle.com ! test/java/lang/ThreadGroup/NullThreadName.java From sean.coffey at oracle.com Wed Nov 23 06:54:51 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 23 Nov 2011 14:54:51 +0000 Subject: hg: jdk8/tl/jdk: 7102369: remove java.rmi.server.codebase property parsing from registyimpl; ... Message-ID: <20111123145508.EFCEA4743A@hg.openjdk.java.net> Changeset: d27f0b2f1476 Author: coffeys Date: 2011-11-23 14:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d27f0b2f1476 7102369: remove java.rmi.server.codebase property parsing from registyimpl 7094468: rmiregistry clean up Reviewed-by: smarks ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java + test/java/rmi/registry/readTest/readTest.java + test/java/rmi/registry/readTest/readTest.sh + test/java/rmi/registry/readTest/testPkg/Client.java + test/java/rmi/registry/readTest/testPkg/Hello.java + test/java/rmi/registry/readTest/testPkg/Server.java From chris.hegarty at oracle.com Wed Nov 23 09:57:07 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 23 Nov 2011 17:57:07 +0000 Subject: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos Message-ID: <4ECD33F3.1000109@oracle.com> This CR is simply to cleanup the style of the java.net.HttpCookie source code. This has bugged me for a while! 1) Remove extraneous newlines 2) Use consistent javadoc comment style 3) Fix typos in public specification, specifically: http->HTTP, url->URL, seperated->separated, llegal->illegal 4) Where possible limit code to 80 columns Minor implementation changes 1) Make 'name', 'assignors', and 'whenCreated', final since they are immutable 2) Remove unnecessary StringBuilder from toNetscapeHeaderString ( since it is using String concatenation ) 3) Use diamond in ArrayList construction, parse() For ease of review I generated HTML diffs of the javadoc (see webrev). Reviewers can simply scan the javadoc diffs, and scan the new source file for style ( and be confident that there are no spec changes ). http://cr.openjdk.java.net/~chegar/7115150/webrev.00/webrev/ Thanks, -Chris. From maurizio.cimadamore at oracle.com Thu Nov 24 05:40:20 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 24 Nov 2011 13:40:20 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20111124134026.77EE747443@hg.openjdk.java.net> Changeset: c896d95e7469 Author: mcimadamore Date: 2011-11-24 13:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c896d95e7469 7115046: Add AST node for lambda expressions Summary: Add tree nodes for representing lambda expressions and update relevant visitors interfaces Reviewed-by: jjg + src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java Changeset: ec59a2ce9114 Author: mcimadamore Date: 2011-11-24 13:38 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec59a2ce9114 7115049: Add AST node for method references Summary: Add tree nodes for representing method/constructor references and update relevant visitors interfaces Reviewed-by: jjg + src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java From zhouyx at linux.vnet.ibm.com Thu Nov 24 21:58:58 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Fri, 25 Nov 2011 13:58:58 +0800 Subject: A behavior difference about reachable test for address zero In-Reply-To: <4ECBA207.4070608@oracle.com> References: <4ECBA207.4070608@oracle.com> Message-ID: Yes. ping 0.0.0.0 on linux works; while windows report not reachable. On Tue, Nov 22, 2011 at 9:22 PM, Alan Bateman wrote: > On 22/11/2011 08:40, Sean Chou wrote: > >> >> Hi all, >> >> I found a behavior difference when running the testcase PingZero on >> linux and windows. >> On Linux, it prints "reachable" while on windows "unreachable", which is >> the same with >> the result of running "ping 0.0.0.0" on these two platforms. >> >> Is it a bug or intended? >> >> Do you get the same thing when you use the ping command? > > -Alan > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111125/b3850062/attachment.html From michael.x.mcmahon at oracle.com Fri Nov 25 02:02:42 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Fri, 25 Nov 2011 10:02:42 +0000 Subject: RFR 7115150: java.net.HttpCookie code cleanup, style, formatting, typos In-Reply-To: <4ECD33F3.1000109@oracle.com> References: <4ECD33F3.1000109@oracle.com> Message-ID: <4ECF67C2.6010303@oracle.com> Looks good to me. - Michael. On 23/11/11 17:57, Chris Hegarty wrote: > This CR is simply to cleanup the style of the java.net.HttpCookie > source code. This has bugged me for a while! > > 1) Remove extraneous newlines > 2) Use consistent javadoc comment style > 3) Fix typos in public specification, specifically: > http->HTTP, url->URL, seperated->separated, llegal->illegal > 4) Where possible limit code to 80 columns > > Minor implementation changes > 1) Make 'name', 'assignors', and 'whenCreated', final since they are > immutable > 2) Remove unnecessary StringBuilder from toNetscapeHeaderString > ( since it is using String concatenation ) > 3) Use diamond in ArrayList construction, parse() > > For ease of review I generated HTML diffs of the javadoc (see webrev). > Reviewers can simply scan the javadoc diffs, and scan the new source > file for style ( and be confident that there are no spec changes ). > > http://cr.openjdk.java.net/~chegar/7115150/webrev.00/webrev/ > > Thanks, > -Chris. From chris.hegarty at oracle.com Fri Nov 25 03:28:35 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 25 Nov 2011 11:28:35 +0000 Subject: A behavior difference about reachable test for address zero In-Reply-To: References: <4ECBA207.4070608@oracle.com> Message-ID: <4ECF7BE3.3040901@oracle.com> On 25/11/2011 05:58, Sean Chou wrote: > Yes. ping 0.0.0.0 on linux works; while windows report not reachable. Right, so InetAddress.isReachable is reporting the same result as the native ping command. Is this an issue for you guys? -Chris. > On Tue, Nov 22, 2011 at 9:22 PM, Alan Bateman > wrote: > > On 22/11/2011 08:40, Sean Chou wrote: > > > Hi all, > > I found a behavior difference when running the testcase > PingZero on linux and windows. > On Linux, it prints "reachable" while on windows "unreachable", > which is the same with > the result of running "ping 0.0.0.0" on these two platforms. > > Is it a bug or intended? > > Do you get the same thing when you use the ping command? > > -Alan > > > > > -- > Best Regards, > Sean Chou > From chris.hegarty at oracle.com Fri Nov 25 04:15:42 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 25 Nov 2011 12:15:42 +0000 Subject: hg: jdk8/tl/jdk: 7115150: java.net.HttpCookie code cleanup, style, formatting, typos Message-ID: <20111125121559.479E247465@hg.openjdk.java.net> Changeset: 387190e1f782 Author: chegar Date: 2011-11-25 10:34 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/387190e1f782 7115150: java.net.HttpCookie code cleanup, style, formatting, typos Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java From zhouyx at linux.vnet.ibm.com Fri Nov 25 05:58:53 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Fri, 25 Nov 2011 21:58:53 +0800 Subject: A behavior difference about reachable test for address zero In-Reply-To: <4ECF7BE3.3040901@oracle.com> References: <4ECBA207.4070608@oracle.com> <4ECF7BE3.3040901@oracle.com> Message-ID: No. Once before a time there was a testcase about it, so I just make sure it's a testcase problem. Thanks anyway. On Fri, Nov 25, 2011 at 7:28 PM, Chris Hegarty wrote: > On 25/11/2011 05:58, Sean Chou wrote: > >> Yes. ping 0.0.0.0 on linux works; while windows report not reachable. >> > > Right, so InetAddress.isReachable is reporting the same result as the > native ping command. Is this an issue for you guys? > > -Chris. > > On Tue, Nov 22, 2011 at 9:22 PM, Alan Bateman > >> wrote: >> >> On 22/11/2011 08:40, Sean Chou wrote: >> >> >> Hi all, >> >> I found a behavior difference when running the testcase >> PingZero on linux and windows. >> On Linux, it prints "reachable" while on windows "unreachable", >> which is the same with >> the result of running "ping 0.0.0.0" on these two platforms. >> >> Is it a bug or intended? >> >> Do you get the same thing when you use the ping command? >> >> -Alan >> >> >> >> >> -- >> Best Regards, >> Sean Chou >> >> -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111125/49db0b7e/attachment.html From chris.hegarty at oracle.com Fri Nov 25 08:28:45 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 25 Nov 2011 16:28:45 +0000 Subject: hg: jdk8/tl/jdk: 7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor Message-ID: <20111125162909.5898247468@hg.openjdk.java.net> Changeset: e5ecbf555679 Author: chegar Date: 2011-11-25 13:46 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5ecbf555679 7115586: Suppress creation of SocketImpl in SocketAdaptor's constructor Reviewed-by: chegar, alanb Contributed-by: sajia at taobao.com ! src/share/classes/sun/nio/ch/SocketAdaptor.java From littlee at linux.vnet.ibm.com Sun Nov 27 22:52:07 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 28 Nov 2011 14:52:07 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. Message-ID: <4ED32F97.4070109@linux.vnet.ibm.com> Hi guys, When we call InetAddress.getLocalHost(), we usually return the first entry of inet address array. The array keeps the same order as getaddrinfo gets (duplication has been removed). In Windows 2008 sp2 or later version Windows OS with multiple NICs, getaddrinfo() sorts the Addresses and linklocal/APIPA address appears first now. So user will get a APIPA address even if a more useful address is available. A simple test case will show this problem: /public class InetTest { public static void main(String[] args) throws Exception{ InetAddress addr = InetAddress.getLocalHost(); System.out.println(addr); System.out.println(addr.isLinkLocalAddress()); } }/ I'd like to propose a patch, which get the useful address info, if available, in the InetAddress.java (attached and pasted). Anyone interested in it ? diff --git src/share/classes/java/net/InetAddress.java src/share/classes/java/net/InetAddress.java index 8758cab..4cbf890 100644 --- src/share/classes/java/net/InetAddress.java +++ src/share/classes/java/net/InetAddress.java @@ -1443,9 +1443,17 @@ class InetAddress implements java.io.Serializable { uhe2.initCause(uhe); throw uhe2; } - cachedLocalHost = localAddrs[0]; + for (InetAddress addr : localAddrs) { + if (!addr.isLinkLocalAddress()) { + cachedLocalHost = addr; + break; + } + } + if (cachedLocalHost == null) { + cachedLocalHost = localAddrs[0]; + } cacheTime = now; - ret = localAddrs[0]; + ret = cachedLocalHost; } } return ret; -- Yours Charles -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111128/0acea40f/attachment.html -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch.contr.v0 Url: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111128/0acea40f/patch.contr.v0 From Alan.Bateman at oracle.com Mon Nov 28 01:41:16 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 28 Nov 2011 09:41:16 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED32F97.4070109@linux.vnet.ibm.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> Message-ID: <4ED3573C.7000607@oracle.com> On 28/11/2011 06:52, Charles Lee wrote: > Hi guys, > > When we call InetAddress.getLocalHost(), we usually return the first > entry of inet address array. The array keeps the same order as > getaddrinfo gets (duplication has been removed). > > In Windows 2008 sp2 or later version Windows OS with multiple NICs, > getaddrinfo() sorts the Addresses and linklocal/APIPA address appears > first now. So user will get a APIPA address even if a more useful > address is available. I'm curious about this behavior. Are you saying that the host's name resolves to addresses on all interfaces? Also I thought that the default was to sort the addresses so that IPv4 addresses appear before IPv6 addresses (unless java.net.preferIPv6Addresses is set to true). -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111128/cace9a6d/attachment.html From weijun.wang at oracle.com Mon Nov 28 02:17:55 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 28 Nov 2011 10:17:55 +0000 Subject: hg: jdk8/tl/jdk: 7115744: Do not call File::deleteOnExit in security tests Message-ID: <20111128101848.4C3E547472@hg.openjdk.java.net> Changeset: 022540b11147 Author: weijun Date: 2011-11-28 18:16 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/022540b11147 7115744: Do not call File::deleteOnExit in security tests Reviewed-by: xuelei ! test/sun/security/krb5/auto/CrossRealm.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OkAsDelegateXRealm.java ! test/sun/security/krb5/auto/OneKDC.java ! test/sun/security/krb5/auto/SSL.java ! test/sun/security/krb5/auto/W83.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngineResult/Deserialize.java From xuelei.fan at oracle.com Mon Nov 28 02:36:23 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 28 Nov 2011 10:36:23 +0000 Subject: hg: jdk8/tl/jdk: 7115524: sun.security.provider.certpath.ssl.SSLServerCertStore no longer works Message-ID: <20111128103649.4785447474@hg.openjdk.java.net> Changeset: d1928ae4e0a2 Author: xuelei Date: 2011-11-28 02:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1928ae4e0a2 7115524: sun.security.provider.certpath.ssl.SSLServerCertStore no longer works Reviewed-by: weijun ! src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStore.java From neil.richards at ngmr.net Mon Nov 28 03:02:08 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Mon, 28 Nov 2011 11:02:08 +0000 Subject: hg: jdk8/tl/jdk: 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found Message-ID: <20111128110219.E7A3847475@hg.openjdk.java.net> Changeset: 955aae8c1106 Author: ngmr Date: 2011-11-24 11:34 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/955aae8c1106 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c From neil.richards at ngmr.net Mon Nov 28 03:35:41 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Mon, 28 Nov 2011 11:35:41 +0000 Subject: hg: jdk8/tl/jdk: 7094995: Trailing daemon thread causes continuous GC in agentvm mode Message-ID: <20111128113600.0806D47476@hg.openjdk.java.net> Changeset: 6fbd69f8e3ab Author: ngmr Date: 2011-11-18 09:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fbd69f8e3ab 7094995: Trailing daemon thread causes continuous GC in agentvm mode Summary: Shutdown GcInducingThread once test (successfully) finishes Reviewed-by: alanb, chegar, dholmes, darcy Contributed-by: Neil Richards ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java From maurizio.cimadamore at oracle.com Mon Nov 28 08:28:28 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 28 Nov 2011 16:28:28 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20111128162835.25DAC4747A@hg.openjdk.java.net> Changeset: 9448fe783fd2 Author: mcimadamore Date: 2011-11-28 15:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9448fe783fd2 7115050: Add parser support for lambda expressions Summary: Add support for parsing lambda expressions to JavacParser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Lexer.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/LambdaNotSupported.java + test/tools/javac/diags/examples/NotAStatement.java ! test/tools/javac/generics/rare/6665356/T6665356.out + test/tools/javac/lambda/LambdaParserTest.java Changeset: 3343b22e2761 Author: mcimadamore Date: 2011-11-28 16:05 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3343b22e2761 7115052: Add parser support for method references Summary: Add support for parsing method references to JavacParser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples/IllegalChar.java + test/tools/javac/diags/examples/MethodReferencesNotSupported.java + test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/quid/T6999438.out From littlee at linux.vnet.ibm.com Mon Nov 28 18:11:10 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 29 Nov 2011 10:11:10 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED3573C.7000607@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> Message-ID: <4ED43F3E.9070300@linux.vnet.ibm.com> On 11/28/2011 05:41 PM, Alan Bateman wrote: > On 28/11/2011 06:52, Charles Lee wrote: >> Hi guys, >> >> When we call InetAddress.getLocalHost(), we usually return the first >> entry of inet address array. The array keeps the same order as >> getaddrinfo gets (duplication has been removed). >> >> In Windows 2008 sp2 or later version Windows OS with multiple NICs, >> getaddrinfo() sorts the Addresses and linklocal/APIPA address appears >> first now. So user will get a APIPA address even if a more useful >> address is available. > I'm curious about this behavior. Are you saying that the host's name > resolves to addresses on all interfaces? Yes. > Also I thought that the default was to sort the addresses so that IPv4 > addresses appear before IPv6 addresses (unless > java.net.preferIPv6Addresses is set to true). > > -Alan You are right. The ipv4 will appear in front of ipv6, but the order of ipv4 or ipv6 (separately) will not be sorted. -- Yours Charles -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111129/a7ab9978/attachment.html From david.holmes at oracle.com Mon Nov 28 21:27:43 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 29 Nov 2011 05:27:43 +0000 Subject: hg: jdk8/tl/jdk: 7109092: Wrong computation results with double at armsflt Message-ID: <20111129052802.D0F0647488@hg.openjdk.java.net> Changeset: cf47846165f4 Author: dholmes Date: 2011-11-29 00:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf47846165f4 7109092: Wrong computation results with double at armsflt Summary: need to link to custom soft-float library with required FP accuracy Reviewed-by: alanb, ohair ! make/common/Defs-embedded.gmk From Alan.Bateman at oracle.com Tue Nov 29 01:47:38 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 29 Nov 2011 09:47:38 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED43F3E.9070300@linux.vnet.ibm.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> Message-ID: <4ED4AA3A.5010504@oracle.com> On 29/11/2011 02:11, Charles Lee wrote: > You are right. The ipv4 will appear in front of ipv6, but the order of > ipv4 or ipv6 (separately) will not be sorted. Right, but it means that if the host has at least one IPv4 address then it will be chosen and the IPv6 addresses will be ignored. I should say that I don't have an issue with doing something about this but I'm trying to understand how this issue arises. I'm guessing that either the host is IPv6 only or that somehow the host name is resolving to a list that includes a 169.254.0.0/16 address. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111129/db896a96/attachment.html From xueming.shen at oracle.com Tue Nov 29 11:38:26 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 29 Nov 2011 19:38:26 +0000 Subject: hg: jdk8/tl/jdk: 7110149: Update the JDK8 bundled zlib library to the latest version 1.2.5 Message-ID: <20111129193836.8F7FA4749D@hg.openjdk.java.net> Changeset: a47de985fec9 Author: sherman Date: 2011-11-29 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a47de985fec9 7110149: Update the JDK8 bundled zlib library to the latest version 1.2.5 Summary: updated to zlib-1.2.5 Reviewed-by: alanb ! make/common/Defs.gmk ! make/java/zip/FILES_c.gmk ! make/sun/splashscreen/FILES_c.gmk - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h + src/share/native/java/util/zip/zlib-1.2.5/ChangeLog + src/share/native/java/util/zip/zlib-1.2.5/README + src/share/native/java/util/zip/zlib-1.2.5/compress.c + src/share/native/java/util/zip/zlib-1.2.5/crc32.h + src/share/native/java/util/zip/zlib-1.2.5/deflate.c + src/share/native/java/util/zip/zlib-1.2.5/deflate.h + src/share/native/java/util/zip/zlib-1.2.5/gzclose.c + src/share/native/java/util/zip/zlib-1.2.5/gzguts.h + src/share/native/java/util/zip/zlib-1.2.5/gzlib.c + src/share/native/java/util/zip/zlib-1.2.5/gzread.c + src/share/native/java/util/zip/zlib-1.2.5/gzwrite.c + src/share/native/java/util/zip/zlib-1.2.5/infback.c + src/share/native/java/util/zip/zlib-1.2.5/inffast.c + src/share/native/java/util/zip/zlib-1.2.5/inffast.h + src/share/native/java/util/zip/zlib-1.2.5/inffixed.h + src/share/native/java/util/zip/zlib-1.2.5/inflate.c + src/share/native/java/util/zip/zlib-1.2.5/inflate.h + src/share/native/java/util/zip/zlib-1.2.5/inftrees.c + src/share/native/java/util/zip/zlib-1.2.5/inftrees.h + src/share/native/java/util/zip/zlib-1.2.5/patches/ChangeLog_java + src/share/native/java/util/zip/zlib-1.2.5/trees.c + src/share/native/java/util/zip/zlib-1.2.5/trees.h + src/share/native/java/util/zip/zlib-1.2.5/uncompr.c + src/share/native/java/util/zip/zlib-1.2.5/zadler32.c + src/share/native/java/util/zip/zlib-1.2.5/zconf.h + src/share/native/java/util/zip/zlib-1.2.5/zcrc32.c + src/share/native/java/util/zip/zlib-1.2.5/zlib.h + src/share/native/java/util/zip/zlib-1.2.5/zutil.c + src/share/native/java/util/zip/zlib-1.2.5/zutil.h + test/java/util/zip/DeInflate.java From xueming.shen at oracle.com Tue Nov 29 13:04:41 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 29 Nov 2011 21:04:41 +0000 Subject: hg: jdk8/tl/jdk: 7109837: Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer Message-ID: <20111129210451.713F64749F@hg.openjdk.java.net> Changeset: 07e359b01d8a Author: sherman Date: 2011-11-29 13:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07e359b01d8a 7109837: Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer Summary: added methods Adler32/CRC32.update(ByteBuffer) Reviewed-by: alanb ! make/java/zip/mapfile-vers ! src/share/classes/java/util/zip/Adler32.java ! src/share/classes/java/util/zip/CRC32.java ! src/share/native/java/util/zip/Adler32.c ! src/share/native/java/util/zip/CRC32.c + test/java/util/zip/TimeChecksum.java From lana.steuck at oracle.com Tue Nov 29 13:52:23 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 29 Nov 2011 21:52:23 +0000 Subject: hg: jdk8/tl/hotspot: 42 new changesets Message-ID: <20111129215350.DABB2474A0@hg.openjdk.java.net> Changeset: 869804b759e7 Author: jcoomes Date: 2011-11-04 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/869804b759e7 7108553: Bump the hs23 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5bda8dae4e14 Author: never Date: 2011-10-23 20:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5bda8dae4e14 7103784: enable some flags by default Reviewed-by: kvn ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 754110e02bd5 Author: never Date: 2011-10-23 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/754110e02bd5 7103380: assertion failure with -XX:+PrintNativeNMethods Reviewed-by: kvn, iveresov ! src/share/vm/asm/codeBuffer.cpp Changeset: 42783d1414b2 Author: never Date: 2011-10-23 23:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/42783d1414b2 Merge - make/templates/bsd-header Changeset: b20d64f83668 Author: twisti Date: 2011-10-24 07:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b20d64f83668 7090904: JSR 292: JRuby junit test crashes in PSScavengeRootsClosure::do_oop Reviewed-by: kvn, never, jrose ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 12d38ffcba2a Author: twisti Date: 2011-10-25 00:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/12d38ffcba2a 7094138: JSR 292: JRuby junit test fails in CallSite.setTargetNormal: obj->is_oop() failed: sanity check Reviewed-by: iveresov, never ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 2ec638646e86 Author: twisti Date: 2011-10-25 04:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2ec638646e86 7101642: JSR 292: SIGSEGV in java.lang.invoke.MethodHandleImpl$FieldAccessor.getFieldI(Ljava/lang/Object;)I Reviewed-by: kvn, iveresov ! src/share/vm/runtime/sharedRuntime.cpp Changeset: a6eef545f1a2 Author: never Date: 2011-10-25 08:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6eef545f1a2 7103224: collision between __LEAF define in interfaceSupport.hpp and /usr/include/sys/cdefs.h with gcc Reviewed-by: never Contributed-by: Omair Majid ! src/share/vm/opto/addnode.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/interfaceSupport.hpp Changeset: e69a66a1457b Author: kvn Date: 2011-10-25 12:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e69a66a1457b 7059039: EA: don't change non-escaping state of NULL pointer Summary: NULL pointers do not escape but escape state propagation may change it leading to worser results. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: d8cb48376797 Author: kvn Date: 2011-10-26 06:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d8cb48376797 7097546: Optimize use of CMOVE instructions Summary: Avoid CMove in a loop if possible. May generate CMove if it could be moved outside a loop. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.hpp Changeset: cec1757a0134 Author: twisti Date: 2011-10-27 04:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cec1757a0134 7102657: JSR 292: C1 deoptimizes unlinked invokedynamic call sites infinitely Reviewed-by: never, bdelsart ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/opto/runtime.cpp Changeset: e0658a9b3f87 Author: kvn Date: 2011-10-27 09:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e0658a9b3f87 7105364: JDK8 b10 hotspot: src/share/vm/ci/ciMethodHandle.cpp Error: Use "." or "->" Summary: Define ciMethodHandle::print_chain_impl() and ciMethodHandle::print_chain() bodies only in debug builds. Reviewed-by: never, twisti ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp Changeset: 34535d2cb362 Author: iveresov Date: 2011-10-27 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/34535d2cb362 7104177: Tiered: -XX:+PrintCanonicalization doesn't work with -XX:+TieredCompilation Summary: Initialize printable_bci of instruction when passed to Canonicalizer Reviewed-by: kvn, never ! src/share/vm/c1/c1_Canonicalizer.hpp Changeset: f350490a45fd Author: kvn Date: 2011-10-27 18:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f350490a45fd 7105611: Set::print() is broken Summary: Reimplemented class VSetI_ to restore Set::print(). Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp Changeset: eba044a722a4 Author: never Date: 2011-10-28 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eba044a722a4 7103261: crash with jittester on sparc Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp + test/compiler/7103261/Test7103261.java Changeset: e3b0dcc327b9 Author: twisti Date: 2011-10-31 03:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e3b0dcc327b9 7104561: UseRDPCForConstantTableBase doesn't work after shorten branches changes Reviewed-by: never, kvn ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/opto/machnode.cpp Changeset: 71699e9d8673 Author: kvn Date: 2011-10-31 15:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71699e9d8673 7106907: 64 bit VM fails test compiler/6865265/StackOverflowBug.java Summary: Use -Xss224k instead of -Xss128k. Reviewed-by: never ! test/compiler/6865265/StackOverflowBug.java Changeset: e342a5110bed Author: twisti Date: 2011-11-03 01:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e342a5110bed 7106774: JSR 292: nightly test inlineMHTarget fails with wrong result Reviewed-by: kvn ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/runtime/deoptimization.cpp Changeset: 448691f285a5 Author: twisti Date: 2011-11-03 04:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/448691f285a5 7106944: assert(_pc == *pc_addr) failed may be too strong Reviewed-by: kvn, never ! src/cpu/x86/vm/frame_x86.cpp Changeset: 1feb272af3a7 Author: never Date: 2011-11-04 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1feb272af3a7 6636110: unaligned stackpointer leads to crash during deoptimization Reviewed-by: never, kvn Contributed-by: Andreas Schoesser ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp Changeset: 59e515ee9354 Author: kvn Date: 2011-11-07 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59e515ee9354 7059047: EA: can't find initializing store with several CheckCastPP Summary: Split adjust_escape_state() method into two methods to find initializing stores. Reviewed-by: never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 44ce519bc3d1 Author: never Date: 2011-11-08 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/44ce519bc3d1 7104960: JSR 292: +VerifyMethodHandles in product JVM can overflow buffer Reviewed-by: kvn, jrose, twisti ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: c9a03402fe56 Author: never Date: 2011-11-08 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9a03402fe56 7105305: assert check_method_context proper context Reviewed-by: jrose, kvn ! src/share/vm/code/dependencies.cpp ! src/share/vm/oops/constantPoolKlass.cpp Changeset: e3e363b2bf19 Author: never Date: 2011-11-08 20:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e3e363b2bf19 7108242: jinfo -permstat shouldn't report interned strings as part of perm Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 83d0b5cd1438 Author: twisti Date: 2011-11-09 00:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/83d0b5cd1438 7087727: JSR 292: C2 crash if ScavengeRootsInCode=2 when "static final" MethodHandle constants are in use Reviewed-by: jrose, kvn, never ! src/share/vm/opto/callGenerator.cpp Changeset: 7e0e43cf86d6 Author: kvn Date: 2011-11-09 06:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7e0e43cf86d6 7109887: java/util/Arrays/CopyMethods.java fails with -XX:+DeoptimizeALot Summary: zero array when compiled code is deoptimized. Reviewed-by: never, twisti ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: 670a74b863fc Author: kvn Date: 2011-11-09 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected Summary: Use dead nodes elimination code in PhaseIdealLoop before executing EA. Reviewed-by: never, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/runtime/globals.hpp Changeset: 78bef05801ca Author: twisti Date: 2011-11-10 04:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78bef05801ca Merge - src/share/vm/precompiled.hpp ! src/share/vm/runtime/globals.hpp Changeset: 3c7d67df8d07 Author: dholmes Date: 2011-11-10 06:23 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c7d67df8d07 7108264: Fix for 7104173 is insufficient Summary: Disable PrintVMOptions by default for all builds Reviewed-by: dsamersoff, twisti ! src/share/vm/runtime/globals.hpp Changeset: f9a80a035a4a Author: coleenp Date: 2011-11-15 12:40 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9a80a035a4a Merge ! src/share/vm/runtime/globals.hpp Changeset: 5a5ed80bea5b Author: ysr Date: 2011-10-26 21:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5a5ed80bea5b 7105163: CMS: some mentions of MinChunkSize should be IndexSetStart Summary: Fixed the instances that were missed in the changeset for 7099817. Reviewed-by: stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp Changeset: 59519b7d7b9d Author: tonyp Date: 2011-10-28 13:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59519b7d7b9d Merge Changeset: 6fd81579526f Author: brutisso Date: 2011-10-31 08:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6fd81579526f 7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise Summary: arrayOopDesc::max_array_length() should return a value that does not overflow a size_t if it is converted to bytes. Reviewed-by: kvn, dholmes ! make/jprt.properties ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/quickSort.cpp ! test/Makefile Changeset: ed80554efa25 Author: brutisso Date: 2011-11-02 08:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed80554efa25 7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV Summary: _cset_rs_update_cl[] was indexed with values beyond what it is set up to handle. Reviewed-by: ysr, jmasa, johnc ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: 8aae2050e83e Author: tonyp Date: 2011-11-07 22:11 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8aae2050e83e 7092309: G1: introduce old region set Summary: Keep track of all the old regions in the heap with a heap region set. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: 53074c2c4600 Author: tonyp Date: 2011-11-08 00:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/53074c2c4600 7099849: G1: include heap region information in hs_err files Reviewed-by: johnc, brutisso, poonam ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/vmError.cpp Changeset: ab5107bee78c Author: brutisso Date: 2011-11-09 23:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ab5107bee78c 7110190: GCCause::to_string missing case for _adaptive_size_policy Summary: Added case for _adaptive_size_policy Reviewed-by: johnc, ysr ! src/share/vm/gc_interface/gcCause.cpp Changeset: aa4c21b00f7f Author: brutisso Date: 2011-11-15 20:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa4c21b00f7f 7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow Summary: Reduce what arrayOopDesc::max_array_length() returns to avoid int overflow Reviewed-by: kvn, dholmes, tonyp ! src/share/vm/oops/arrayOop.hpp Changeset: 2ceafe3ceb65 Author: poonam Date: 2011-11-16 16:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2ceafe3ceb65 7110428: Crash during HeapDump operation Reviewed-by: ysr, dholmes ! src/share/vm/services/heapDumper.cpp Changeset: b1754f3fbbd8 Author: tonyp Date: 2011-11-17 13:14 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b1754f3fbbd8 Merge Changeset: 6c2a55d4902f Author: jcoomes Date: 2011-11-18 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6c2a55d4902f Merge Changeset: fde2a39ed7f3 Author: jcoomes Date: 2011-11-18 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fde2a39ed7f3 Added tag hs23-b06 for changeset 6c2a55d4902f ! .hgtags From lana.steuck at oracle.com Tue Nov 29 13:52:55 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 29 Nov 2011 21:52:55 +0000 Subject: hg: jdk8/tl/jdk: 9 new changesets Message-ID: <20111129215424.D1670474A1@hg.openjdk.java.net> Changeset: 2a147f854257 Author: twisti Date: 2011-11-02 02:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a147f854257 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + test/java/lang/invoke/CallSiteTest.java Changeset: 5c34ed65176e Author: twisti Date: 2011-11-09 00:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c34ed65176e 7109063: JSR 292: fix for 7085860 is incomplete Reviewed-by: iveresov, alanb, jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! test/ProblemList.txt ! test/java/lang/invoke/CallSiteTest.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java Changeset: bdb2d63c176c Author: jcoomes Date: 2011-11-18 16:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdb2d63c176c Merge ! test/ProblemList.txt Changeset: 89952dc5be8e Author: prr Date: 2011-11-17 10:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89952dc5be8e 7113017: Use POSIX compliant include file headers in sun/awt/medialib/mlib_types.h Reviewed-by: prr, bae Contributed-by: littlee at linux.vnet.ibm.com ! src/share/native/sun/awt/medialib/mlib_types.h Changeset: 60331bbcf4ad Author: lana Date: 2011-11-18 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60331bbcf4ad Merge Changeset: 855675a4235b Author: lana Date: 2011-11-23 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/855675a4235b Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 3c248d0e2c48 Author: lana Date: 2011-11-28 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c248d0e2c48 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: c5313d712ab0 Author: lana Date: 2011-11-29 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5313d712ab0 Merge Changeset: a3edcdff37e1 Author: lana Date: 2011-11-29 13:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3edcdff37e1 Merge From alan.bateman at oracle.com Wed Nov 30 07:26:40 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 30 Nov 2011 15:26:40 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111130152715.55301474B0@hg.openjdk.java.net> Changeset: 4749df4f04f1 Author: alanb Date: 2011-11-30 10:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4749df4f04f1 7030624: size_t usages in src/windows/native/java/io/io_util_md.c need to be re-visited Reviewed-by: lancea, chegar ! src/share/native/java/io/io_util.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h Changeset: 7795c41ed54c Author: alanb Date: 2011-11-30 12:42 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7795c41ed54c 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes) Reviewed-by: lancea, chegar, smarks ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/io/SequenceInputStream.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Enum.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/rmi/MarshalledObject.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/rmi/server/LogStream.java ! src/share/classes/java/rmi/server/RemoteObject.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/Unsafe.java ! src/share/classes/sun/misc/VM.java From stuart.marks at oracle.com Wed Nov 30 13:12:23 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 30 Nov 2011 21:12:23 +0000 Subject: hg: jdk8/tl/jdk: 7116322: enhance javac make rule with a little bit of instrumentation Message-ID: <20111130211232.E8AE1474C4@hg.openjdk.java.net> Changeset: 43a630f11af6 Author: smarks Date: 2011-11-30 13:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6 7116322: enhance javac make rule with a little bit of instrumentation Reviewed-by: dholmes, ohair ! make/common/Rules.gmk From littlee at linux.vnet.ibm.com Wed Nov 30 17:13:46 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Thu, 01 Dec 2011 09:13:46 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED4AA3A.5010504@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> Message-ID: <4ED6D4CA.7090807@linux.vnet.ibm.com> Hi Alan, Sorry for the late reply. Please see below: On 11/29/2011 05:47 PM, Alan Bateman wrote: > On 29/11/2011 02:11, Charles Lee wrote: >> You are right. The ipv4 will appear in front of ipv6, but the order >> of ipv4 or ipv6 (separately) will not be sorted. > Right, but it means that if the host has at least one IPv4 address > then it will be chosen and the IPv6 addresses will be ignored. I > should say that I don't have an issue with doing something about this > but I'm trying to understand how this issue arises. I'm guessing that > either the host is IPv6 only or that somehow the host name is > resolving to a list that includes a 169.254.0.0/16 address. Yes. In the customer scenario, the return value is 169.254.*.*/16 address. > > -Alan. -- Yours Charles -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111201/d6ef5f99/attachment.html