Question about getaddrinfo in Inet4AddressImpl.c

[Neil Richards]

On Wed, 2011-11-02 at 23:07 +0800, Charles Lee wrote:
> On 10/26/2011 06:31 PM, Chris Hegarty wrote:
> > On 26/10/2011 10:36, Alan Bateman wrote:
> >> On 26/10/2011 10:24, Charles Lee wrote:
> >>>
> >>>
> >>> />>> I don't think this code has changed too much since then and
> >>> probably could do with a clean-up./
> >>> Not true.
> >> I'm talking about the InetAddress* code, that hasn't changed
> >> significantly and probably could do with some modernization now.
> >
> > Yes, please submit a patch for this cleanup and we'll review it.
> >
> > -Chris.
> >
> >>
> >> -Alan.
> >
> Hi Chris, Alan and Neil,
> 
> Here is the rest of the patch (attached). The patch is a little big 
> because some formats.
> 

For ease of review, I've uploaded this change (ie. the combination of
Charles' 'patch.contr.v1' and 'patch.contr.part2') as a webrev [1].

My initial (and picky) observation is that the code indentation needs a
little work to comply with the OpenJDK coding conventions [2].
(Particularly using a standard indentation for 4 spaces).

Regards, Neil 

[1] http://cr.openjdk.java.net/~ngmr/ojdk-229/webrev.00/
[2] http://www.oracle.com/technetwork/java/codeconventions-150003.pdf

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU